| Message ID | 20180529124639.13172-1-ramon.fried@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] bug.h: introduce WARN_ONCE | expand |
On Tue, May 29, 2018 at 03:46:39PM +0300, Ramon Fried wrote: > From: Ramon Fried <ramon.fried@linaro.org> > > Add WARN_ONCE definition to allow single time notification > of warnings to the user. > > Change-Id: If14d878dba04f3c976c0c2ae079a0f7642047006 You forgot the Signed-off-by line (which I can't fix, sorry) and while at it need to mention the version of the kernel this comes from, and no Change-Id lines please, thanks! -- Tom
On Tue, Jun 5, 2018 at 5:45 PM, Tom Rini <trini@konsulko.com> wrote: > On Tue, May 29, 2018 at 03:46:39PM +0300, Ramon Fried wrote: > >> From: Ramon Fried <ramon.fried@linaro.org> >> >> Add WARN_ONCE definition to allow single time notification >> of warnings to the user. >> >> Change-Id: If14d878dba04f3c976c0c2ae079a0f7642047006 > > You forgot the Signed-off-by line (which I can't fix, sorry) and while > at it need to mention the version of the kernel this comes from, and no Hi Tom. Terribly sorry for the bad patch. I will resend shorty. Regarding the Linux kernel version it came from, this is not just a copy paste, I had to change it a bit (removed the __section(.data.once). I will add to the commit message the version I referenced it from though. > Change-Id lines please, thanks! Sure, I don't even know how it slipped in, probably a system wide configuration... Thanks, Ramon. > > -- > Tom
diff --git a/include/linux/bug.h b/include/linux/bug.h index f07bb716fc0..e43871dee44 100644 --- a/include/linux/bug.h +++ b/include/linux/bug.h @@ -20,6 +20,13 @@ unlikely(__ret_warn_on); \ }) +#define WARN(condition, format...) ({ \ + int __ret_warn_on = !!(condition); \ + if (unlikely(__ret_warn_on)) \ + printf(format); \ + unlikely(__ret_warn_on); \ +}) + #define WARN_ON_ONCE(condition) ({ \ static bool __warned; \ int __ret_warn_once = !!(condition); \ @@ -31,4 +38,15 @@ unlikely(__ret_warn_once); \ }) +#define WARN_ONCE(condition, format...) ({ \ + static bool __warned; \ + int __ret_warn_once = !!(condition); \ + \ + if (unlikely(__ret_warn_once && !__warned)) { \ + __warned = true; \ + WARN(1, format); \ + } \ + unlikely(__ret_warn_once); \ +}) + #endif /* _LINUX_BUG_H */
From: Ramon Fried <ramon.fried@linaro.org> Add WARN_ONCE definition to allow single time notification of warnings to the user. Change-Id: If14d878dba04f3c976c0c2ae079a0f7642047006 --- v2: accidently commited the wrong file. noticed by Masahiro Yamada include/linux/bug.h | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)