diff mbox series

bus: imx-weim: drop unnecessary DT node name NULL check

Message ID 20180829200258.14463-1-robh@kernel.org
State Accepted
Commit b1a23445364d321bfe8d8aa432c955d07ed38b47
Headers show
Series bus: imx-weim: drop unnecessary DT node name NULL check | expand

Commit Message

Rob Herring Aug. 29, 2018, 8:02 p.m. UTC
Checking the child node names is pointless as the DT node name can
never be NULL, so remove it.

Cc: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Rob Herring <robh@kernel.org>

---
 drivers/bus/imx-weim.c | 3 ---
 1 file changed, 3 deletions(-)

-- 
2.17.1

Comments

Shawn Guo Sept. 3, 2018, 2:17 a.m. UTC | #1
On Wed, Aug 29, 2018 at 03:02:58PM -0500, Rob Herring wrote:
> Checking the child node names is pointless as the DT node name can

> never be NULL, so remove it.

> 

> Cc: Shawn Guo <shawnguo@kernel.org>

> Signed-off-by: Rob Herring <robh@kernel.org>


Applied, thanks.
Shawn Guo Sept. 3, 2018, 4:21 a.m. UTC | #2
On Wed, Aug 29, 2018 at 03:02:58PM -0500, Rob Herring wrote:
> Checking the child node names is pointless as the DT node name can

> never be NULL, so remove it.

> 

> Cc: Shawn Guo <shawnguo@kernel.org>

> Signed-off-by: Rob Herring <robh@kernel.org>


Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
index 6a94aa6a22c2..d84996a4528e 100644
--- a/drivers/bus/imx-weim.c
+++ b/drivers/bus/imx-weim.c
@@ -156,9 +156,6 @@  static int __init weim_parse_dt(struct platform_device *pdev,
 	}
 
 	for_each_available_child_of_node(pdev->dev.of_node, child) {
-		if (!child->name)
-			continue;
-
 		ret = weim_timing_setup(child, base, devtype);
 		if (ret)
 			dev_warn(&pdev->dev, "%pOF set timing failed.\n",