| Message ID | 1539206455-29342-3-git-send-email-rplsssn@codeaurora.org |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
On Fri, Oct 12 2018 at 01:43 -0600, Rafael J. Wysocki wrote: >On Fri, Oct 12, 2018 at 12:08 AM Lina Iyer <ilina@codeaurora.org> wrote: >> On Thu, Oct 11 2018 at 14:56 -0600, Rafael J. Wysocki wrote: >> >On Wednesday, October 10, 2018 11:20:49 PM CEST Raju P.L.S.S.S.N wrote: >> >> From: Ulf Hansson <ulf.hansson@linaro.org> >> The cluster states should account for that additional latency. > >But even then, you need to be sure that the idle governor selected >"cluster" states for all of the CPUs in the cluster. It might select >WFI for one of them for reasons unrelated to the distance to the next >timer (so to speak), for example. > Well, if cpuidle chooses WFI, cpu_pm_enter() will not be called. So for that case we are okay with this approach. >> Just the CPU's power down states need not care about that. > >The meaning of this sentence isn't particularly clear to me. :-) > What I meant to say is that if cpuidle chooses a CPU only power down state, then, atleast in ARM architecture, we would not choose to power down the cluster in the firmware. To power down the cluster in the firmware, all CPUs need to choose a cluster state, which would account the additional latency of powering off and on the domain. How I ever thought that I could convey this point in that line is beyond me now. Sorry! >> But, it would be nice if the PM domain governor could be cognizant of >> the idle state chosen for each CPU, that way we dont configure the >> domain to be powered off when the CPUs have just chosen to power down >> (not chosen a cluster state). I think that is a whole different topic to >> discuss. > >This needs to be sorted out before the approach becomes viable, though. > We embarked on that discussion a few years ago, but realized that there is a lot more complexity involved in specifying that especially with DT. I believe ACPI has a way to specify this. But DT and driver code currently don't have a nice way to propagate this requirement to the domain governor. So we shelved it for the future. >Basically, the domain governor needs to track what the idle governor >did for all of the CPUs in the domain and only let the domain go off >if the latency matches all of the states selected by the idle >governor. Otherwise the idle governor's assumptions would be violated >and it would become essentially useless overhead. > Well, we kinda do that in the CPU PM domain governor. By looking at the next wakeup and the latency/QoS requirement of each CPU in the domain, we determine if the domain can be powered off. But, if we were to do this by correlating domain idle states to that of the required CPU idle state, then a lot needs to plumbed in to the cpuidle and driver model. The current approach is rather simple while meeting most of the requirement. Thanks, Lina
diff --git a/kernel/cpu_pm.c b/kernel/cpu_pm.c index 67b02e1..492d4a8 100644 --- a/kernel/cpu_pm.c +++ b/kernel/cpu_pm.c @@ -16,9 +16,11 @@ */ #include <linux/kernel.h> +#include <linux/cpu.h> #include <linux/cpu_pm.h> #include <linux/module.h> #include <linux/notifier.h> +#include <linux/pm_runtime.h> #include <linux/spinlock.h> #include <linux/syscore_ops.h> @@ -91,6 +93,7 @@ int cpu_pm_enter(void) { int nr_calls; int ret = 0; + struct device *dev = get_cpu_device(smp_processor_id()); ret = cpu_pm_notify(CPU_PM_ENTER, -1, &nr_calls); if (ret) @@ -100,6 +103,9 @@ int cpu_pm_enter(void) */ cpu_pm_notify(CPU_PM_ENTER_FAILED, nr_calls - 1, NULL); + if (!ret && dev && dev->pm_domain) + pm_runtime_put_sync_suspend(dev); + return ret; } EXPORT_SYMBOL_GPL(cpu_pm_enter); @@ -118,6 +124,11 @@ int cpu_pm_enter(void) */ int cpu_pm_exit(void) { + struct device *dev = get_cpu_device(smp_processor_id()); + + if (dev && dev->pm_domain) + pm_runtime_get_sync(dev); + return cpu_pm_notify(CPU_PM_EXIT, -1, NULL); } EXPORT_SYMBOL_GPL(cpu_pm_exit);