diff mbox series

pinctrl: msm: mark PM functions as __maybe_unused

Message ID 20181210205955.3254660-1-arnd@arndb.de
State Accepted
Commit d1040ea06f0004fe22e881a8fe88db12ef83b98c
Headers show
Series pinctrl: msm: mark PM functions as __maybe_unused | expand

Commit Message

Arnd Bergmann Dec. 10, 2018, 8:59 p.m. UTC 
Without CONFIG_PM_SLEEP, we get annoyting warnings about unused functions:

drivers/pinctrl/qcom/pinctrl-msm.c:1082:12: error: 'msm_pinctrl_resume' defined but not used [-Werror=unused-function]
 static int msm_pinctrl_resume(struct device *dev)
            ^~~~~~~~~~~~~~~~~~
drivers/pinctrl/qcom/pinctrl-msm.c:1075:12: error: 'msm_pinctrl_suspend' defined but not used [-Werror=unused-function]
 static int msm_pinctrl_suspend(struct device *dev)

Mark them as __maybe_unused to shut up the warning and silently drop
the functions without having to add ugly #ifdefs.

Fixes: 977d057ad346 ("pinctrl: msm: Add sleep pinctrl state transitions")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/pinctrl/qcom/pinctrl-msm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.20.0

Comments

Linus Walleij Dec. 21, 2018, 10:07 a.m. UTC | #1 
On Mon, Dec 10, 2018 at 9:59 PM Arnd Bergmann <arnd@arndb.de> wrote:

> Without CONFIG_PM_SLEEP, we get annoyting warnings about unused functions:

>

> drivers/pinctrl/qcom/pinctrl-msm.c:1082:12: error: 'msm_pinctrl_resume' defined but not used [-Werror=unused-function]

>  static int msm_pinctrl_resume(struct device *dev)

>             ^~~~~~~~~~~~~~~~~~

> drivers/pinctrl/qcom/pinctrl-msm.c:1075:12: error: 'msm_pinctrl_suspend' defined but not used [-Werror=unused-function]

>  static int msm_pinctrl_suspend(struct device *dev)

>

> Mark them as __maybe_unused to shut up the warning and silently drop

> the functions without having to add ugly #ifdefs.

>

> Fixes: 977d057ad346 ("pinctrl: msm: Add sleep pinctrl state transitions")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Patch applied w/ACKs and fixing a typo.

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
index 87cbebe217fd..ee8119879c4c 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm.c
@@ -1072,14 +1072,14 @@  static void msm_pinctrl_setup_pm_reset(struct msm_pinctrl *pctrl)
 		}
 }
 
-static int msm_pinctrl_suspend(struct device *dev)
+static __maybe_unused int msm_pinctrl_suspend(struct device *dev)
 {
 	struct msm_pinctrl *pctrl = dev_get_drvdata(dev);
 
 	return pinctrl_force_sleep(pctrl->pctrl);
 }
 
-static int msm_pinctrl_resume(struct device *dev)
+static __maybe_unused int msm_pinctrl_resume(struct device *dev)
 {
 	struct msm_pinctrl *pctrl = dev_get_drvdata(dev);