diff mbox series

[for-4.1,5/8] target/riscv: Use pattern groups in insn16.decode

Message ID 20190401031155.21293-6-richard.henderson@linaro.org
State New
Headers show
Series target/riscv: decodetree improvments | expand

Commit Message

Richard Henderson April 1, 2019, 3:11 a.m. UTC 
This eliminates about half of the complicated decode
bits within insn_trans/trans_rvc.inc.c.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 target/riscv/insn_trans/trans_rvc.inc.c | 63 -------------------------
 target/riscv/insn_trans/trans_rvi.inc.c |  6 +++
 target/riscv/insn16.decode              | 29 +++++++++---
 3 files changed, 29 insertions(+), 69 deletions(-)

-- 
2.17.1

Comments

Palmer Dabbelt April 25, 2019, 4:04 p.m. UTC | #1 
On Sun, 31 Mar 2019 20:11:52 PDT (-0700), richard.henderson@linaro.org wrote:
> This eliminates about half of the complicated decode

> bits within insn_trans/trans_rvc.inc.c.

>

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

> ---

>  target/riscv/insn_trans/trans_rvc.inc.c | 63 -------------------------

>  target/riscv/insn_trans/trans_rvi.inc.c |  6 +++

>  target/riscv/insn16.decode              | 29 +++++++++---

>  3 files changed, 29 insertions(+), 69 deletions(-)

>

> diff --git a/target/riscv/insn_trans/trans_rvc.inc.c b/target/riscv/insn_trans/trans_rvc.inc.c

> index 691b1e2725..43bff97f66 100644

> --- a/target/riscv/insn_trans/trans_rvc.inc.c

> +++ b/target/riscv/insn_trans/trans_rvc.inc.c

> @@ -18,16 +18,6 @@

>   * this program.  If not, see <http://www.gnu.org/licenses/>.

>   */

>

> -static bool trans_c_addi4spn(DisasContext *ctx, arg_c_addi4spn *a)

> -{

> -    if (a->nzuimm == 0) {

> -        /* Reserved in ISA */

> -        return false;

> -    }

> -    arg_addi arg = { .rd = a->rd, .rs1 = 2, .imm = a->nzuimm };

> -    return trans_addi(ctx, &arg);

> -}

> -

>  static bool trans_c_flw_ld(DisasContext *ctx, arg_c_flw_ld *a)

>  {

>  #ifdef TARGET_RISCV32

> @@ -79,25 +69,6 @@ static bool trans_c_jal_addiw(DisasContext *ctx, arg_c_jal_addiw *a)

>  #endif

>  }

>

> -static bool trans_c_addi16sp_lui(DisasContext *ctx, arg_c_addi16sp_lui *a)

> -{

> -    if (a->rd == 2) {

> -        /* C.ADDI16SP */

> -        arg_addi arg = { .rd = 2, .rs1 = 2, .imm = a->imm_addi16sp };

> -        return trans_addi(ctx, &arg);

> -    } else if (a->imm_lui != 0) {

> -        /* C.LUI */

> -        if (a->rd == 0) {

> -            /* Hint: insn is valid but does not affect state */

> -            return true;

> -        }

> -        arg_lui arg = { .rd = a->rd, .imm = a->imm_lui };

> -        return trans_lui(ctx, &arg);

> -    }

> -    return false;

> -}

> -

> -

>  static bool trans_c_subw(DisasContext *ctx, arg_c_subw *a)

>  {

>  #ifdef TARGET_RISCV64

> @@ -130,40 +101,6 @@ static bool trans_c_flwsp_ldsp(DisasContext *ctx, arg_c_flwsp_ldsp *a)

>      return false;

>  }

>

> -static bool trans_c_jr_mv(DisasContext *ctx, arg_c_jr_mv *a)

> -{

> -    if (a->rd != 0 && a->rs2 == 0) {

> -        /* C.JR */

> -        arg_jalr arg = { .rd = 0, .rs1 = a->rd, .imm = 0 };

> -        return trans_jalr(ctx, &arg);

> -    } else if (a->rd != 0 && a->rs2 != 0) {

> -        /* C.MV */

> -        arg_add arg = { .rd = a->rd, .rs1 = 0, .rs2 = a->rs2 };

> -        return trans_add(ctx, &arg);

> -    }

> -    return false;

> -}

> -

> -static bool trans_c_ebreak_jalr_add(DisasContext *ctx, arg_c_ebreak_jalr_add *a)

> -{

> -    if (a->rd == 0 && a->rs2 == 0) {

> -        /* C.EBREAK */

> -        arg_ebreak arg = { };

> -        return trans_ebreak(ctx, &arg);

> -    } else if (a->rd != 0) {

> -        if (a->rs2 == 0) {

> -            /* C.JALR */

> -            arg_jalr arg = { .rd = 1, .rs1 = a->rd, .imm = 0 };

> -            return trans_jalr(ctx, &arg);

> -        } else {

> -            /* C.ADD */

> -            arg_add arg = { .rd = a->rd, .rs1 = a->rd, .rs2 = a->rs2 };

> -            return trans_add(ctx, &arg);

> -        }

> -    }

> -    return false;

> -}

> -

>  static bool trans_c_fswsp_sdsp(DisasContext *ctx, arg_c_fswsp_sdsp *a)

>  {

>  #ifdef TARGET_RISCV32

> diff --git a/target/riscv/insn_trans/trans_rvi.inc.c b/target/riscv/insn_trans/trans_rvi.inc.c

> index d420a4d8b2..caf91f9a05 100644

> --- a/target/riscv/insn_trans/trans_rvi.inc.c

> +++ b/target/riscv/insn_trans/trans_rvi.inc.c

> @@ -18,6 +18,12 @@

>   * this program.  If not, see <http://www.gnu.org/licenses/>.

>   */

>

> +static bool trans_illegal(DisasContext *ctx, arg_empty *a)

> +{

> +    gen_exception_illegal(ctx);

> +    return true;

> +}

> +

>  static bool trans_lui(DisasContext *ctx, arg_lui *a)

>  {

>      if (a->rd != 0) {

> diff --git a/target/riscv/insn16.decode b/target/riscv/insn16.decode

> index add9cf3923..3c79edf1c9 100644

> --- a/target/riscv/insn16.decode

> +++ b/target/riscv/insn16.decode

> @@ -70,7 +70,6 @@

>  # Formats 16:

>  @cr        ....  ..... .....  .. &r      rs2=%rs2_5       rs1=%rd     %rd

>  @ci        ... . ..... .....  .. &i      imm=%imm_ci      rs1=%rd     %rd

> -@ciw       ...   ........ ... .. &ciw    nzuimm=%nzuimm_ciw           rd=%rs2_3

>  @cl_d      ... ... ... .. ... .. &i      imm=%uimm_cl_d   rs1=%rs1_3  rd=%rs2_3

>  @cl_w      ... ... ... .. ... .. &i      imm=%uimm_cl_w   rs1=%rs1_3  rd=%rs2_3

>  @cl        ... ... ... .. ... .. &cl                      rs1=%rs1_3  rd=%rs2_3

> @@ -86,8 +85,12 @@

>  @c_sdsp    ... . .....  ..... .. &s      imm=%uimm_6bit_sd rs1=2 rs2=%rs2_5

>  @c_swsp    ... . .....  ..... .. &s      imm=%uimm_6bit_sw rs1=2 rs2=%rs2_5

>  @c_li      ... . .....  ..... .. &i      imm=%imm_ci rs1=0 %rd

> +@c_lui     ... . .....  ..... .. &u      imm=%imm_lui %rd

> +@c_jalr    ... . .....  ..... .. &i      imm=0 rs1=%rd

> +@c_mv      ... . ..... .....  .. &i      imm=0 rs1=%rs2_5 %rd

>

> -@c_addi16sp_lui ... .  ..... ..... .. &caddi16sp_lui %imm_lui %imm_addi16sp %rd

> +@c_addi4spn     ... .  ..... ..... .. &i imm=%nzuimm_ciw rs1=2 rd=%rs2_3

> +@c_addi16sp     ... .  ..... ..... .. &i imm=%imm_addi16sp rs1=2 rd=2

>  @c_flwsp_ldsp   ... .  ..... ..... .. &cflwsp_ldsp uimm_flwsp=%uimm_6bit_lw \

>      uimm_ldsp=%uimm_6bit_ld %rd

>  @c_fswsp_sdsp   ... .  ..... ..... .. &cfswsp_sdsp uimm_fswsp=%uimm_6bit_sw \

> @@ -101,7 +104,11 @@

>  @c_andi         ... . .. ... ..... .. &i imm=%imm_ci rs1=%rs1_3 rd=%rs1_3

>

>  # *** RV64C Standard Extension (Quadrant 0) ***

> -c_addi4spn        000    ........ ... 00 @ciw

> +{

> +  # Opcode of all zeros is illegal; rd != 0, nzuimm == 0 is reserved.

> +  illegal         000  000 000 00 --- 00

> +  addi            000  ... ... .. ... 00 @c_addi4spn

> +}

>  fld               001  ... ... .. ... 00 @cl_d

>  lw                010  ... ... .. ... 00 @cl_w

>  c_flw_ld          011  --- ... -- ... 00 @cl    #Note: Must parse uimm manually

> @@ -113,7 +120,10 @@ c_fsw_sd          111  --- ... -- ... 00 @cs    #Note: Must parse uimm manually

>  addi              000 .  .....  ..... 01 @ci

>  c_jal_addiw       001 .  .....  ..... 01 @ci #Note: parse rd and/or imm manually

>  addi              010 .  .....  ..... 01 @c_li

> -c_addi16sp_lui    011 .  .....  ..... 01 @c_addi16sp_lui # shares opc with C.LUI

> +{

> +  addi            011 .  00010  ..... 01 @c_addi16sp

> +  lui             011 .  .....  ..... 01 @c_lui

> +}

>  srli              100 . 00 ...  ..... 01 @c_shift

>  srai              100 . 01 ...  ..... 01 @c_shift

>  andi              100 . 10 ...  ..... 01 @c_andi

> @@ -132,8 +142,15 @@ slli              000 .  .....  ..... 10 @c_shift2

>  fld               001 .  .....  ..... 10 @c_ldsp

>  lw                010 .  .....  ..... 10 @c_lwsp

>  c_flwsp_ldsp      011 .  .....  ..... 10 @c_flwsp_ldsp #C.LDSP:RV64;C.FLWSP:RV32

> -c_jr_mv           100 0  .....  ..... 10 @cr

> -c_ebreak_jalr_add 100 1  .....  ..... 10 @cr

> +{

> +  jalr            100 0  .....  00000 10 @c_jalr rd=0  # C.JR

> +  addi            100 0  .....  ..... 10 @c_mv

> +}

> +{

> +  ebreak          100 1  00000  00000 10

> +  jalr            100 1  .....  00000 10 @c_jalr rd=1  # C.JALR

> +  add             100 1  .....  ..... 10 @cr

> +}

>  fsd               101   ......  ..... 10 @c_sdsp

>  sw                110 .  .....  ..... 10 @c_swsp

>  c_fswsp_sdsp      111 .  .....  ..... 10 @c_fswsp_sdsp #C.SDSP:RV64;C.FSWSP:RV32


Reviewed-by: Palmer Dabbelt <palmer@sifive.com>
diff mbox series

Patch

diff --git a/target/riscv/insn_trans/trans_rvc.inc.c b/target/riscv/insn_trans/trans_rvc.inc.c
index 691b1e2725..43bff97f66 100644
--- a/target/riscv/insn_trans/trans_rvc.inc.c
+++ b/target/riscv/insn_trans/trans_rvc.inc.c
@@ -18,16 +18,6 @@ 
  * this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-static bool trans_c_addi4spn(DisasContext *ctx, arg_c_addi4spn *a)
-{
-    if (a->nzuimm == 0) {
-        /* Reserved in ISA */
-        return false;
-    }
-    arg_addi arg = { .rd = a->rd, .rs1 = 2, .imm = a->nzuimm };
-    return trans_addi(ctx, &arg);
-}
-
 static bool trans_c_flw_ld(DisasContext *ctx, arg_c_flw_ld *a)
 {
 #ifdef TARGET_RISCV32
@@ -79,25 +69,6 @@  static bool trans_c_jal_addiw(DisasContext *ctx, arg_c_jal_addiw *a)
 #endif
 }
 
-static bool trans_c_addi16sp_lui(DisasContext *ctx, arg_c_addi16sp_lui *a)
-{
-    if (a->rd == 2) {
-        /* C.ADDI16SP */
-        arg_addi arg = { .rd = 2, .rs1 = 2, .imm = a->imm_addi16sp };
-        return trans_addi(ctx, &arg);
-    } else if (a->imm_lui != 0) {
-        /* C.LUI */
-        if (a->rd == 0) {
-            /* Hint: insn is valid but does not affect state */
-            return true;
-        }
-        arg_lui arg = { .rd = a->rd, .imm = a->imm_lui };
-        return trans_lui(ctx, &arg);
-    }
-    return false;
-}
-
-
 static bool trans_c_subw(DisasContext *ctx, arg_c_subw *a)
 {
 #ifdef TARGET_RISCV64
@@ -130,40 +101,6 @@  static bool trans_c_flwsp_ldsp(DisasContext *ctx, arg_c_flwsp_ldsp *a)
     return false;
 }
 
-static bool trans_c_jr_mv(DisasContext *ctx, arg_c_jr_mv *a)
-{
-    if (a->rd != 0 && a->rs2 == 0) {
-        /* C.JR */
-        arg_jalr arg = { .rd = 0, .rs1 = a->rd, .imm = 0 };
-        return trans_jalr(ctx, &arg);
-    } else if (a->rd != 0 && a->rs2 != 0) {
-        /* C.MV */
-        arg_add arg = { .rd = a->rd, .rs1 = 0, .rs2 = a->rs2 };
-        return trans_add(ctx, &arg);
-    }
-    return false;
-}
-
-static bool trans_c_ebreak_jalr_add(DisasContext *ctx, arg_c_ebreak_jalr_add *a)
-{
-    if (a->rd == 0 && a->rs2 == 0) {
-        /* C.EBREAK */
-        arg_ebreak arg = { };
-        return trans_ebreak(ctx, &arg);
-    } else if (a->rd != 0) {
-        if (a->rs2 == 0) {
-            /* C.JALR */
-            arg_jalr arg = { .rd = 1, .rs1 = a->rd, .imm = 0 };
-            return trans_jalr(ctx, &arg);
-        } else {
-            /* C.ADD */
-            arg_add arg = { .rd = a->rd, .rs1 = a->rd, .rs2 = a->rs2 };
-            return trans_add(ctx, &arg);
-        }
-    }
-    return false;
-}
-
 static bool trans_c_fswsp_sdsp(DisasContext *ctx, arg_c_fswsp_sdsp *a)
 {
 #ifdef TARGET_RISCV32
diff --git a/target/riscv/insn_trans/trans_rvi.inc.c b/target/riscv/insn_trans/trans_rvi.inc.c
index d420a4d8b2..caf91f9a05 100644
--- a/target/riscv/insn_trans/trans_rvi.inc.c
+++ b/target/riscv/insn_trans/trans_rvi.inc.c
@@ -18,6 +18,12 @@ 
  * this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+static bool trans_illegal(DisasContext *ctx, arg_empty *a)
+{
+    gen_exception_illegal(ctx);
+    return true;
+}
+
 static bool trans_lui(DisasContext *ctx, arg_lui *a)
 {
     if (a->rd != 0) {
diff --git a/target/riscv/insn16.decode b/target/riscv/insn16.decode
index add9cf3923..3c79edf1c9 100644
--- a/target/riscv/insn16.decode
+++ b/target/riscv/insn16.decode
@@ -70,7 +70,6 @@ 
 # Formats 16:
 @cr        ....  ..... .....  .. &r      rs2=%rs2_5       rs1=%rd     %rd
 @ci        ... . ..... .....  .. &i      imm=%imm_ci      rs1=%rd     %rd
-@ciw       ...   ........ ... .. &ciw    nzuimm=%nzuimm_ciw           rd=%rs2_3
 @cl_d      ... ... ... .. ... .. &i      imm=%uimm_cl_d   rs1=%rs1_3  rd=%rs2_3
 @cl_w      ... ... ... .. ... .. &i      imm=%uimm_cl_w   rs1=%rs1_3  rd=%rs2_3
 @cl        ... ... ... .. ... .. &cl                      rs1=%rs1_3  rd=%rs2_3
@@ -86,8 +85,12 @@ 
 @c_sdsp    ... . .....  ..... .. &s      imm=%uimm_6bit_sd rs1=2 rs2=%rs2_5
 @c_swsp    ... . .....  ..... .. &s      imm=%uimm_6bit_sw rs1=2 rs2=%rs2_5
 @c_li      ... . .....  ..... .. &i      imm=%imm_ci rs1=0 %rd
+@c_lui     ... . .....  ..... .. &u      imm=%imm_lui %rd
+@c_jalr    ... . .....  ..... .. &i      imm=0 rs1=%rd
+@c_mv      ... . ..... .....  .. &i      imm=0 rs1=%rs2_5 %rd
 
-@c_addi16sp_lui ... .  ..... ..... .. &caddi16sp_lui %imm_lui %imm_addi16sp %rd
+@c_addi4spn     ... .  ..... ..... .. &i imm=%nzuimm_ciw rs1=2 rd=%rs2_3
+@c_addi16sp     ... .  ..... ..... .. &i imm=%imm_addi16sp rs1=2 rd=2
 @c_flwsp_ldsp   ... .  ..... ..... .. &cflwsp_ldsp uimm_flwsp=%uimm_6bit_lw \
     uimm_ldsp=%uimm_6bit_ld %rd
 @c_fswsp_sdsp   ... .  ..... ..... .. &cfswsp_sdsp uimm_fswsp=%uimm_6bit_sw \
@@ -101,7 +104,11 @@ 
 @c_andi         ... . .. ... ..... .. &i imm=%imm_ci rs1=%rs1_3 rd=%rs1_3
 
 # *** RV64C Standard Extension (Quadrant 0) ***
-c_addi4spn        000    ........ ... 00 @ciw
+{
+  # Opcode of all zeros is illegal; rd != 0, nzuimm == 0 is reserved.
+  illegal         000  000 000 00 --- 00
+  addi            000  ... ... .. ... 00 @c_addi4spn
+}
 fld               001  ... ... .. ... 00 @cl_d
 lw                010  ... ... .. ... 00 @cl_w
 c_flw_ld          011  --- ... -- ... 00 @cl    #Note: Must parse uimm manually
@@ -113,7 +120,10 @@  c_fsw_sd          111  --- ... -- ... 00 @cs    #Note: Must parse uimm manually
 addi              000 .  .....  ..... 01 @ci
 c_jal_addiw       001 .  .....  ..... 01 @ci #Note: parse rd and/or imm manually
 addi              010 .  .....  ..... 01 @c_li
-c_addi16sp_lui    011 .  .....  ..... 01 @c_addi16sp_lui # shares opc with C.LUI
+{
+  addi            011 .  00010  ..... 01 @c_addi16sp
+  lui             011 .  .....  ..... 01 @c_lui
+}
 srli              100 . 00 ...  ..... 01 @c_shift
 srai              100 . 01 ...  ..... 01 @c_shift
 andi              100 . 10 ...  ..... 01 @c_andi
@@ -132,8 +142,15 @@  slli              000 .  .....  ..... 10 @c_shift2
 fld               001 .  .....  ..... 10 @c_ldsp
 lw                010 .  .....  ..... 10 @c_lwsp
 c_flwsp_ldsp      011 .  .....  ..... 10 @c_flwsp_ldsp #C.LDSP:RV64;C.FLWSP:RV32
-c_jr_mv           100 0  .....  ..... 10 @cr
-c_ebreak_jalr_add 100 1  .....  ..... 10 @cr
+{
+  jalr            100 0  .....  00000 10 @c_jalr rd=0  # C.JR
+  addi            100 0  .....  ..... 10 @c_mv
+}
+{
+  ebreak          100 1  00000  00000 10
+  jalr            100 1  .....  00000 10 @c_jalr rd=1  # C.JALR
+  add             100 1  .....  ..... 10 @cr
+}
 fsd               101   ......  ..... 10 @c_sdsp
 sw                110 .  .....  ..... 10 @c_swsp
 c_fswsp_sdsp      111 .  .....  ..... 10 @c_fswsp_sdsp #C.SDSP:RV64;C.FSWSP:RV32