| Message ID | 20200610194625.3597460-1-robh@kernel.org |
|---|---|
| State | Accepted |
| Commit | ad440432d1f93b387eaf9796afcbc02467a2a841 |
| Headers | show |
| Series | dt-bindings: mfd: Ensure 'syscon' has a more specific compatible | expand |
Arnd, On Wed, 10 Jun 2020, Rob Herring wrote: > Using 'syscon' alone should be avoided as compatible strings should be > specific enough to identify the exact set of registers contained. Update > the schema to ensure at least 2 compatible strings are present. I'm assuming you're okay with this? > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Maxime Ripard <maxime@cerno.tech> > Signed-off-by: Rob Herring <robh@kernel.org> > --- > FYI, there's 43 cases of this on arm32 in my testing. > > Documentation/devicetree/bindings/mfd/syscon.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml > index 19bdaf781853..af7a68051392 100644 > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml > @@ -43,7 +43,8 @@ properties: > > - contains: > const: syscon > - additionalItems: true > + minItems: 2 > + maxItems: 4 # Should be enough > > reg: > maxItems: 1 -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml index 19bdaf781853..af7a68051392 100644 --- a/Documentation/devicetree/bindings/mfd/syscon.yaml +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml @@ -43,7 +43,8 @@ properties: - contains: const: syscon - additionalItems: true + minItems: 2 + maxItems: 4 # Should be enough reg: maxItems: 1
Using 'syscon' alone should be avoided as compatible strings should be specific enough to identify the exact set of registers contained. Update the schema to ensure at least 2 compatible strings are present. Cc: Lee Jones <lee.jones@linaro.org> Cc: Maxime Ripard <maxime@cerno.tech> Signed-off-by: Rob Herring <robh@kernel.org> --- FYI, there's 43 cases of this on arm32 in my testing. Documentation/devicetree/bindings/mfd/syscon.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.25.1