diff mbox series

[1/3] brcmfmac: Fix for unable to return to visible SSID

Message ID 20200618160739.21457-2-chi-hsien.lin@cypress.com
State New
Headers show
Series connection related fix series | expand

Commit Message

Chi-Hsien Lin June 18, 2020, 4:07 p.m. UTC 
From: Soontak Lee <soontak.lee@cypress.com>

Unable to change back to visiable SSID because there is
no disable hidden ssid routine.

Signed-off-by: Soontak Lee <soontak.lee@cypress.com>
Signed-off-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
---
 .../broadcom/brcm80211/brcmfmac/cfg80211.c         | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

Comments

Kalle Valo July 14, 2020, 9:48 a.m. UTC | #1 
Chi-Hsien Lin <chi-hsien.lin@cypress.com> wrote:

> From: Soontak Lee <soontak.lee@cypress.com>

> 

> Unable to change back to visiable SSID because there is

> no disable hidden ssid routine.

> 

> Signed-off-by: Soontak Lee <soontak.lee@cypress.com>

> Signed-off-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com>


3 patches applied to wireless-drivers-next.git, thanks.

d9429d03b6bc brcmfmac: Fix for unable to return to visible SSID
1b050d9711f9 brcmfmac: Fix for wrong disconnection event source information
0d9de08da52a brcmfmac: do not disconnect for disassoc frame from unconnected AP

-- 
https://patchwork.kernel.org/patch/11612797/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
diff mbox series

Patch

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index a757abd7a599..d3d1100d56a7 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -4835,12 +4835,14 @@  brcmf_cfg80211_start_ap(struct wiphy *wiphy, struct net_device *ndev,
 			goto exit;
 		}
 
-		if (settings->hidden_ssid) {
-			err = brcmf_fil_iovar_int_set(ifp, "closednet", 1);
-			if (err) {
-				bphy_err(drvr, "closednet error (%d)\n", err);
-				goto exit;
-			}
+		err = brcmf_fil_iovar_int_set(ifp, "closednet",
+					      settings->hidden_ssid);
+		if (err) {
+			bphy_err(drvr, "%s closednet error (%d)\n",
+				 settings->hidden_ssid ?
+				 "enabled" : "disabled",
+				 err);
+			goto exit;
 		}
 
 		brcmf_dbg(TRACE, "AP mode configuration complete\n");