Message ID | 20200623113904.28805-1-peter.maydell@linaro.org |
---|---|
Headers | show |
Series | target-arm queue | expand |
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
Patchew URL: https://patchew.org/QEMU/20200623113904.28805-1-peter.maydell@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 00/42] target-arm queue Type: series Message-id: 20200623113904.28805-1-peter.maydell@linaro.org === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/20200623113904.28805-1-peter.maydell@linaro.org -> patchew/20200623113904.28805-1-peter.maydell@linaro.org Switched to a new branch 'test' 6bd9076 arm/virt: Add memory hot remove support c668237 tests/qtest/arm-cpu-features: Add feature setting tests 4f01797 target/arm: Check supported KVM features globally (not per vCPU) f9f6407 hw/arm/mps2-tz: Use the ARM SBCon two-wire serial bus interface 7d79ab3 hw/arm/mps2: Add audio I2S interface as unimplemented device 7f059c9 hw/arm/mps2: Add I2C devices 9af1079 hw/arm/mps2: Add SPI devices 4acc2b7 hw/arm/mps2: Map the FPGA I/O block 127d6ae hw/arm/mps2: Add CMSDK AHB GPIO peripherals as unimplemented devices e32341b hw/arm/mps2: Add CMSDK APB watchdog device 6c17506 hw/arm/mps2: Rename CMSDK AHB peripheral region ff60516 hw/arm/mps2: Document CMSDK/FPGA APB subsystem sections 24b7022 hw/arm: Use TYPE_VERSATILE_I2C instead of hardcoded string 0ff0e8b hw/i2c: Add header for ARM SBCon two-wire serial bus interface c80e1d0 hw/i2c/versatile_i2c: Add SCL/SDA definitions 6abd95f hw/i2c/versatile_i2c: Add definitions for register addresses ab757f4 hw/watchdog/cmsdk-apb-watchdog: Add trace event for lock status 16c5020 target/arm: Remove dead code relating to SABA and UABA 4cbe0e3 target/arm: Remove unnecessary gen_io_end() calls 9cdb63b target/arm: Move some functions used only in translate-neon.inc.c to that file 0d32b4f target/arm: Convert Neon VTRN to decodetree 41730a1 target/arm: Convert Neon VSWP to decodetree 0f0482a target/arm: Convert Neon 2-reg-misc VCVT insns to decodetree d289839 target/arm: Convert Neon 2-reg-misc VRINT insns to decodetree 6169ea1 target/arm: Convert Neon 2-reg-misc fp-compare-with-zero insns to decodetree 945dde2 target/arm: Convert simple fp Neon 2-reg-misc insns 50c8ce6 target/arm: Convert Neon VQABS, VQNEG to decodetree 91f4194 target/arm: Convert remaining simple 2-reg-misc Neon ops 236fd32 target/arm: Convert Neon 2-reg-misc VREV32 and VREV16 to decodetree 17ce51c target/arm: Make gen_swap_half() take separate src and dest 5a24956 target/arm: Fix capitalization in NeonGenTwo{Single, Double}OPFn typedefs 60ac3ab target/arm: Rename NeonGenOneOpFn to NeonGenOne64OpFn 2139ddc target/arm: Convert Neon 2-reg-misc crypto operations to decodetree 8fe2e5f target/arm: Convert vectorised 2-reg-misc Neon ops to decodetree 0d3dc85 target/arm: Convert Neon VCVT f16/f32 insns to decodetree 6bfaec5 target/arm: Convert Neon 2-reg-misc VSHLL to decodetree 06ba9e4 target/arm: Convert Neon narrowing moves to decodetree dba667b target/arm: Convert VZIP, VUZP to decodetree 7bb5bc9 target/arm: Convert Neon 2-reg-misc pairwise ops to decodetree 5c40ca4 target/arm: Convert Neon 2-reg-misc VREV64 to decodetree 6c9bf36 util/oslib-posix : qemu_init_exec_dir implementation for Mac 4d51f9a hw/arm/virt: Add 5.0 HW compat props === OUTPUT BEGIN === 1/42 Checking commit 4d51f9a49a37 (hw/arm/virt: Add 5.0 HW compat props) 2/42 Checking commit 6c9bf36253e1 (util/oslib-posix : qemu_init_exec_dir implementation for Mac) WARNING: architecture specific defines should be avoided #28: FILE: util/oslib-posix.c:60: +#ifdef __APPLE__ total: 0 errors, 1 warnings, 27 lines checked Patch 2/42 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/42 Checking commit 5c40ca41aec8 (target/arm: Convert Neon 2-reg-misc VREV64 to decodetree) 4/42 Checking commit 7bb5bc91f978 (target/arm: Convert Neon 2-reg-misc pairwise ops to decodetree) 5/42 Checking commit dba667b3b2b3 (target/arm: Convert VZIP, VUZP to decodetree) 6/42 Checking commit 06ba9e464f06 (target/arm: Convert Neon narrowing moves to decodetree) 7/42 Checking commit 6bfaec55c87e (target/arm: Convert Neon 2-reg-misc VSHLL to decodetree) 8/42 Checking commit 0d3dc85346e6 (target/arm: Convert Neon VCVT f16/f32 insns to decodetree) 9/42 Checking commit 8fe2e5f0c8b9 (target/arm: Convert vectorised 2-reg-misc Neon ops to decodetree) 10/42 Checking commit 2139ddc76378 (target/arm: Convert Neon 2-reg-misc crypto operations to decodetree) 11/42 Checking commit 60ac3ab2a6f4 (target/arm: Rename NeonGenOneOpFn to NeonGenOne64OpFn) 12/42 Checking commit 5a2495652793 (target/arm: Fix capitalization in NeonGenTwo{Single, Double}OPFn typedefs) 13/42 Checking commit 17ce51c555d4 (target/arm: Make gen_swap_half() take separate src and dest) ERROR: trailing statements should be on next line #52: FILE: target/arm/translate.c:4963: + case 1: gen_swap_half(tmp, tmp); break; total: 1 errors, 0 warnings, 43 lines checked Patch 13/42 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/42 Checking commit 236fd323469a (target/arm: Convert Neon 2-reg-misc VREV32 and VREV16 to decodetree) 15/42 Checking commit 91f41943f5d6 (target/arm: Convert remaining simple 2-reg-misc Neon ops) 16/42 Checking commit 50c8ce6ac19f (target/arm: Convert Neon VQABS, VQNEG to decodetree) 17/42 Checking commit 945dde2e8aed (target/arm: Convert simple fp Neon 2-reg-misc insns) 18/42 Checking commit 6169ea124c14 (target/arm: Convert Neon 2-reg-misc fp-compare-with-zero insns to decodetree) 19/42 Checking commit d2898391b335 (target/arm: Convert Neon 2-reg-misc VRINT insns to decodetree) 20/42 Checking commit 0f0482aa93e9 (target/arm: Convert Neon 2-reg-misc VCVT insns to decodetree) 21/42 Checking commit 41730a1d874a (target/arm: Convert Neon VSWP to decodetree) 22/42 Checking commit 0d32b4f2f2fb (target/arm: Convert Neon VTRN to decodetree) 23/42 Checking commit 9cdb63bdead8 (target/arm: Move some functions used only in translate-neon.inc.c to that file) WARNING: Block comments use a leading /* on a separate line #30: FILE: target/arm/translate-neon.inc.c:57: +/* Return the offset of a 2**SIZE piece of a NEON register, at index ELE, WARNING: Block comments use a leading /* on a separate line #39: FILE: target/arm/translate-neon.inc.c:66: + /* Calculate the offset assuming fully little-endian, total: 0 errors, 2 warnings, 226 lines checked Patch 23/42 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 24/42 Checking commit 4cbe0e31f751 (target/arm: Remove unnecessary gen_io_end() calls) 25/42 Checking commit 16c502063fd0 (target/arm: Remove dead code relating to SABA and UABA) 26/42 Checking commit ab757f48d78c (hw/watchdog/cmsdk-apb-watchdog: Add trace event for lock status) 27/42 Checking commit 6abd95f2d5e2 (hw/i2c/versatile_i2c: Add definitions for register addresses) 28/42 Checking commit c80e1d059694 (hw/i2c/versatile_i2c: Add SCL/SDA definitions) 29/42 Checking commit 0ff0e8bc2636 (hw/i2c: Add header for ARM SBCon two-wire serial bus interface) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #84: new file mode 100644 total: 0 errors, 1 warnings, 83 lines checked Patch 29/42 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 30/42 Checking commit 24b7022bd158 (hw/arm: Use TYPE_VERSATILE_I2C instead of hardcoded string) 31/42 Checking commit ff60516e9724 (hw/arm/mps2: Document CMSDK/FPGA APB subsystem sections) 32/42 Checking commit 6c17506148c0 (hw/arm/mps2: Rename CMSDK AHB peripheral region) 33/42 Checking commit e32341b99db3 (hw/arm/mps2: Add CMSDK APB watchdog device) 34/42 Checking commit 127d6ae6fbf3 (hw/arm/mps2: Add CMSDK AHB GPIO peripherals as unimplemented devices) 35/42 Checking commit 4acc2b7af787 (hw/arm/mps2: Map the FPGA I/O block) 36/42 Checking commit 9af1079f707b (hw/arm/mps2: Add SPI devices) 37/42 Checking commit 7f059c91c48a (hw/arm/mps2: Add I2C devices) 38/42 Checking commit 7d79ab3d56d0 (hw/arm/mps2: Add audio I2S interface as unimplemented device) 39/42 Checking commit f9f6407b52de (hw/arm/mps2-tz: Use the ARM SBCon two-wire serial bus interface) 40/42 Checking commit 4f01797a969f (target/arm: Check supported KVM features globally (not per vCPU)) 41/42 Checking commit c6682375a8f6 (tests/qtest/arm-cpu-features: Add feature setting tests) 42/42 Checking commit 6bd907641919 (arm/virt: Add memory hot remove support) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200623113904.28805-1-peter.maydell@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Tue, 23 Jun 2020 at 12:39, Peter Maydell <peter.maydell@linaro.org> wrote: > > The following changes since commit 61fee7f45955cd0bf9b79be9fa9c7ebabb5e6a85: > > Merge remote-tracking branch 'remotes/philmd-gitlab/tags/acceptance-testing-20200622' into staging (2020-06-22 20:50:10 +0100) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20200623 > > for you to fetch changes up to 539533b85fbd269f777bed931de8ccae1dd837e9: > > arm/virt: Add memory hot remove support (2020-06-23 11:39:48 +0100) > > ---------------------------------------------------------------- > target-arm queue: > * util/oslib-posix : qemu_init_exec_dir implementation for Mac > * target/arm: Last parts of neon decodetree conversion > * hw/arm/virt: Add 5.0 HW compat props > * hw/watchdog/cmsdk-apb-watchdog: Add trace event for lock status > * mps2: Add CMSDK APB watchdog, FPGAIO block, S2I devices and I2C devices > * mps2: Add some unimplemented-device stubs for audio and GPIO > * mps2-tz: Use the ARM SBCon two-wire serial bus interface > * target/arm: Check supported KVM features globally (not per vCPU) > * tests/qtest/arm-cpu-features: Add feature setting tests > * arm/virt: Add memory hot remove support Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1 for any user-visible changes. -- PMM