| Message ID | 20210210074527.867400-1-weiyongjun1@huawei.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [-next] crypto: keembay-ocs-aes - Fix error return code in kmb_ocs_aes_probe() | expand |
Hi Wei, Thanks for this fix as well :) On Wed, 2021-02-10 at 07:45 +0000, Wei Yongjun wrote: > Fix to return negative error code -ENOMEM from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 885743324513 ("crypto: keembay - Add support for Keem Bay OCS > AES/SM4") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/crypto/keembay/keembay-ocs-aes-core.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/crypto/keembay/keembay-ocs-aes-core.c > b/drivers/crypto/keembay/keembay-ocs-aes-core.c > index b6b25d994af3..2ef312866338 100644 > --- a/drivers/crypto/keembay/keembay-ocs-aes-core.c > +++ b/drivers/crypto/keembay/keembay-ocs-aes-core.c > @@ -1649,8 +1649,10 @@ static int kmb_ocs_aes_probe(struct > platform_device *pdev) > > /* Initialize crypto engine */ > aes_dev->engine = crypto_engine_alloc_init(dev, true); > - if (!aes_dev->engine) > + if (!aes_dev->engine) { > + rc = -ENOMEM; > goto list_del; > + } > > rc = crypto_engine_start(aes_dev->engine); > if (rc) { > Reviewed-by: Daniele Alessandrelli <daniele.alessandrelli@intel.com>
On Wed, Feb 10, 2021 at 07:45:27AM +0000, Wei Yongjun wrote: > Fix to return negative error code -ENOMEM from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 885743324513 ("crypto: keembay - Add support for Keem Bay OCS AES/SM4") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/crypto/keembay/keembay-ocs-aes-core.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
diff --git a/drivers/crypto/keembay/keembay-ocs-aes-core.c b/drivers/crypto/keembay/keembay-ocs-aes-core.c index b6b25d994af3..2ef312866338 100644 --- a/drivers/crypto/keembay/keembay-ocs-aes-core.c +++ b/drivers/crypto/keembay/keembay-ocs-aes-core.c @@ -1649,8 +1649,10 @@ static int kmb_ocs_aes_probe(struct platform_device *pdev) /* Initialize crypto engine */ aes_dev->engine = crypto_engine_alloc_init(dev, true); - if (!aes_dev->engine) + if (!aes_dev->engine) { + rc = -ENOMEM; goto list_del; + } rc = crypto_engine_start(aes_dev->engine); if (rc) {
Fix to return negative error code -ENOMEM from the error handling case instead of 0, as done elsewhere in this function. Fixes: 885743324513 ("crypto: keembay - Add support for Keem Bay OCS AES/SM4") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/crypto/keembay/keembay-ocs-aes-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)