diff mbox series

[v2,2/2] drm/panel: Add support for E Ink VB3300-KCA

Message ID 20210615103312.872-2-alistair@alistair23.me
State New
Headers show
Series [v2,1/2] dt-bindings: Add E Ink to vendor bindings | expand

Commit Message

Alistair June 15, 2021, 10:33 a.m. UTC
Add support for the 10.3" E Ink panel described at:
https://www.eink.com/product.html?type=productdetail&id=7

Signed-off-by: Alistair Francis <alistair@alistair23.me>
---
v2:
 - Fix build warning
 - Document new string

 .../bindings/display/panel/panel-simple.yaml  |  2 ++
 drivers/gpu/drm/panel/panel-simple.c          | 29 +++++++++++++++++++
 2 files changed, 31 insertions(+)

Comments

Rob Herring (Arm) June 24, 2021, 8:52 p.m. UTC | #1
On Tue, Jun 15, 2021 at 08:33:12PM +1000, Alistair Francis wrote:
> Add support for the 10.3" E Ink panel described at:

> https://www.eink.com/product.html?type=productdetail&id=7

> 

> Signed-off-by: Alistair Francis <alistair@alistair23.me>

> ---

> v2:

>  - Fix build warning

>  - Document new string

> 

>  .../bindings/display/panel/panel-simple.yaml  |  2 ++

>  drivers/gpu/drm/panel/panel-simple.c          | 29 +++++++++++++++++++

>  2 files changed, 31 insertions(+)

> 

> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml

> index b3797ba2698b..799e20222551 100644

> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml

> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml

> @@ -128,6 +128,8 @@ properties:

>          # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch

>        - edt,etm0700g0dh6

>        - edt,etm0700g0edh6

> +        # E Ink VB3300-KCA

> +      - eink,vb3300-kca


Combining this with patch 1 would be preferrable. Either way,

Acked-by: Rob Herring <robh@kernel.org>
Alistair Francis July 4, 2021, 10:29 a.m. UTC | #2
On Fri, Jun 25, 2021 at 6:52 AM Rob Herring <robh@kernel.org> wrote:
>

> On Tue, Jun 15, 2021 at 08:33:12PM +1000, Alistair Francis wrote:

> > Add support for the 10.3" E Ink panel described at:

> > https://www.eink.com/product.html?type=productdetail&id=7

> >

> > Signed-off-by: Alistair Francis <alistair@alistair23.me>

> > ---

> > v2:

> >  - Fix build warning

> >  - Document new string

> >

> >  .../bindings/display/panel/panel-simple.yaml  |  2 ++

> >  drivers/gpu/drm/panel/panel-simple.c          | 29 +++++++++++++++++++

> >  2 files changed, 31 insertions(+)

> >

> > diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml

> > index b3797ba2698b..799e20222551 100644

> > --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml

> > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml

> > @@ -128,6 +128,8 @@ properties:

> >          # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch

> >        - edt,etm0700g0dh6

> >        - edt,etm0700g0edh6

> > +        # E Ink VB3300-KCA

> > +      - eink,vb3300-kca

>

> Combining this with patch 1 would be preferrable. Either way,

>

> Acked-by: Rob Herring <robh@kernel.org>


This should be ready to merge.

Let me know if you want me to squash the patches and send a v3.

Alistair
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index b3797ba2698b..799e20222551 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -128,6 +128,8 @@  properties:
         # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
       - edt,etm0700g0dh6
       - edt,etm0700g0edh6
+        # E Ink VB3300-KCA
+      - eink,vb3300-kca
         # Evervision Electronics Co. Ltd. VGG804821 5.0" WVGA TFT LCD Panel
       - evervision,vgg804821
         # Foxlink Group 5" WVGA TFT LCD panel
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index be312b5c04dd..600e054ec521 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2004,6 +2004,32 @@  static const struct panel_desc edt_etm0700g0bdh6 = {
 	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
 };
 
+static const struct display_timing eink_vb3300_kca_timing = {
+	.pixelclock = { 40000000, 40000000, 40000000 },
+	.hactive = { 334, 334, 334 },
+	.hfront_porch = { 1, 1, 1 },
+	.hback_porch = { 1, 1, 1 },
+	.hsync_len = { 1, 1, 1 },
+	.vactive = { 1405, 1405, 1405 },
+	.vfront_porch = { 1, 1, 1 },
+	.vback_porch = { 1, 1, 1 },
+	.vsync_len = { 1, 1, 1 },
+	.flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW |
+		 DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE,
+};
+
+static const struct panel_desc eink_vb3300_kca = {
+	.timings = &eink_vb3300_kca_timing,
+	.num_timings = 1,
+	.bpc = 6,
+	.size = {
+		.width = 157,
+		.height = 209,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
+};
+
 static const struct display_timing evervision_vgg804821_timing = {
 	.pixelclock = { 27600000, 33300000, 50000000 },
 	.hactive = { 800, 800, 800 },
@@ -4302,6 +4328,9 @@  static const struct of_device_id platform_of_match[] = {
 	}, {
 		.compatible = "edt,etm0700g0dh6",
 		.data = &edt_etm0700g0dh6,
+	}, {
+		.compatible = "eink,vb3300-kca",
+		.data = &eink_vb3300_kca,
 	}, {
 		.compatible = "edt,etm0700g0bdh6",
 		.data = &edt_etm0700g0bdh6,