diff mbox series

[1/4] dt-bindings: i2c: st,stm32-i2c: don't mandate a reset line

Message ID 20220620105405.145959-2-alain.volmat@foss.st.com
State New
Headers show
Series i2c: stm32: addition of STM32MP13 support | expand

Commit Message

Alain Volmat June 20, 2022, 10:54 a.m. UTC
Update the dt-bindings of the i2c-stm32 drivers to avoid the
needs for a reset property in the device-tree.

Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
---
 Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml | 1 -
 1 file changed, 1 deletion(-)

Comments

Rob Herring (Arm) June 28, 2022, 1:41 p.m. UTC | #1
On Mon, Jun 20, 2022 at 12:54:02PM +0200, Alain Volmat wrote:
> Update the dt-bindings of the i2c-stm32 drivers to avoid the
> needs for a reset property in the device-tree.

That is clear from the diff, but why. Some chips don't have a reset? 
If so, this should be combined with patch 2 as part of changes needed 
for a new version.

> 
> Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
> ---
>  Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> index dccbb18b6dc0..8879144fbbfb 100644
> --- a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> @@ -94,7 +94,6 @@ required:
>    - compatible
>    - reg
>    - interrupts
> -  - resets
>    - clocks
>  
>  unevaluatedProperties: false
> -- 
> 2.25.1
> 
>
Wolfram Sang June 29, 2022, 7:44 p.m. UTC | #2
On Tue, Jun 28, 2022 at 07:41:15AM -0600, Rob Herring wrote:
> On Mon, Jun 20, 2022 at 12:54:02PM +0200, Alain Volmat wrote:
> > Update the dt-bindings of the i2c-stm32 drivers to avoid the
> > needs for a reset property in the device-tree.
> 
> That is clear from the diff, but why. Some chips don't have a reset? 
> If so, this should be combined with patch 2 as part of changes needed 
> for a new version.

What do you mean? Patches 1+2 should be squashed together? I can do this
when applying. Or do you mean something else?

> 
> > 
> > Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
> > ---
> >  Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> > index dccbb18b6dc0..8879144fbbfb 100644
> > --- a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> > @@ -94,7 +94,6 @@ required:
> >    - compatible
> >    - reg
> >    - interrupts
> > -  - resets
> >    - clocks
> >  
> >  unevaluatedProperties: false
> > -- 
> > 2.25.1
> > 
> >
Rob Herring (Arm) July 6, 2022, 10:46 p.m. UTC | #3
On Wed, Jun 29, 2022 at 09:44:37PM +0200, Wolfram Sang wrote:
> On Tue, Jun 28, 2022 at 07:41:15AM -0600, Rob Herring wrote:
> > On Mon, Jun 20, 2022 at 12:54:02PM +0200, Alain Volmat wrote:
> > > Update the dt-bindings of the i2c-stm32 drivers to avoid the
> > > needs for a reset property in the device-tree.
> > 
> > That is clear from the diff, but why. Some chips don't have a reset? 
> > If so, this should be combined with patch 2 as part of changes needed 
> > for a new version.
> 
> What do you mean? Patches 1+2 should be squashed together? I can do this
> when applying. Or do you mean something else?

Sorry, I meant combined with patch 3. If the new chip added in patch 3 
doesn't have a reset, then 1 and 3 should be 1 patch. IOW, all the 
changes needed for a new chip in 1 patch.

Rob
Alain Volmat July 7, 2022, 6:38 a.m. UTC | #4
Hi Rob,

On Tue, Jun 28, 2022 at 07:41:15AM -0600, Rob Herring wrote:
> On Mon, Jun 20, 2022 at 12:54:02PM +0200, Alain Volmat wrote:
> > Update the dt-bindings of the i2c-stm32 drivers to avoid the
> > needs for a reset property in the device-tree.
> 
> That is clear from the diff, but why. Some chips don't have a reset? 
> If so, this should be combined with patch 2 as part of changes needed 
> for a new version.

Alexandre has just pushed a pull-request enabling support for the
clock/reset [1] so I will shortly push a v2 of the serie dropping the
first 2 patches.

Thanks
Alain

[1] https://lore.kernel.org/all/a250f32b-f67c-2922-0748-e39dc791e95c@foss.st.com/

> 
> > 
> > Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
> > ---
> >  Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> > index dccbb18b6dc0..8879144fbbfb 100644
> > --- a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
> > @@ -94,7 +94,6 @@ required:
> >    - compatible
> >    - reg
> >    - interrupts
> > -  - resets
> >    - clocks
> >  
> >  unevaluatedProperties: false
> > -- 
> > 2.25.1
> > 
> >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
index dccbb18b6dc0..8879144fbbfb 100644
--- a/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
+++ b/Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml
@@ -94,7 +94,6 @@  required:
   - compatible
   - reg
   - interrupts
-  - resets
   - clocks
 
 unevaluatedProperties: false