| Message ID | fb894ecec68e03fb7fc9353027c8b1a2610833d7.1659735153.git.christophe.jaillet@wanadoo.fr |
|---|---|
| State | Accepted |
| Commit | 7964e817d2311b37b86d6fbf588cd9fbe747b108 |
| Headers | show |
| Series | spi: microchip-core: Simplify some error message | expand |
On 05/08/2022 22:33, Christophe JAILLET wrote: > dev_err_probe() already prints the error code in a human readable way, so > there is no need to duplicate it as a numerical value at the end of the > message. > > Moreover, in the case of devm_clk_get() it would only display '0' because > 'ret' is know to be 0 at this point. > > Fixes: cdeaf3a99a02 ("spi: microchip-core: switch to use dev_err_probe()") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> bah, should have noticed that when I reviewed the switch over... Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Thanks! > --- > drivers/spi/spi-microchip-core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/spi/spi-microchip-core.c b/drivers/spi/spi-microchip-core.c > index ce4385330b19..d352844c798c 100644 > --- a/drivers/spi/spi-microchip-core.c > +++ b/drivers/spi/spi-microchip-core.c > @@ -548,12 +548,12 @@ static int mchp_corespi_probe(struct platform_device *pdev) > IRQF_SHARED, dev_name(&pdev->dev), master); > if (ret) > return dev_err_probe(&pdev->dev, ret, > - "could not request irq: %d\n", ret); > + "could not request irq\n"); > > spi->clk = devm_clk_get(&pdev->dev, NULL); > if (IS_ERR(spi->clk)) > return dev_err_probe(&pdev->dev, PTR_ERR(spi->clk), > - "could not get clk: %d\n", ret); > + "could not get clk\n"); > > ret = clk_prepare_enable(spi->clk); > if (ret)
On Fri, 5 Aug 2022 23:33:17 +0200, Christophe JAILLET wrote: > dev_err_probe() already prints the error code in a human readable way, so > there is no need to duplicate it as a numerical value at the end of the > message. > > Moreover, in the case of devm_clk_get() it would only display '0' because > 'ret' is know to be 0 at this point. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: microchip-core: Simplify some error message commit: 7964e817d2311b37b86d6fbf588cd9fbe747b108 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-microchip-core.c b/drivers/spi/spi-microchip-core.c index ce4385330b19..d352844c798c 100644 --- a/drivers/spi/spi-microchip-core.c +++ b/drivers/spi/spi-microchip-core.c @@ -548,12 +548,12 @@ static int mchp_corespi_probe(struct platform_device *pdev) IRQF_SHARED, dev_name(&pdev->dev), master); if (ret) return dev_err_probe(&pdev->dev, ret, - "could not request irq: %d\n", ret); + "could not request irq\n"); spi->clk = devm_clk_get(&pdev->dev, NULL); if (IS_ERR(spi->clk)) return dev_err_probe(&pdev->dev, PTR_ERR(spi->clk), - "could not get clk: %d\n", ret); + "could not get clk\n"); ret = clk_prepare_enable(spi->clk); if (ret)
dev_err_probe() already prints the error code in a human readable way, so there is no need to duplicate it as a numerical value at the end of the message. Moreover, in the case of devm_clk_get() it would only display '0' because 'ret' is know to be 0 at this point. Fixes: cdeaf3a99a02 ("spi: microchip-core: switch to use dev_err_probe()") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/spi/spi-microchip-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)