Message ID | 20221225163442.2205660-5-perry.yuan@amd.com |
---|---|
State | Superseded |
Headers | show |
Series | Implement AMD Pstate EPP Driver | expand |
On 26-12-22, 00:34, Perry Yuan wrote: > In the amd_pstate_adjust_perf(), there is one cpufreq_cpu_get() call to > increase increments the kobject reference count of policy and make it as > busy. Therefore, a corresponding call to cpufreq_cpu_put() is needed to > decrement the kobject reference count back, it will resolve the kernel > hang issue when unregistering the amd-pstate driver and register the > `amd_pstate_epp` driver instance. > > Acked-by: Huang Rui <ray.huang@amd.com> > Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> > Signed-off-by: Perry Yuan <perry.yuan@amd.com> > Cc: stable@vger.kernel.org > --- > drivers/cpufreq/amd-pstate.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c > index 204e39006dda..c17bd845f5fc 100644 > --- a/drivers/cpufreq/amd-pstate.c > +++ b/drivers/cpufreq/amd-pstate.c > @@ -307,6 +307,7 @@ static void amd_pstate_adjust_perf(unsigned int cpu, > max_perf = min_perf; > > amd_pstate_update(cpudata, min_perf, des_perf, max_perf, true); > + cpufreq_cpu_put(policy); > } > > static int amd_get_min_freq(struct amd_cpudata *cpudata) This should have been sent separately and not in this series. It is a bug fix, which could have been merged in the 6.1 itself and now is candidate for 6.2-rc1, while the rest of the series needs to wait for 6.3.
[AMD Official Use Only - General] Hi Viresh. > -----Original Message----- > From: Viresh Kumar <viresh.kumar@linaro.org> > Sent: Tuesday, December 27, 2022 10:54 AM > To: Yuan, Perry <Perry.Yuan@amd.com> > Cc: rafael.j.wysocki@intel.com; Limonciello, Mario > <Mario.Limonciello@amd.com>; Huang, Ray <Ray.Huang@amd.com>; > Sharma, Deepak <Deepak.Sharma@amd.com>; Fontenot, Nathan > <Nathan.Fontenot@amd.com>; Deucher, Alexander > <Alexander.Deucher@amd.com>; Huang, Shimmer > <Shimmer.Huang@amd.com>; Du, Xiaojian <Xiaojian.Du@amd.com>; Meng, > Li (Jassmine) <Li.Meng@amd.com>; Karny, Wyes <Wyes.Karny@amd.com>; > linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v9 04/13] cpufreq: amd-pstate: fix kernel hang issue > while amd-pstate unregistering > > On 26-12-22, 00:34, Perry Yuan wrote: > > In the amd_pstate_adjust_perf(), there is one cpufreq_cpu_get() call > > to increase increments the kobject reference count of policy and make > > it as busy. Therefore, a corresponding call to cpufreq_cpu_put() is > > needed to decrement the kobject reference count back, it will resolve > > the kernel hang issue when unregistering the amd-pstate driver and > > register the `amd_pstate_epp` driver instance. > > > > Acked-by: Huang Rui <ray.huang@amd.com> > > Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> > > Signed-off-by: Perry Yuan <perry.yuan@amd.com> > > Cc: stable@vger.kernel.org > > --- > > drivers/cpufreq/amd-pstate.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/cpufreq/amd-pstate.c > > b/drivers/cpufreq/amd-pstate.c index 204e39006dda..c17bd845f5fc 100644 > > --- a/drivers/cpufreq/amd-pstate.c > > +++ b/drivers/cpufreq/amd-pstate.c > > @@ -307,6 +307,7 @@ static void amd_pstate_adjust_perf(unsigned int > cpu, > > max_perf = min_perf; > > > > amd_pstate_update(cpudata, min_perf, des_perf, max_perf, true); > > + cpufreq_cpu_put(policy); > > } > > > > static int amd_get_min_freq(struct amd_cpudata *cpudata) > > This should have been sent separately and not in this series. It is a bug fix, > which could have been merged in the 6.1 itself and now is candidate for 6.2- > rc1, while the rest of the series needs to wait for 6.3. > > -- > Viresh Thanks for your feedback, will extract the patch and send it out separately. Perry.
diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 204e39006dda..c17bd845f5fc 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -307,6 +307,7 @@ static void amd_pstate_adjust_perf(unsigned int cpu, max_perf = min_perf; amd_pstate_update(cpudata, min_perf, des_perf, max_perf, true); + cpufreq_cpu_put(policy); } static int amd_get_min_freq(struct amd_cpudata *cpudata)