| Message ID | 20230215192530.299263-9-alex.bennee@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | testing/next: docker, avocado, unit, | expand |
On 15/2/23 20:25, Alex Bennée wrote: > It is buggy and keeps failing. > > Suggested-by: Peter Maydell <peter.maydell@linaro.org> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > tests/avocado/replay_kernel.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/avocado/replay_kernel.py b/tests/avocado/replay_kernel.py > index 00a26e4a0c..f13456e1ec 100644 > --- a/tests/avocado/replay_kernel.py > +++ b/tests/avocado/replay_kernel.py > @@ -349,6 +349,7 @@ def test_or1k_sim(self): > file_path = self.fetch_asset(tar_url, asset_hash=tar_hash) > self.do_test_advcal_2018(file_path, 'vmlinux') > > + @skip("nios2 emulation is buggy under record/replay") It will be hard to notice the flakyness got improved. What about: @skipUnless(os.getenv('AVOCADO_RUN_FLAKY_TESTS'), 'Flaky test') > def test_nios2_10m50(self): > """ > :avocado: tags=arch:nios2
On 2/15/23 09:25, Alex Bennée wrote: > It is buggy and keeps failing. > > Suggested-by: Peter Maydell<peter.maydell@linaro.org> > Signed-off-by: Alex Bennée<alex.bennee@linaro.org> > --- > tests/avocado/replay_kernel.py | 1 + > 1 file changed, 1 insertion(+) Acked-by: Richard Henderson <richard.henderson@linaro.org> r~
On 2/15/23 10:47, Philippe Mathieu-Daudé wrote: >> + @skip("nios2 emulation is buggy under record/replay") > > It will be hard to notice the flakyness got improved. What about: > > @skipUnless(os.getenv('AVOCADO_RUN_FLAKY_TESTS'), 'Flaky test') > >> def test_nios2_10m50(self): >> """ >> :avocado: tags=arch:nios2 It'll be hard for there to be any improvement without an active maintainer. Last patch from any of the listed maintainers was: commit ebedf0f9cd46b617df331eecc857c379d574ac62 Author: Marek Vasut <marex@denx.de> Date: Fri Mar 17 22:06:27 2017 +0100 nios2: iic: Convert CPU prop to qom link It's probably time to demote "Maintained" to "Orphan". r~
On 15/2/23 21:59, Richard Henderson wrote: > On 2/15/23 10:47, Philippe Mathieu-Daudé wrote: >>> + @skip("nios2 emulation is buggy under record/replay") >> >> It will be hard to notice the flakyness got improved. What about: >> >> @skipUnless(os.getenv('AVOCADO_RUN_FLAKY_TESTS'), 'Flaky test') >> >>> def test_nios2_10m50(self): >>> """ >>> :avocado: tags=arch:nios2 > > It'll be hard for there to be any improvement without an active maintainer. In that case no point in keeping the test... Anyhow, Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> > Last patch from any of the listed maintainers was: > > commit ebedf0f9cd46b617df331eecc857c379d574ac62 > Author: Marek Vasut <marex@denx.de> > Date: Fri Mar 17 22:06:27 2017 +0100 > > nios2: iic: Convert CPU prop to qom link > > It's probably time to demote "Maintained" to "Orphan". > > > r~
diff --git a/tests/avocado/replay_kernel.py b/tests/avocado/replay_kernel.py index 00a26e4a0c..f13456e1ec 100644 --- a/tests/avocado/replay_kernel.py +++ b/tests/avocado/replay_kernel.py @@ -349,6 +349,7 @@ def test_or1k_sim(self): file_path = self.fetch_asset(tar_url, asset_hash=tar_hash) self.do_test_advcal_2018(file_path, 'vmlinux') + @skip("nios2 emulation is buggy under record/replay") def test_nios2_10m50(self): """ :avocado: tags=arch:nios2
It is buggy and keeps failing. Suggested-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- tests/avocado/replay_kernel.py | 1 + 1 file changed, 1 insertion(+)