| Message ID | 20230325122444.249507-1-vkoul@kernel.org |
|---|---|
| Headers | show |
| Series | Introduce the SC8180x devices | expand |
On Sat, 25 Mar 2023 17:54:37 +0530, Vinod Koul wrote: > SC8180x comes with interconnects having and missing IO address space, and > variable number of clocks, so split it from common file for easier > maintenance and to fix warnings like: > > sc8180x-lenovo-flex-5g.dtb: interconnect-0: 'reg' is a required property > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > --- > .../bindings/interconnect/qcom,rpmh.yaml | 11 --- > .../interconnect/qcom,sc8180x-rpmh.yaml | 76 +++++++++++++++++++ > 2 files changed, 76 insertions(+), 11 deletions(-) > create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sc8180x-rpmh.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/interconnect/qcom,sc8180x-rpmh.yaml: properties:compatible:enum: ['qcom,sc8180x-aggre1-noc', 'qcom,sc8180x-aggre1-noc', 'qcom,sc8180x-aggre2-noc', 'qcom,sc8180x-camnoc-virt', 'qcom,sc8180x-compute-noc', 'qcom,sc8180x-config-noc', 'qcom,sc8180x-dc-noc', 'qcom,sc8180x-gem-noc', 'qcom,sc8180x-mc-virt', 'qcom,sc8180x-mmss-noc', 'qcom,sc8180x-qup-virt', 'qcom,sc8180x-system-noc'] has non-unique elements from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/interconnect/qcom,sc8180x-rpmh.example.dtb: interconnect@16e0000: reg: [[0, 23986176], [0, 53376]] is too long From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/interconnect/qcom,sc8180x-rpmh.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/interconnect/qcom,sc8180x-rpmh.example.dtb: interconnect@16e0000: Unevaluated properties are not allowed ('reg' was unexpected) From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/interconnect/qcom,sc8180x-rpmh.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230325122444.249507-6-vkoul@kernel.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 25-03-23, 13:34, Konrad Dybcio wrote: > > > On 25.03.2023 13:24, Vinod Koul wrote: > > From: Bjorn Andersson <bjorn.andersson@linaro.org> > > > > Introduce a base dtsi for the Qualcomm SC8180x platform, with CPUs, > > global clock controller, SMMU, rpmh clocks, rpmh power-domains, CPUfreq, > > QUP blocks, UFS, USB, ADSP, CDSP and MPSS and WiFi. > > > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > > --- > > arch/arm64/boot/dts/qcom/sc8180x.dtsi | 3950 +++++++++++++++++++++++++ > > 1 file changed, 3950 insertions(+) > > create mode 100644 arch/arm64/boot/dts/qcom/sc8180x.dtsi > > > > diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi > > new file mode 100644 > > index 000000000000..4d4ee6bc91e5 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi > > @@ -0,0 +1,3950 @@ > > +// SPDX-License-Identifier: BSD-3-Clause > > +/* > > + * Copyright (c) 2017-2019, The Linux Foundation. All rights reserved. > > + * Copyright (c) 2020-2023, Linaro Limited > > + */ > > + > > +#include <dt-bindings/clock/qcom,dispcc-sm8250.h> > > +#include <dt-bindings/clock/qcom,gcc-sc8180x.h> > > +#include <dt-bindings/clock/qcom,gpucc-sm8150.h> > > +#include <dt-bindings/clock/qcom,rpmh.h> > > +#include <dt-bindings/interconnect/qcom,osm-l3.h> > > +#include <dt-bindings/interconnect/qcom,sc8180x.h> > > +#include <dt-bindings/interrupt-controller/arm-gic.h> > > +#include <dt-bindings/power/qcom-rpmpd.h> > > +#include <dt-bindings/soc/qcom,rpmh-rsc.h> > > +#include <dt-bindings/thermal/thermal.h> > > + > > +/ { > > + interrupt-parent = <&intc>; > > + > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + clocks { > > + xo_board_clk: xo-board { > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-frequency = <38400000>; > > + }; > > + > > + sleep_clk: sleep-clk { > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-frequency = <32764>; > > + clock-output-names = "sleep_clk"; > > + }; > > + }; > > + > > + cpus { > > + #address-cells = <2>; > > + #size-cells = <0>; > > + > > + CPU0: cpu@0 { > > + device_type = "cpu"; > > + compatible = "qcom,kryo485"; > > + reg = <0x0 0x0>; > Please add clocks = <&cpufreq_hw n>; > > > + enable-method = "psci"; > > + capacity-dmips-mhz = <602>; > > + next-level-cache = <&L2_0>; > > + qcom,freq-domain = <&cpufreq_hw 0>; You mean this or something else? > > + operating-points-v2 = <&cpu0_opp_table>; > > + interconnects = <&gem_noc MASTER_AMPSS_M0 3 &mc_virt SLAVE_EBI_CH0 3>, > > + <&osm_l3 MASTER_OSM_L3_APPS &osm_l3 SLAVE_OSM_L3>; > > + power-domains = <&CPU_PD0>; > > + power-domain-names = "psci"; > > + #cooling-cells = <2>; > Add a newline before subnodes, please. Sure > > > + L2_0: l2-cache { > > + compatible = "cache"; > > + next-level-cache = <&L3_0>; > > + L3_0: l3-cache { > > + compatible = "cache"; > > + }; > > + }; > > + }; > > + > [...] > > > + > > + cpu0_opp_table: opp-table-cpu0 { > > + compatible = "operating-points-v2"; > > + opp-shared; > > + > > + opp-300000000 { > > + opp-hz = /bits/ 64 <300000000>; > > + opp-peak-kBps = <800000 9600000>; > Maybe adding bwmon from the get-go would be better than statically > scaling DDR freq? Maybe :-) but we would like to land the dts now rather than wait more :) > > [...] > > > + camnoc_virt: interconnect-0{ > Missing space before { Will fix > > + compatible = "qcom,sc8180x-camnoc-virt"; > > + #interconnect-cells = <2>; > > + qcom,bcm-voters = <&apps_bcm_voter>; > > + }; > > + > > + mc_virt: interconnect-mc-virt { > Please be consistent with your naming. Are you referring to adding -0 for this? > > > + compatible = "qcom,sc8180x-mc-virt"; > > + #interconnect-cells = <2>; > > + qcom,bcm-voters = <&apps_bcm_voter>; > > + }; > > + > > + qup_virt: interconnect-qup-virt { > > + compatible = "qcom,sc8180x-qup-virt"; > > + #interconnect-cells = <2>; > > + qcom,bcm-voters = <&apps_bcm_voter>; > > + }; > > + > [...] > > > + reserved-memory { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + ranges; > > + > > + hyp_mem: hyp-region@85700000 { > the -region seems a bit unnecessary in all of these nodes This is reserved for hyp, I think we should add it here so that we dont touch this piece..? > > > + reg = <0x0 0x85700000 0x0 0x600000>; > > + no-map; > > + }; > > + > [...] > > > + > > + soc: soc@0 { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + ranges = <0 0 0 0 0x10 0>; > > + dma-ranges = <0 0 0 0 0x10 0>; > > + compatible = "simple-bus"; > compat > addr-cells > size-cella > ranges > dma-ranges > > please Sure > > > + > > + gcc: clock-controller@100000 { > > + compatible = "qcom,gcc-sc8180x"; > > + reg = <0x0 0x00100000 0x0 0x1f0000>; > > + #clock-cells = <1>; > > + #reset-cells = <1>; > > + #power-domain-cells = <1>; > > + clock-names = "bi_tcxo", > > + "bi_tcxo_ao", > > + "sleep_clk"; > > + clocks = <&rpmhcc RPMH_CXO_CLK>, > > + <&rpmhcc RPMH_CXO_CLK_A>, > > + <&sleep_clk>; > property before property-names ok > > > > + }; > > + > > + qupv3_id_0: geniqup@8c0000 { > > + compatible = "qcom,geni-se-qup"; > > + reg = <0 0x008c0000 0 0x6000>; > > + clock-names = "m-ahb", "s-ahb"; > > + clocks = <&gcc GCC_QUPV3_WRAP_0_M_AHB_CLK>, > > + <&gcc GCC_QUPV3_WRAP_0_S_AHB_CLK>; > > + #address-cells = <2>; > > + #size-cells = <2>; > > + ranges; > > + iommus = <&apps_smmu 0x4c3 0>; > > + status = "disabled"; > > + > > + i2c0: i2c@880000 { > > + compatible = "qcom,geni-i2c"; > > + reg = <0 0x00880000 0 0x4000>; > > + clock-names = "se"; > > + clocks = <&gcc GCC_QUPV3_WRAP0_S0_CLK>; > property before property-names > > Please split QUPs into a separate patch, this one is way > too big. Will do > > [...] > > > + config_noc: interconnect@1500000 { > Interconnect could also realistically go to a separate patch. Yeah already list is complaining, let me see how to split it up... > > > + compatible = "qcom,sc8180x-config-noc"; > > + reg = <0 0x01500000 0 0x7400>; > > + #interconnect-cells = <2>; > > + qcom,bcm-voters = <&apps_bcm_voter>; > > + }; > > + > > + system_noc: interconnect@1620000 { > > + compatible = "qcom,sc8180x-system-noc"; > > + reg = <0 0x01620000 0 0x19400>; > > + #interconnect-cells = <2>; > > + qcom,bcm-voters = <&apps_bcm_voter>; > > + }; > > + > > + aggre1_noc: interconnect@16e0000 { > > + compatible = "qcom,sc8180x-aggre1-noc"; > > + reg = <0 0x016e0000 0 0xd080>; > > + #interconnect-cells = <2>; > > + qcom,bcm-voters = <&apps_bcm_voter>; > > + }; > > + > > + aggre2_noc: interconnect@1700000 { > > + compatible = "qcom,sc8180x-aggre2-noc"; > > + reg = <0 0x01700000 0 0x20000>; > > + #interconnect-cells = <2>; > > + qcom,bcm-voters = <&apps_bcm_voter>; > > + }; > > + > > + compute_noc: interconnect@1720000 { > > + compatible = "qcom,sc8180x-compute-noc"; > > + reg = <0 0x01720000 0 0x7000>; > > + #interconnect-cells = <2>; > > + qcom,bcm-voters = <&apps_bcm_voter>; > > + }; > > + > > + mmss_noc: interconnect@1740000 { > > + compatible = "qcom,sc8180x-mmss-noc"; > > + reg = <0 0x01740000 0 0x1c100>; > > + #interconnect-cells = <2>; > > + qcom,bcm-voters = <&apps_bcm_voter>; > > + }; > > + > [...] > > > + pcie0: pci@1c00000 { > And PCIe > > > + compatible = "qcom,pcie-sc8180x"; > > + reg = <0 0x01c00000 0 0x3000>, > > + <0 0x60000000 0 0xf1d>, > > + <0 0x60000f20 0 0xa8>, > > + <0 0x60001000 0 0x1000>, > > + <0 0x60100000 0 0x100000>; > > + reg-names = "parf", "dbi", "elbi", "atu", "config"; > One per line, please ok > > > [...] > > > + > > + ufs_mem_hc: ufshc@1d84000 { > > + compatible = "qcom,sc8180x-ufshc", "qcom,ufshc", > > + "jedec,ufs-2.0"; > > + reg = <0 0x01d84000 0 0x2500>; > > + interrupts = <GIC_SPI 265 IRQ_TYPE_LEVEL_HIGH>; > > + phys = <&ufs_mem_phy_lanes>; > > + phy-names = "ufsphy"; > > + lanes-per-direction = <2>; > > + #reset-cells = <1>; > > + resets = <&gcc GCC_UFS_PHY_BCR>; > > + reset-names = "rst"; > > + > > + iommus = <&apps_smmu 0x300 0>; > > + > > + clock-names = > No need for this weird newline split. > > Also, property before property-names. > > [...] > > > > + > > + gpu: gpu@2c00000 { > GPUSS and MDSS related nodes should also go to their separate, > respective patches. ok > > [...] > > + > > + remoteproc_mpss: remoteproc@4080000 { > And remote procs as well > > > + compatible = "qcom,sc8180x-mpss-pas"; > > + reg = <0x0 0x04080000 0x0 0x4040>; > > + > [...] > > > + thermal-zones { > And thermal-zones as well. > > > I'll go more in-depth after you split it up, this is pretty hard > to review as-is. > > Konrad > > + cpu0-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens0 1>; > > + > > + trips { > > + cpu-crit { > > + temperature = <110000>; > > + hysteresis = <1000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > + > > + cpu1-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens0 2>; > > + > > + trips { > > + cpu-crit { > > + temperature = <110000>; > > + hysteresis = <1000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > + > > + cpu2-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens0 3>; > > + > > + trips { > > + cpu-crit { > > + temperature = <110000>; > > + hysteresis = <1000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > + > > + cpu3-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens0 4>; > > + > > + trips { > > + cpu-crit { > > + temperature = <110000>; > > + hysteresis = <1000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > + > > + cpu4-top-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens0 7>; > > + > > + trips { > > + cpu-crit { > > + temperature = <110000>; > > + hysteresis = <1000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > + > > + cpu5-top-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens0 8>; > > + > > + trips { > > + cpu-crit { > > + temperature = <110000>; > > + hysteresis = <1000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > + > > + cpu6-top-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens0 9>; > > + > > + trips { > > + cpu-crit { > > + temperature = <110000>; > > + hysteresis = <1000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > + > > + cpu7-top-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens0 10>; > > + > > + trips { > > + cpu-crit { > > + temperature = <110000>; > > + hysteresis = <1000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > + > > + cpu4-bottom-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens0 11>; > > + > > + trips { > > + cpu-crit { > > + temperature = <110000>; > > + hysteresis = <1000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > + > > + cpu5-bottom-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens0 12>; > > + > > + trips { > > + cpu-crit { > > + temperature = <110000>; > > + hysteresis = <1000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > + > > + cpu6-bottom-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens0 13>; > > + > > + trips { > > + cpu-crit { > > + temperature = <110000>; > > + hysteresis = <1000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > + > > + cpu7-bottom-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens0 14>; > > + > > + trips { > > + cpu-crit { > > + temperature = <110000>; > > + hysteresis = <1000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > + > > + aoss0-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens0 0>; > > + > > + trips { > > + trip-point0 { > > + temperature = <90000>; > > + hysteresis = <2000>; > > + type = "hot"; > > + }; > > + }; > > + }; > > + > > + cluster0-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens0 5>; > > + > > + trips { > > + cluster-crit { > > + temperature = <110000>; > > + hysteresis = <2000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > + > > + cluster1-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens0 6>; > > + > > + trips { > > + cluster-crit { > > + temperature = <110000>; > > + hysteresis = <2000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > + > > + gpu-thermal-top { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens0 15>; > > + > > + trips { > > + trip-point0 { > > + temperature = <90000>; > > + hysteresis = <2000>; > > + type = "hot"; > > + }; > > + }; > > + }; > > + > > + aoss1-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens1 0>; > > + > > + trips { > > + trip-point0 { > > + temperature = <90000>; > > + hysteresis = <2000>; > > + type = "hot"; > > + }; > > + }; > > + }; > > + > > + wlan-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens1 1>; > > + > > + trips { > > + trip-point0 { > > + temperature = <90000>; > > + hysteresis = <2000>; > > + type = "hot"; > > + }; > > + }; > > + }; > > + > > + video-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens1 2>; > > + > > + trips { > > + trip-point0 { > > + temperature = <90000>; > > + hysteresis = <2000>; > > + type = "hot"; > > + }; > > + }; > > + }; > > + > > + mem-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens1 3>; > > + > > + trips { > > + trip-point0 { > > + temperature = <90000>; > > + hysteresis = <2000>; > > + type = "hot"; > > + }; > > + }; > > + }; > > + > > + q6-hvx-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens1 4>; > > + > > + trips { > > + trip-point0 { > > + temperature = <90000>; > > + hysteresis = <2000>; > > + type = "hot"; > > + }; > > + }; > > + }; > > + > > + camera-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens1 5>; > > + > > + trips { > > + trip-point0 { > > + temperature = <90000>; > > + hysteresis = <2000>; > > + type = "hot"; > > + }; > > + }; > > + }; > > + > > + compute-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens1 6>; > > + > > + trips { > > + trip-point0 { > > + temperature = <90000>; > > + hysteresis = <2000>; > > + type = "hot"; > > + }; > > + }; > > + }; > > + > > + mdm-dsp-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens1 7>; > > + > > + trips { > > + trip-point0 { > > + temperature = <90000>; > > + hysteresis = <2000>; > > + type = "hot"; > > + }; > > + }; > > + }; > > + > > + npu-thermal { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens1 8>; > > + > > + trips { > > + trip-point0 { > > + temperature = <90000>; > > + hysteresis = <2000>; > > + type = "hot"; > > + }; > > + }; > > + }; > > + > > + gpu-thermal-bottom { > > + polling-delay-passive = <250>; > > + polling-delay = <1000>; > > + > > + thermal-sensors = <&tsens1 11>; > > + > > + trips { > > + trip-point0 { > > + temperature = <90000>; > > + hysteresis = <2000>; > > + type = "hot"; > > + }; > > + }; > > + }; > > + }; > > + > > + timer { > > + compatible = "arm,armv8-timer"; > > + interrupts = <GIC_PPI 1 IRQ_TYPE_LEVEL_LOW>, > > + <GIC_PPI 2 IRQ_TYPE_LEVEL_LOW>, > > + <GIC_PPI 3 IRQ_TYPE_LEVEL_LOW>, > > + <GIC_PPI 0 IRQ_TYPE_LEVEL_LOW>; > > + }; > > +};
On 25/03/2023 13:24, Vinod Koul wrote: > This introduces Qualcomm SC8180x SoC which features in Lenovo Flex 5G > laptop. This also adds support for Primus platform as well as Lenovo Flex 5G > laptop. > > I would be great if submaintainers can ack the binding patch so that > everything can go thru qcom tree I think Bjorn recently was rejecting taking bindings patches, so what changed? Best regards, Krzysztof
On 27.03.2023 07:38, Vinod Koul wrote: > On 25-03-23, 13:34, Konrad Dybcio wrote: >> >> >> On 25.03.2023 13:24, Vinod Koul wrote: >>> From: Bjorn Andersson <bjorn.andersson@linaro.org> >>> >>> Introduce a base dtsi for the Qualcomm SC8180x platform, with CPUs, >>> global clock controller, SMMU, rpmh clocks, rpmh power-domains, CPUfreq, >>> QUP blocks, UFS, USB, ADSP, CDSP and MPSS and WiFi. >>> >>> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> >>> Signed-off-by: Vinod Koul <vkoul@kernel.org> >>> --- >>> arch/arm64/boot/dts/qcom/sc8180x.dtsi | 3950 +++++++++++++++++++++++++ >>> 1 file changed, 3950 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/qcom/sc8180x.dtsi >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi >>> new file mode 100644 >>> index 000000000000..4d4ee6bc91e5 >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi >>> @@ -0,0 +1,3950 @@ >>> +// SPDX-License-Identifier: BSD-3-Clause >>> +/* >>> + * Copyright (c) 2017-2019, The Linux Foundation. All rights reserved. >>> + * Copyright (c) 2020-2023, Linaro Limited >>> + */ >>> + >>> +#include <dt-bindings/clock/qcom,dispcc-sm8250.h> >>> +#include <dt-bindings/clock/qcom,gcc-sc8180x.h> >>> +#include <dt-bindings/clock/qcom,gpucc-sm8150.h> >>> +#include <dt-bindings/clock/qcom,rpmh.h> >>> +#include <dt-bindings/interconnect/qcom,osm-l3.h> >>> +#include <dt-bindings/interconnect/qcom,sc8180x.h> >>> +#include <dt-bindings/interrupt-controller/arm-gic.h> >>> +#include <dt-bindings/power/qcom-rpmpd.h> >>> +#include <dt-bindings/soc/qcom,rpmh-rsc.h> >>> +#include <dt-bindings/thermal/thermal.h> >>> + >>> +/ { >>> + interrupt-parent = <&intc>; >>> + >>> + #address-cells = <2>; >>> + #size-cells = <2>; >>> + >>> + clocks { >>> + xo_board_clk: xo-board { >>> + compatible = "fixed-clock"; >>> + #clock-cells = <0>; >>> + clock-frequency = <38400000>; >>> + }; >>> + >>> + sleep_clk: sleep-clk { >>> + compatible = "fixed-clock"; >>> + #clock-cells = <0>; >>> + clock-frequency = <32764>; >>> + clock-output-names = "sleep_clk"; >>> + }; >>> + }; >>> + >>> + cpus { >>> + #address-cells = <2>; >>> + #size-cells = <0>; >>> + >>> + CPU0: cpu@0 { >>> + device_type = "cpu"; >>> + compatible = "qcom,kryo485"; >>> + reg = <0x0 0x0>; >> Please add clocks = <&cpufreq_hw n>; >> >>> + enable-method = "psci"; >>> + capacity-dmips-mhz = <602>; >>> + next-level-cache = <&L2_0>; >>> + qcom,freq-domain = <&cpufreq_hw 0>; > > You mean this or something else? Check https://lore.kernel.org/lkml/20221102065448.GA10650@thinkpad/T/ > >>> + operating-points-v2 = <&cpu0_opp_table>; >>> + interconnects = <&gem_noc MASTER_AMPSS_M0 3 &mc_virt SLAVE_EBI_CH0 3>, >>> + <&osm_l3 MASTER_OSM_L3_APPS &osm_l3 SLAVE_OSM_L3>; >>> + power-domains = <&CPU_PD0>; >>> + power-domain-names = "psci"; >>> + #cooling-cells = <2>; >> Add a newline before subnodes, please. > > Sure > >> >>> + L2_0: l2-cache { >>> + compatible = "cache"; >>> + next-level-cache = <&L3_0>; >>> + L3_0: l3-cache { >>> + compatible = "cache"; >>> + }; >>> + }; >>> + }; >>> + >> [...] >> >>> + >>> + cpu0_opp_table: opp-table-cpu0 { >>> + compatible = "operating-points-v2"; >>> + opp-shared; >>> + >>> + opp-300000000 { >>> + opp-hz = /bits/ 64 <300000000>; >>> + opp-peak-kBps = <800000 9600000>; >> Maybe adding bwmon from the get-go would be better than statically >> scaling DDR freq? > > Maybe :-) but we would like to land the dts now rather than wait more :) > >> >> [...] >> >>> + camnoc_virt: interconnect-0{ >> Missing space before { > > Will fix > >>> + compatible = "qcom,sc8180x-camnoc-virt"; >>> + #interconnect-cells = <2>; >>> + qcom,bcm-voters = <&apps_bcm_voter>; >>> + }; >>> + >>> + mc_virt: interconnect-mc-virt { >> Please be consistent with your naming. > > Are you referring to adding -0 for this? I'm not sure which is preferred (-n vs -name), there's a mixed bag upstream.. Krzysztof? > >> >>> + compatible = "qcom,sc8180x-mc-virt"; >>> + #interconnect-cells = <2>; >>> + qcom,bcm-voters = <&apps_bcm_voter>; >>> + }; >>> + >>> + qup_virt: interconnect-qup-virt { >>> + compatible = "qcom,sc8180x-qup-virt"; >>> + #interconnect-cells = <2>; >>> + qcom,bcm-voters = <&apps_bcm_voter>; >>> + }; >>> + >> [...] >> >>> + reserved-memory { >>> + #address-cells = <2>; >>> + #size-cells = <2>; >>> + ranges; >>> + >>> + hyp_mem: hyp-region@85700000 { >> the -region seems a bit unnecessary in all of these nodes > > This is reserved for hyp, I think we should add it here so that we dont > touch this piece..? I meant the '-region' bit in the node names (label: name@unit-address) Konrad > >> >>> + reg = <0x0 0x85700000 0x0 0x600000>; >>> + no-map; >>> + }; >>> + >> [...] >> >>> + >>> + soc: soc@0 { >>> + #address-cells = <2>; >>> + #size-cells = <2>; >>> + ranges = <0 0 0 0 0x10 0>; >>> + dma-ranges = <0 0 0 0 0x10 0>; >>> + compatible = "simple-bus"; >> compat >> addr-cells >> size-cella >> ranges >> dma-ranges >> >> please > > Sure > >> >>> + >>> + gcc: clock-controller@100000 { >>> + compatible = "qcom,gcc-sc8180x"; >>> + reg = <0x0 0x00100000 0x0 0x1f0000>; >>> + #clock-cells = <1>; >>> + #reset-cells = <1>; >>> + #power-domain-cells = <1>; >>> + clock-names = "bi_tcxo", >>> + "bi_tcxo_ao", >>> + "sleep_clk"; >>> + clocks = <&rpmhcc RPMH_CXO_CLK>, >>> + <&rpmhcc RPMH_CXO_CLK_A>, >>> + <&sleep_clk>; >> property before property-names > > ok > >> >> >>> + }; >>> + >>> + qupv3_id_0: geniqup@8c0000 { >>> + compatible = "qcom,geni-se-qup"; >>> + reg = <0 0x008c0000 0 0x6000>; >>> + clock-names = "m-ahb", "s-ahb"; >>> + clocks = <&gcc GCC_QUPV3_WRAP_0_M_AHB_CLK>, >>> + <&gcc GCC_QUPV3_WRAP_0_S_AHB_CLK>; >>> + #address-cells = <2>; >>> + #size-cells = <2>; >>> + ranges; >>> + iommus = <&apps_smmu 0x4c3 0>; >>> + status = "disabled"; >>> + >>> + i2c0: i2c@880000 { >>> + compatible = "qcom,geni-i2c"; >>> + reg = <0 0x00880000 0 0x4000>; >>> + clock-names = "se"; >>> + clocks = <&gcc GCC_QUPV3_WRAP0_S0_CLK>; >> property before property-names >> >> Please split QUPs into a separate patch, this one is way >> too big. > > Will do > >> >> [...] >> >>> + config_noc: interconnect@1500000 { >> Interconnect could also realistically go to a separate patch. > > Yeah already list is complaining, let me see how to split it up... > >> >>> + compatible = "qcom,sc8180x-config-noc"; >>> + reg = <0 0x01500000 0 0x7400>; >>> + #interconnect-cells = <2>; >>> + qcom,bcm-voters = <&apps_bcm_voter>; >>> + }; >>> + >>> + system_noc: interconnect@1620000 { >>> + compatible = "qcom,sc8180x-system-noc"; >>> + reg = <0 0x01620000 0 0x19400>; >>> + #interconnect-cells = <2>; >>> + qcom,bcm-voters = <&apps_bcm_voter>; >>> + }; >>> + >>> + aggre1_noc: interconnect@16e0000 { >>> + compatible = "qcom,sc8180x-aggre1-noc"; >>> + reg = <0 0x016e0000 0 0xd080>; >>> + #interconnect-cells = <2>; >>> + qcom,bcm-voters = <&apps_bcm_voter>; >>> + }; >>> + >>> + aggre2_noc: interconnect@1700000 { >>> + compatible = "qcom,sc8180x-aggre2-noc"; >>> + reg = <0 0x01700000 0 0x20000>; >>> + #interconnect-cells = <2>; >>> + qcom,bcm-voters = <&apps_bcm_voter>; >>> + }; >>> + >>> + compute_noc: interconnect@1720000 { >>> + compatible = "qcom,sc8180x-compute-noc"; >>> + reg = <0 0x01720000 0 0x7000>; >>> + #interconnect-cells = <2>; >>> + qcom,bcm-voters = <&apps_bcm_voter>; >>> + }; >>> + >>> + mmss_noc: interconnect@1740000 { >>> + compatible = "qcom,sc8180x-mmss-noc"; >>> + reg = <0 0x01740000 0 0x1c100>; >>> + #interconnect-cells = <2>; >>> + qcom,bcm-voters = <&apps_bcm_voter>; >>> + }; >>> + >> [...] >> >>> + pcie0: pci@1c00000 { >> And PCIe >> >>> + compatible = "qcom,pcie-sc8180x"; >>> + reg = <0 0x01c00000 0 0x3000>, >>> + <0 0x60000000 0 0xf1d>, >>> + <0 0x60000f20 0 0xa8>, >>> + <0 0x60001000 0 0x1000>, >>> + <0 0x60100000 0 0x100000>; >>> + reg-names = "parf", "dbi", "elbi", "atu", "config"; >> One per line, please > > ok > >> >> >> [...] >> >>> + >>> + ufs_mem_hc: ufshc@1d84000 { >>> + compatible = "qcom,sc8180x-ufshc", "qcom,ufshc", >>> + "jedec,ufs-2.0"; >>> + reg = <0 0x01d84000 0 0x2500>; >>> + interrupts = <GIC_SPI 265 IRQ_TYPE_LEVEL_HIGH>; >>> + phys = <&ufs_mem_phy_lanes>; >>> + phy-names = "ufsphy"; >>> + lanes-per-direction = <2>; >>> + #reset-cells = <1>; >>> + resets = <&gcc GCC_UFS_PHY_BCR>; >>> + reset-names = "rst"; >>> + >>> + iommus = <&apps_smmu 0x300 0>; >>> + >>> + clock-names = >> No need for this weird newline split. >> >> Also, property before property-names. >> >> [...] >> >> >>> + >>> + gpu: gpu@2c00000 { >> GPUSS and MDSS related nodes should also go to their separate, >> respective patches. > > ok > >> >> [...] >>> + >>> + remoteproc_mpss: remoteproc@4080000 { >> And remote procs as well >> >>> + compatible = "qcom,sc8180x-mpss-pas"; >>> + reg = <0x0 0x04080000 0x0 0x4040>; >>> + >> [...] >> >>> + thermal-zones { >> And thermal-zones as well. >> >> >> I'll go more in-depth after you split it up, this is pretty hard >> to review as-is. >> >> Konrad >>> + cpu0-thermal { >>> + polling-delay-passive = <250>; >>> + polling-delay = <1000>; >>> + >>> + thermal-sensors = <&tsens0 1>; >>> + >>> + trips { >>> + cpu-crit { >>> + temperature = <110000>; >>> + hysteresis = <1000>; >>> + type = "critical"; >>> + }; >>> + }; >>> + }; >>> + >>> + cpu1-thermal { >>> + polling-delay-passive = <250>; >>> + polling-delay = <1000>; >>> + >>> + thermal-sensors = <&tsens0 2>; >>> + >>> + trips { >>> + cpu-crit { >>> + temperature = <110000>; >>> + hysteresis = <1000>; >>> + type = "critical"; >>> + }; >>> + }; >>> + }; >>> + >>> + cpu2-thermal { >>> + polling-delay-passive = <250>; >>> + polling-delay = <1000>; >>> + >>> + thermal-sensors = <&tsens0 3>; >>> + >>> + trips { >>> + cpu-crit { >>> + temperature = <110000>; >>> + hysteresis = <1000>; >>> + type = "critical"; >>> + }; >>> + }; >>> + }; >>> + >>> + cpu3-thermal { >>> + polling-delay-passive = <250>; >>> + polling-delay = <1000>; >>> + >>> + thermal-sensors = <&tsens0 4>; >>> + >>> + trips { >>> + cpu-crit { >>> + temperature = <110000>; >>> + hysteresis = <1000>; >>> + type = "critical"; >>> + }; >>> + }; >>> + }; >>> + >>> + cpu4-top-thermal { >>> + polling-delay-passive = <250>; >>> + polling-delay = <1000>; >>> + >>> + thermal-sensors = <&tsens0 7>; >>> + >>> + trips { >>> + cpu-crit { >>> + temperature = <110000>; >>> + hysteresis = <1000>; >>> + type = "critical"; >>> + }; >>> + }; >>> + }; >>> + >>> + cpu5-top-thermal { >>> + polling-delay-passive = <250>; >>> + polling-delay = <1000>; >>> + >>> + thermal-sensors = <&tsens0 8>; >>> + >>> + trips { >>> + cpu-crit { >>> + temperature = <110000>; >>> + hysteresis = <1000>; >>> + type = "critical"; >>> + }; >>> + }; >>> + }; >>> + >>> + cpu6-top-thermal { >>> + polling-delay-passive = <250>; >>> + polling-delay = <1000>; >>> + >>> + thermal-sensors = <&tsens0 9>; >>> + >>> + trips { >>> + cpu-crit { >>> + temperature = <110000>; >>> + hysteresis = <1000>; >>> + type = "critical"; >>> + }; >>> + }; >>> + }; >>> + >>> + cpu7-top-thermal { >>> + polling-delay-passive = <250>; >>> + polling-delay = <1000>; >>> + >>> + thermal-sensors = <&tsens0 10>; >>> + >>> + trips { >>> + cpu-crit { >>> + temperature = <110000>; >>> + hysteresis = <1000>; >>> + type = "critical"; >>> + }; >>> + }; >>> + }; >>> + >>> + cpu4-bottom-thermal { >>> + polling-delay-passive = <250>; >>> + polling-delay = <1000>; >>> + >>> + thermal-sensors = <&tsens0 11>; >>> + >>> + trips { >>> + cpu-crit { >>> + temperature = <110000>; >>> + hysteresis = <1000>; >>> + type = "critical"; >>> + }; >>> + }; >>> + }; >>> + >>> + cpu5-bottom-thermal { >>> + polling-delay-passive = <250>; >>> + polling-delay = <1000>; >>> + >>> + thermal-sensors = <&tsens0 12>; >>> + >>> + trips { >>> + cpu-crit { >>> + temperature = <110000>; >>> + hysteresis = <1000>; >>> + type = "critical"; >>> + }; >>> + }; >>> + }; >>> + >>> + cpu6-bottom-thermal { >>> + polling-delay-passive = <250>; >>> + polling-delay = <1000>; >>> + >>> + thermal-sensors = <&tsens0 13>; >>> + >>> + trips { >>> + cpu-crit { >>> + temperature = <110000>; >>> + hysteresis = <1000>; >>> + type = "critical"; >>> + }; >>> + }; >>> + }; >>> + >>> + cpu7-bottom-thermal { >>> + polling-delay-passive = <250>; >>> + polling-delay = <1000>; >>> + >>> + thermal-sensors = <&tsens0 14>; >>> + >>> + trips { >>> + cpu-crit { >>> + temperature = <110000>; >>> + hysteresis = <1000>; >>> + type = "critical"; >>> + }; >>> + }; >>> + }; >>> + >>> + aoss0-thermal { >>> + polling-delay-passive = <250>; >>> + polling-delay = <1000>; >>> + >>> + thermal-sensors = <&tsens0 0>; >>> + >>> + trips { >>> + trip-point0 { >>> + temperature = <90000>; >>> + hysteresis = <2000>; >>> + type = "hot"; >>> + }; >>> + }; >>> + }; >>> + >>> + cluster0-thermal { >>> + polling-delay-passive = <250>; >>> + polling-delay = <1000>; >>> + >>> + thermal-sensors = <&tsens0 5>; >>> + >>> + trips { >>> + cluster-crit { >>> + temperature = <110000>; >>> + hysteresis = <2000>; >>> + type = "critical"; >>> + }; >>> + }; >>> + }; >>> + >>> + cluster1-thermal { >>> + polling-delay-passive = <250>; >>> + polling-delay = <1000>; >>> + >>> + thermal-sensors = <&tsens0 6>; >>> + >>> + trips { >>> + cluster-crit { >>> + temperature = <110000>; >>> + hysteresis = <2000>; >>> + type = "critical"; >>> + }; >>> + }; >>> + }; >>> + >>> + gpu-thermal-top { >>> + polling-delay-passive = <250>; >>> + polling-delay = <1000>; >>> + >>> + thermal-sensors = <&tsens0 15>; >>> + >>> + trips { >>> + trip-point0 { >>> + temperature = <90000>; >>> + hysteresis = <2000>; >>> + type = "hot"; >>> + }; >>> + }; >>> + }; >>> + >>> + aoss1-thermal { >>> + polling-delay-passive = <250>; >>> + polling-delay = <1000>; >>> + >>> + thermal-sensors = <&tsens1 0>; >>> + >>> + trips { >>> + trip-point0 { >>> + temperature = <90000>; >>> + hysteresis = <2000>; >>> + type = "hot"; >>> + }; >>> + }; >>> + }; >>> + >>> + wlan-thermal { >>> + polling-delay-passive = <250>; >>> + polling-delay = <1000>; >>> + >>> + thermal-sensors = <&tsens1 1>; >>> + >>> + trips { >>> + trip-point0 { >>> + temperature = <90000>; >>> + hysteresis = <2000>; >>> + type = "hot"; >>> + }; >>> + }; >>> + }; >>> + >>> + video-thermal { >>> + polling-delay-passive = <250>; >>> + polling-delay = <1000>; >>> + >>> + thermal-sensors = <&tsens1 2>; >>> + >>> + trips { >>> + trip-point0 { >>> + temperature = <90000>; >>> + hysteresis = <2000>; >>> + type = "hot"; >>> + }; >>> + }; >>> + }; >>> + >>> + mem-thermal { >>> + polling-delay-passive = <250>; >>> + polling-delay = <1000>; >>> + >>> + thermal-sensors = <&tsens1 3>; >>> + >>> + trips { >>> + trip-point0 { >>> + temperature = <90000>; >>> + hysteresis = <2000>; >>> + type = "hot"; >>> + }; >>> + }; >>> + }; >>> + >>> + q6-hvx-thermal { >>> + polling-delay-passive = <250>; >>> + polling-delay = <1000>; >>> + >>> + thermal-sensors = <&tsens1 4>; >>> + >>> + trips { >>> + trip-point0 { >>> + temperature = <90000>; >>> + hysteresis = <2000>; >>> + type = "hot"; >>> + }; >>> + }; >>> + }; >>> + >>> + camera-thermal { >>> + polling-delay-passive = <250>; >>> + polling-delay = <1000>; >>> + >>> + thermal-sensors = <&tsens1 5>; >>> + >>> + trips { >>> + trip-point0 { >>> + temperature = <90000>; >>> + hysteresis = <2000>; >>> + type = "hot"; >>> + }; >>> + }; >>> + }; >>> + >>> + compute-thermal { >>> + polling-delay-passive = <250>; >>> + polling-delay = <1000>; >>> + >>> + thermal-sensors = <&tsens1 6>; >>> + >>> + trips { >>> + trip-point0 { >>> + temperature = <90000>; >>> + hysteresis = <2000>; >>> + type = "hot"; >>> + }; >>> + }; >>> + }; >>> + >>> + mdm-dsp-thermal { >>> + polling-delay-passive = <250>; >>> + polling-delay = <1000>; >>> + >>> + thermal-sensors = <&tsens1 7>; >>> + >>> + trips { >>> + trip-point0 { >>> + temperature = <90000>; >>> + hysteresis = <2000>; >>> + type = "hot"; >>> + }; >>> + }; >>> + }; >>> + >>> + npu-thermal { >>> + polling-delay-passive = <250>; >>> + polling-delay = <1000>; >>> + >>> + thermal-sensors = <&tsens1 8>; >>> + >>> + trips { >>> + trip-point0 { >>> + temperature = <90000>; >>> + hysteresis = <2000>; >>> + type = "hot"; >>> + }; >>> + }; >>> + }; >>> + >>> + gpu-thermal-bottom { >>> + polling-delay-passive = <250>; >>> + polling-delay = <1000>; >>> + >>> + thermal-sensors = <&tsens1 11>; >>> + >>> + trips { >>> + trip-point0 { >>> + temperature = <90000>; >>> + hysteresis = <2000>; >>> + type = "hot"; >>> + }; >>> + }; >>> + }; >>> + }; >>> + >>> + timer { >>> + compatible = "arm,armv8-timer"; >>> + interrupts = <GIC_PPI 1 IRQ_TYPE_LEVEL_LOW>, >>> + <GIC_PPI 2 IRQ_TYPE_LEVEL_LOW>, >>> + <GIC_PPI 3 IRQ_TYPE_LEVEL_LOW>, >>> + <GIC_PPI 0 IRQ_TYPE_LEVEL_LOW>; >>> + }; >>> +}; >
On 27.03.2023 07:43, Vinod Koul wrote: > On 25-03-23, 13:40, Konrad Dybcio wrote: >> >> >> On 25.03.2023 13:24, Vinod Koul wrote: >>> From: Bjorn Andersson <bjorn.andersson@linaro.org> >>> >>> Introduce support for the Lenovo Flex 5G laptop, built on the Qualcomm >>> SC8180X platform. Supported peripherals includes keyboard, touchpad, >>> UFS storage, external USB and WiFi. >>> >>> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> >>> Signed-off-by: Vinod Koul <vkoul@kernel.org> >>> --- >>> arch/arm64/boot/dts/qcom/Makefile | 1 + >>> .../boot/dts/qcom/sc8180x-lenovo-flex-5g.dts | 590 ++++++++++++++++++ >>> 2 files changed, 591 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts >>> >>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >>> index fdce44a7a902..f096561f711e 100644 >>> --- a/arch/arm64/boot/dts/qcom/Makefile >>> +++ b/arch/arm64/boot/dts/qcom/Makefile >>> @@ -141,6 +141,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-zombie-nvme-lte.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += sc7280-idp.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += sc7280-idp2.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += sc7280-crd-r3.dtb >>> +dtb-$(CONFIG_ARCH_QCOM) += sc8180x-lenovo-flex-5g.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += sc8180x-primus.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += sc8280xp-crd.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += sc8280xp-lenovo-thinkpad-x13s.dtb >>> diff --git a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts >>> new file mode 100644 >>> index 000000000000..76dad608fb85 >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts >>> @@ -0,0 +1,590 @@ >>> +// SPDX-License-Identifier: BSD-3-Clause >>> +/* >>> + * Copyright (c) 2017-2019, The Linux Foundation. All rights reserved. >>> + * Copyright (c) 2020-2023, Linaro Limited >>> + */ >>> + >>> +/dts-v1/; >>> + >>> +#include <dt-bindings/gpio/gpio.h> >>> +#include <dt-bindings/input/gpio-keys.h> >>> +#include <dt-bindings/input/input.h> >>> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h> >>> +#include "sc8180x.dtsi" >>> +#include "sc8180x-pmics.dtsi" >>> + >>> +/ { >>> + model = "Lenovo Flex 5G"; >>> + compatible = "lenovo,flex-5g", "qcom,sc8180x"; >>> + >>> + aliases { >>> + serial0 = &uart13; >>> + }; >>> + >>> + backlight: backlight { >>> + compatible = "pwm-backlight"; >>> + pwms = <&pmc8180c_lpg 4 1000000>; >>> + enable-gpios = <&pmc8180c_gpios 8 GPIO_ACTIVE_HIGH>; >>> + >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&bl_pwm_default>; >>> + }; >>> + >>> + chosen { >>> + }; >> Unused, remove. > > ok > >> >>> + >>> + gpio-keys { >>> + compatible = "gpio-keys"; >>> + >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&hall_int_active_state>; >> property >> property-names > > ack here and everwhere else > >> >>> + >>> + lid { >>> + gpios = <&tlmm 121 GPIO_ACTIVE_LOW>; >>> + linux,input-type = <EV_SW>; >>> + linux,code = <SW_LID>; >>> + wakeup-source; >>> + wakeup-event-action = <EV_ACT_DEASSERTED>; >>> + }; >>> + }; >>> + >>> + reserved-memory { >>> + rmtfs_mem: rmtfs-region@85500000 { >>> + compatible = "qcom,rmtfs-mem"; >>> + reg = <0x0 0x85500000 0x0 0x200000>; >> You're using 0 and 0x0 in a mixed fashion. Please stick with one, >> preferably 0x0 everywhere. > > yep > >> >>> + no-map; >>> + >>> + qcom,client-id = <1>; >>> + qcom,vmid = <15>; >>> + }; >>> + >> [...] >> >>> + >>> +&dispcc { >>> + status = "okay"; >> Any reason for disabling dispcc by default? > > I think that is a good question. I would prefer disabling and enabling > in places it is required, we might have a headless system or a dev board > where we dont have display..? It's a double-edged sword: on one side we could disable clocks that were mistakenly enabled, but on the other hand we do keep some some clocks always-on within that driver.. Perhaps leave it on by default and shut it off per-board if need be. > >> >>> +}; >>> + >>> +&gpu { >>> + status = "okay"; >>> + >>> + zap-shader { >>> + memory-region = <&gpu_mem>; >>> + firmware-name = "qcom/sc8180x/qcdxkmsuc8180.mbn"; >>> + }; >>> +}; >>> + >>> +&i2c1 { >>> + clock-frequency = <100000>; >>> + >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&i2c1_active>, <&i2c1_hid_active>; >> property >> property-names >> >>> + >>> + status = "okay"; >>> + >>> + hid@10 { >>> + compatible = "hid-over-i2c"; >>> + reg = <0x10>; >>> + hid-descr-addr = <0x1>; >>> + >>> + interrupts-extended = <&tlmm 122 IRQ_TYPE_LEVEL_LOW>; >>> + }; >>> +}; >>> + >>> +&i2c7 { >>> + clock-frequency = <100000>; >>> + >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&i2c7_active>, <&i2c7_hid_active>; >>> + >>> + status = "okay"; >>> + >>> + hid@5 { >>> + compatible = "hid-over-i2c"; >>> + reg = <0x5>; >>> + hid-descr-addr = <0x20>; >>> + >>> + interrupts-extended = <&tlmm 37 IRQ_TYPE_LEVEL_LOW>; >>> + }; >>> + >>> + hid@2c { >>> + compatible = "hid-over-i2c"; >>> + reg = <0x2c>; >>> + hid-descr-addr = <0x20>; >>> + >>> + interrupts-extended = <&tlmm 24 IRQ_TYPE_LEVEL_LOW>; >>> + }; >>> +}; >>> + >>> +&mdss { >>> + status = "okay"; >>> +}; >>> + >>> +&mdss_edp { >>> + data-lanes = <0 1 2 3>; >>> + >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&edp_hpd_active>; >>> + >>> + status = "okay"; >>> + >>> + aux-bus { >>> + panel { >>> + compatible = "edp-panel"; >>> + no-hpd; >>> + >>> + backlight = <&backlight>; >>> + >>> + ports { >>> + port { >>> + auo_b140han06_in: endpoint { >>> + remote-endpoint = <&mdss_edp_out>; >>> + }; >>> + }; >>> + }; >>> + }; >>> + }; >>> + >>> + ports { >>> + port@1 { >>> + reg = <1>; >>> + mdss_edp_out: endpoint { >>> + remote-endpoint = <&auo_b140han06_in>; >>> + }; >>> + }; >>> + }; >>> +}; >>> + >>> +&pcie3 { >>> + perst-gpio = <&tlmm 178 GPIO_ACTIVE_LOW>; >>> + wake-gpio = <&tlmm 180 GPIO_ACTIVE_HIGH>; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&pcie3_default_state>; >>> + >>> + status = "okay"; >>> +}; >>> + >>> +&pcie3_phy { >>> + vdda-phy-supply = <&vreg_l5e_0p88>; >>> + vdda-pll-supply = <&vreg_l3c_1p2>; >>> + >>> + status = "okay"; >>> +}; >>> + >>> +&pmc8180c_lpg { >>> + status = "okay"; >>> +}; >>> + >>> +&qupv3_id_0 { >>> + status = "okay"; >>> +}; >>> + >>> +&qupv3_id_1 { >>> + status = "okay"; >>> +}; >>> + >>> +&qupv3_id_2 { >>> + status = "okay"; >>> +}; >>> + >>> +&remoteproc_adsp { >>> + memory-region = <&adsp_mem>; >>> + firmware-name = "qcom/sc8180x/LENOVO/82AK/qcadsp8180.mbn"; >>> + >>> + status = "okay"; >>> +}; >>> + >>> +&remoteproc_cdsp { >>> + memory-region = <&cdsp_mem>; >>> + firmware-name = "qcom/sc8180x/LENOVO/82AK/qccdsp8180.mbn"; >>> + >>> + status = "okay"; >>> +}; >>> + >>> +&remoteproc_mpss { >>> + memory-region = <&mpss_mem>; >>> + firmware-name = "qcom/sc8180x/LENOVO/82AK/qcmpss8180_nm.mbn"; >>> + >>> + status = "okay"; >>> +}; >>> + >>> +&uart13 { >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&uart13_state>; >>> + >>> + status = "okay"; >>> + >>> + bluetooth { >>> + compatible = "qcom,wcn3998-bt"; >>> + >>> + vddio-supply = <&vreg_s4a_1p8>; >>> + vddxo-supply = <&vreg_l7a_1p8>; >>> + vddrf-supply = <&vreg_l9a_1p3>; >>> + vddch0-supply = <&vreg_l11c_3p3>; >>> + max-speed = <3200000>; >>> + }; >>> +}; >>> + >>> +&ufs_mem_hc { >>> + reset-gpios = <&tlmm 190 GPIO_ACTIVE_LOW>; >>> + >>> + vcc-supply = <&vreg_l10e_2p9>; >>> + vcc-max-microamp = <155000>; >>> + >>> + vccq2-supply = <&vreg_l7e_1p8>; >>> + vccq2-max-microamp = <425000>; >> Missing regulator-allow-set-load for regulators that have current >> ops assigned to them. >> >>> + >>> + status = "okay"; >>> +}; >>> + >>> +&ufs_mem_phy { >>> + vdda-phy-supply = <&vreg_l5e_0p88>; >>> + vdda-pll-supply = <&vreg_l3c_1p2>; >>> + >>> + status = "okay"; >>> +}; >>> + >>> +&usb_prim_hsphy { >>> + vdda-pll-supply = <&vreg_l5e_0p88>; >>> + vdda18-supply = <&vreg_l12a_1p8>; >>> + vdda33-supply = <&vreg_l16e_3p0>; >>> + >>> + status = "okay"; >>> +}; >>> + >>> +&usb_prim_qmpphy { >>> + vdda-phy-supply = <&vreg_l3c_1p2>; >>> + vdda-pll-supply = <&vreg_l5e_0p88>; >>> + >>> + status = "okay"; >>> +}; >>> + >>> +&usb_prim { >> We mostly use usb_1 / usb_2 for this > > Isnt this better from readablity pov? esp since this is board dts Generally both sound pretty reasonable but I'm just saying that all other trees name this differently.. Konrad > >> >>> + status = "okay"; >>> +}; >>> + >>> +&usb_prim_dwc3 { >>> + dr_mode = "host"; >>> +}; >>> + >>> +&usb_sec_hsphy { >>> + vdda-pll-supply = <&vreg_l5e_0p88>; >>> + vdda18-supply = <&vreg_l12a_1p8>; >>> + vdda33-supply = <&vreg_l16e_3p0>; >>> + >>> + status = "okay"; >>> +}; >>> + >>> +&usb_sec_qmpphy { >>> + vdda-phy-supply = <&vreg_l3c_1p2>; >>> + vdda-pll-supply = <&vreg_l5e_0p88>; >>> + >>> + status = "okay"; >>> +}; >>> + >>> +&usb_sec { >>> + status = "okay"; >>> +}; >>> + >>> +&usb_sec_dwc3 { >>> + dr_mode = "host"; >> No roleswitching? > > Laptop :-) Always in host mode > >> >>> +}; >>> + >>> +&wifi { >>> + memory-region = <&wlan_mem>; >> It comes from the common dt file, so this may as well stay there. > > I can do that >
On Mon, Mar 27, 2023 at 09:46:31AM +0200, Krzysztof Kozlowski wrote: > On 25/03/2023 13:24, Vinod Koul wrote: > > This introduces Qualcomm SC8180x SoC which features in Lenovo Flex 5G > > laptop. This also adds support for Primus platform as well as Lenovo Flex 5G > > laptop. > > > > I would be great if submaintainers can ack the binding patch so that > > everything can go thru qcom tree > > I think Bjorn recently was rejecting taking bindings patches, so what > changed? > Nothing changed. In the interest of reducing the risk for merge conflicts I still think it's best if bindings goes via respective maintainer trees; so patch 1 is for me... Regards, Bjorn
On Mon, Mar 27, 2023 at 10:51:38AM +0200, Konrad Dybcio wrote: > On 27.03.2023 07:43, Vinod Koul wrote: > > On 25-03-23, 13:40, Konrad Dybcio wrote: > >> On 25.03.2023 13:24, Vinod Koul wrote: > >>> From: Bjorn Andersson <bjorn.andersson@linaro.org> [..] > >>> +&dispcc { > >>> + status = "okay"; > >> Any reason for disabling dispcc by default? > > > > I think that is a good question. I would prefer disabling and enabling > > in places it is required, we might have a headless system or a dev board > > where we dont have display..? > It's a double-edged sword: on one side we could disable clocks that were > mistakenly enabled, but on the other hand we do keep some some clocks > always-on within that driver.. > > Perhaps leave it on by default and shut it off per-board if need be. > There is a little bit of overhead in keeping the clock controllers enabled at all times, but I expect it to benefit us in that it would ensure that any clocks that the bootloader might have left on will be disabled. So, I think we should go with enable by default and leave enabled. Regards, Bjorn
On 26-03-23, 09:10, Rob Herring wrote: > > On Sat, 25 Mar 2023 17:54:37 +0530, Vinod Koul wrote: > > SC8180x comes with interconnects having and missing IO address space, and > > variable number of clocks, so split it from common file for easier > > maintenance and to fix warnings like: > > > > sc8180x-lenovo-flex-5g.dtb: interconnect-0: 'reg' is a required property > > > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > > --- > > .../bindings/interconnect/qcom,rpmh.yaml | 11 --- > > .../interconnect/qcom,sc8180x-rpmh.yaml | 76 +++++++++++++++++++ > > 2 files changed, 76 insertions(+), 11 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sc8180x-rpmh.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): Thanks I have fixed this error, will post v3 soon
On 27-03-23, 10:49, Konrad Dybcio wrote: > On 27.03.2023 07:38, Vinod Koul wrote: > > On 25-03-23, 13:34, Konrad Dybcio wrote: > >>> + cpus { > >>> + #address-cells = <2>; > >>> + #size-cells = <0>; > >>> + > >>> + CPU0: cpu@0 { > >>> + device_type = "cpu"; > >>> + compatible = "qcom,kryo485"; > >>> + reg = <0x0 0x0>; > >> Please add clocks = <&cpufreq_hw n>; > >> > >>> + enable-method = "psci"; > >>> + capacity-dmips-mhz = <602>; > >>> + next-level-cache = <&L2_0>; > >>> + qcom,freq-domain = <&cpufreq_hw 0>; > > > > You mean this or something else? > Check > > https://lore.kernel.org/lkml/20221102065448.GA10650@thinkpad/T/ Good point, thanks > >>> + compatible = "qcom,sc8180x-camnoc-virt"; > >>> + #interconnect-cells = <2>; > >>> + qcom,bcm-voters = <&apps_bcm_voter>; > >>> + }; > >>> + > >>> + mc_virt: interconnect-mc-virt { > >> Please be consistent with your naming. > > > > Are you referring to adding -0 for this? > I'm not sure which is preferred (-n vs -name), there's a mixed bag > upstream.. Krzysztof? Either ways this should be consistent, so camnoc_virt: interconnect-camnoc_virt makes sense rather than arbitrary -0 > >>> + compatible = "qcom,sc8180x-mc-virt"; > >>> + #interconnect-cells = <2>; > >>> + qcom,bcm-voters = <&apps_bcm_voter>; > >>> + }; > >>> + > >>> + qup_virt: interconnect-qup-virt { > >>> + compatible = "qcom,sc8180x-qup-virt"; > >>> + #interconnect-cells = <2>; > >>> + qcom,bcm-voters = <&apps_bcm_voter>; > >>> + }; > >>> + > >> [...] > >> > >>> + reserved-memory { > >>> + #address-cells = <2>; > >>> + #size-cells = <2>; > >>> + ranges; > >>> + > >>> + hyp_mem: hyp-region@85700000 { > >> the -region seems a bit unnecessary in all of these nodes > > > > This is reserved for hyp, I think we should add it here so that we dont > > touch this piece..? > I meant the '-region' bit in the node names > > (label: name@unit-address) ack, thanks for clearing my misunderstanding
On 28.03.2023 15:13, Vinod Koul wrote: > On 27-03-23, 10:49, Konrad Dybcio wrote: >> On 27.03.2023 07:38, Vinod Koul wrote: >>> On 25-03-23, 13:34, Konrad Dybcio wrote: > >>>>> + cpus { >>>>> + #address-cells = <2>; >>>>> + #size-cells = <0>; >>>>> + >>>>> + CPU0: cpu@0 { >>>>> + device_type = "cpu"; >>>>> + compatible = "qcom,kryo485"; >>>>> + reg = <0x0 0x0>; >>>> Please add clocks = <&cpufreq_hw n>; >>>> >>>>> + enable-method = "psci"; >>>>> + capacity-dmips-mhz = <602>; >>>>> + next-level-cache = <&L2_0>; >>>>> + qcom,freq-domain = <&cpufreq_hw 0>; >>> >>> You mean this or something else? >> Check >> >> https://lore.kernel.org/lkml/20221102065448.GA10650@thinkpad/T/ > > Good point, thanks > >>>>> + compatible = "qcom,sc8180x-camnoc-virt"; >>>>> + #interconnect-cells = <2>; >>>>> + qcom,bcm-voters = <&apps_bcm_voter>; >>>>> + }; >>>>> + >>>>> + mc_virt: interconnect-mc-virt { >>>> Please be consistent with your naming. >>> >>> Are you referring to adding -0 for this? >> I'm not sure which is preferred (-n vs -name), there's a mixed bag >> upstream.. Krzysztof? > > Either ways this should be consistent, so camnoc_virt: > interconnect-camnoc_virt makes sense rather than arbitrary -0 Yeah, just remember that underscores are forbidden in node names, use hyphen instead! Konrad > >>>>> + compatible = "qcom,sc8180x-mc-virt"; >>>>> + #interconnect-cells = <2>; >>>>> + qcom,bcm-voters = <&apps_bcm_voter>; >>>>> + }; >>>>> + >>>>> + qup_virt: interconnect-qup-virt { >>>>> + compatible = "qcom,sc8180x-qup-virt"; >>>>> + #interconnect-cells = <2>; >>>>> + qcom,bcm-voters = <&apps_bcm_voter>; >>>>> + }; >>>>> + >>>> [...] >>>> >>>>> + reserved-memory { >>>>> + #address-cells = <2>; >>>>> + #size-cells = <2>; >>>>> + ranges; >>>>> + >>>>> + hyp_mem: hyp-region@85700000 { >>>> the -region seems a bit unnecessary in all of these nodes >>> >>> This is reserved for hyp, I think we should add it here so that we dont >>> touch this piece..? >> I meant the '-region' bit in the node names >> >> (label: name@unit-address) > > ack, thanks for clearing my misunderstanding >
On Sat, 25 Mar 2023 17:54:32 +0530, Vinod Koul wrote: > This introduces Qualcomm SC8180x SoC which features in Lenovo Flex 5G > laptop. This also adds support for Primus platform as well as Lenovo Flex 5G > laptop. > > I would be great if submaintainers can ack the binding patch so that > everything can go thru qcom tree > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next Thanks! [08/12] regulator: dt-bindings: qcom,rpmh: Add compatible for PMC8180 commit: fc4fef625decc80cf3a72e884a4e37288bfa0f9b All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
On Sat, 25 Mar 2023 17:54:32 +0530, Vinod Koul wrote: > This introduces Qualcomm SC8180x SoC which features in Lenovo Flex 5G > laptop. This also adds support for Primus platform as well as Lenovo Flex 5G > laptop. > > I would be great if submaintainers can ack the binding patch so that > everything can go thru qcom tree > > [...] Applied, thanks! [01/12] dt-bindings: firmware: document Qualcomm SC8180X SCM commit: c78ad8597ed961e822bf86ce7f1916dbfba255ef Best regards,