diff mbox series

[v2] arm: dts: omap: Apply am57xx-idk overlays to base dtbs

Message ID 20231010211925.1629653-1-robh@kernel.org
State New
Headers show
Series [v2] arm: dts: omap: Apply am57xx-idk overlays to base dtbs | expand

Commit Message

Rob Herring (Arm) Oct. 10, 2023, 9:19 p.m. UTC
DT overlays in tree need to be applied to a base DTB to validate they
apply, to run schema checks on them, and to catch any errors at compile
time.

Signed-off-by: Rob Herring <robh@kernel.org>
---
v2:
 - Only test applying overlays when building all DTBs
---
 arch/arm/boot/dts/ti/omap/Makefile | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Tony Lindgren Oct. 18, 2023, 5:20 a.m. UTC | #1
* Rob Herring <robh@kernel.org> [231011 00:19]:
> DT overlays in tree need to be applied to a base DTB to validate they
> apply, to run schema checks on them, and to catch any errors at compile
> time.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> v2:
>  - Only test applying overlays when building all DTBs

Andrew, any comments or care to ack?

Regards,

Tony

> ---
>  arch/arm/boot/dts/ti/omap/Makefile | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/ti/omap/Makefile b/arch/arm/boot/dts/ti/omap/Makefile
> index d2b590004fed..d6ee4a247100 100644
> --- a/arch/arm/boot/dts/ti/omap/Makefile
> +++ b/arch/arm/boot/dts/ti/omap/Makefile
> @@ -129,6 +129,16 @@ dtb-$(CONFIG_SOC_AM43XX) += \
>  am57xx-evm-dtbs := am57xx-beagle-x15.dtb am57xx-evm.dtbo
>  am57xx-evm-reva3-dtbs := am57xx-beagle-x15-revc.dtb am57xx-evm.dtbo
>  
> +am571x-idk-overlays-dtbs := am571x-idk.dtb \
> +	am571x-idk-touchscreen.dtbo am57xx-idk-lcd-osd101t2587.dtbo
> +am572x-idk-overlays-dtbs := am572x-idk.dtb \
> +	am572x-idk-touchscreen.dtbo am57xx-idk-lcd-osd101t2045.dtbo
> +
> +# Build time test only, enabled by CONFIG_OF_ALL_DTBS
> +dtb- += \
> +	am571x-idk-overlays.dtb \
> +	am572x-idk-overlays.dtb
> +
>  dtb-$(CONFIG_SOC_DRA7XX) += \
>  	am57xx-beagle-x15.dtb \
>  	am57xx-beagle-x15-revb1.dtb \
> -- 
> 2.42.0
>
Andrew Davis Oct. 18, 2023, 2:05 p.m. UTC | #2
On 10/18/23 12:20 AM, Tony Lindgren wrote:
> * Rob Herring <robh@kernel.org> [231011 00:19]:
>> DT overlays in tree need to be applied to a base DTB to validate they
>> apply, to run schema checks on them, and to catch any errors at compile
>> time.
>>
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> ---
>> v2:
>>   - Only test applying overlays when building all DTBs
> 
> Andrew, any comments or care to ack?

As before, this is a valid combination, but it is only one of
many more. For now this is a reasonable start though,

Acked-by: Andrew Davis <afd@ti.com>

> 
> Regards,
> 
> Tony
> 
>> ---
>>   arch/arm/boot/dts/ti/omap/Makefile | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/ti/omap/Makefile b/arch/arm/boot/dts/ti/omap/Makefile
>> index d2b590004fed..d6ee4a247100 100644
>> --- a/arch/arm/boot/dts/ti/omap/Makefile
>> +++ b/arch/arm/boot/dts/ti/omap/Makefile
>> @@ -129,6 +129,16 @@ dtb-$(CONFIG_SOC_AM43XX) += \
>>   am57xx-evm-dtbs := am57xx-beagle-x15.dtb am57xx-evm.dtbo
>>   am57xx-evm-reva3-dtbs := am57xx-beagle-x15-revc.dtb am57xx-evm.dtbo
>>   
>> +am571x-idk-overlays-dtbs := am571x-idk.dtb \
>> +	am571x-idk-touchscreen.dtbo am57xx-idk-lcd-osd101t2587.dtbo
>> +am572x-idk-overlays-dtbs := am572x-idk.dtb \
>> +	am572x-idk-touchscreen.dtbo am57xx-idk-lcd-osd101t2045.dtbo
>> +
>> +# Build time test only, enabled by CONFIG_OF_ALL_DTBS
>> +dtb- += \
>> +	am571x-idk-overlays.dtb \
>> +	am572x-idk-overlays.dtb
>> +
>>   dtb-$(CONFIG_SOC_DRA7XX) += \
>>   	am57xx-beagle-x15.dtb \
>>   	am57xx-beagle-x15-revb1.dtb \
>> -- 
>> 2.42.0
>>
Tony Lindgren Nov. 28, 2023, 9:53 a.m. UTC | #3
* Andrew Davis <afd@ti.com> [231018 14:05]:
> On 10/18/23 12:20 AM, Tony Lindgren wrote:
> > * Rob Herring <robh@kernel.org> [231011 00:19]:
> > > DT overlays in tree need to be applied to a base DTB to validate they
> > > apply, to run schema checks on them, and to catch any errors at compile
> > > time.
> > > 
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> > > ---
> > > v2:
> > >   - Only test applying overlays when building all DTBs
> > 
> > Andrew, any comments or care to ack?
> 
> As before, this is a valid combination, but it is only one of
> many more. For now this is a reasonable start though,
> 
> Acked-by: Andrew Davis <afd@ti.com>

OK thanks applying into omap-for-v6.8/dt.

Tony
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/ti/omap/Makefile b/arch/arm/boot/dts/ti/omap/Makefile
index d2b590004fed..d6ee4a247100 100644
--- a/arch/arm/boot/dts/ti/omap/Makefile
+++ b/arch/arm/boot/dts/ti/omap/Makefile
@@ -129,6 +129,16 @@  dtb-$(CONFIG_SOC_AM43XX) += \
 am57xx-evm-dtbs := am57xx-beagle-x15.dtb am57xx-evm.dtbo
 am57xx-evm-reva3-dtbs := am57xx-beagle-x15-revc.dtb am57xx-evm.dtbo
 
+am571x-idk-overlays-dtbs := am571x-idk.dtb \
+	am571x-idk-touchscreen.dtbo am57xx-idk-lcd-osd101t2587.dtbo
+am572x-idk-overlays-dtbs := am572x-idk.dtb \
+	am572x-idk-touchscreen.dtbo am57xx-idk-lcd-osd101t2045.dtbo
+
+# Build time test only, enabled by CONFIG_OF_ALL_DTBS
+dtb- += \
+	am571x-idk-overlays.dtb \
+	am572x-idk-overlays.dtb
+
 dtb-$(CONFIG_SOC_DRA7XX) += \
 	am57xx-beagle-x15.dtb \
 	am57xx-beagle-x15-revb1.dtb \