Message ID | 20240416102348.614-1-avri.altman@wdc.com |
---|---|
Headers | show |
Series | simplify ufshcd with the guard() macro | expand |
On 4/16/24 03:23, Avri Altman wrote:
> +#define SERIALIZE_HOST_IRQSAVE(hba) guard(spinlock_irqsave)(hba->host->host_lock)
Something I have brought up before: what does the host lock protect in
the UFS driver? Rather than reworking the code that acquires and
releases the host lock, all uses of the host lock should be eliminated
from the UFS driver. The host lock should be replaced with new locks of
which it is clearly documented what member variables these new locks
protect.
Thanks,
Bart.
> Something I have brought up before: what does the host lock protect in the UFS > driver? Rather than reworking the code that acquires and releases the host lock, > all uses of the host lock should be eliminated from the UFS driver. The host lock > should be replaced with new locks of which it is clearly documented what > member variables these new locks protect. Then either this series is pre-mature and needs to be dropped for now, Or the changes you are planning can take place regardless? Thanks, Avri > > Thanks, > > Bart.