[1/5] bindings: regulator: added support for suspend states

Message ID 1513837506-26543-2-git-send-email-zhang.chunyan@linaro.org
State New
Headers show
Series
  • Add regulator suspend and resume support
Related show

Commit Message

Chunyan Zhang Dec. 21, 2017, 6:25 a.m.
Documented a few new added properties which are used for supporting
regulator suspend states.

Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>

---
 Documentation/devicetree/bindings/regulator/regulator.txt | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Rob Herring Dec. 21, 2017, 11:26 p.m. | #1
On Thu, Dec 21, 2017 at 02:25:02PM +0800, Chunyan Zhang wrote:
> Documented a few new added properties which are used for supporting

> regulator suspend states.


Your commit message should answer why you need this. What problem do you 
have that this solves?

> 

> Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>

> ---

>  Documentation/devicetree/bindings/regulator/regulator.txt | 11 +++++++++--

>  1 file changed, 9 insertions(+), 2 deletions(-)

> 

> diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt

> index 378f6dc..618a322 100644

> --- a/Documentation/devicetree/bindings/regulator/regulator.txt

> +++ b/Documentation/devicetree/bindings/regulator/regulator.txt

> @@ -42,8 +42,15 @@ Optional properties:

>  - regulator-state-[mem/disk] node has following common properties:

>  	- regulator-on-in-suspend: regulator should be on in suspend state.

>  	- regulator-off-in-suspend: regulator should be off in suspend state.

> -	- regulator-suspend-microvolt: regulator should be set to this voltage

> -	  in suspend.

> +	- regulator-suspend-min-microvolt: minimum voltage may be set in

> +	  suspend state.

> +	- regulator-suspend-max-microvolt: maximum voltage may be set in

> +	  suspend state.

> +	- regulator-suspend-microvolt: the default voltage which regulator

> +	  should be set in suspend, this can be adjusted among

> +	  <regulator-suspend-min-microvolt, regulator-suspend-max-microvolt>


Perhaps this should stay a single property with: <target> <min> <max>

Though why would you ever not try to set to the minimum voltage within 
the range of <min> to <max>?

> +	- regulator-changeable-in-suspend: whether the default voltage and

> +	  the regulator on/off in suspend can be changed in runtime.

>  	- regulator-mode: operating mode in the given suspend state.

>  	  The set of possible operating modes depends on the capabilities of

>  	  every hardware so the valid modes are documented on each regulator

> -- 

> 2.7.4

> 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Chunyan Zhang Dec. 22, 2017, 6:05 a.m. | #2
Hi Rob,

On 22 December 2017 at 07:26, Rob Herring <robh@kernel.org> wrote:
> On Thu, Dec 21, 2017 at 02:25:02PM +0800, Chunyan Zhang wrote:

>> Documented a few new added properties which are used for supporting

>> regulator suspend states.

>

> Your commit message should answer why you need this. What problem do you

> have that this solves?

>

>>

>> Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>

>> ---

>>  Documentation/devicetree/bindings/regulator/regulator.txt | 11 +++++++++--

>>  1 file changed, 9 insertions(+), 2 deletions(-)

>>

>> diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt

>> index 378f6dc..618a322 100644

>> --- a/Documentation/devicetree/bindings/regulator/regulator.txt

>> +++ b/Documentation/devicetree/bindings/regulator/regulator.txt

>> @@ -42,8 +42,15 @@ Optional properties:

>>  - regulator-state-[mem/disk] node has following common properties:

>>       - regulator-on-in-suspend: regulator should be on in suspend state.

>>       - regulator-off-in-suspend: regulator should be off in suspend state.

>> -     - regulator-suspend-microvolt: regulator should be set to this voltage

>> -       in suspend.

>> +     - regulator-suspend-min-microvolt: minimum voltage may be set in

>> +       suspend state.

>> +     - regulator-suspend-max-microvolt: maximum voltage may be set in

>> +       suspend state.

>> +     - regulator-suspend-microvolt: the default voltage which regulator

>> +       should be set in suspend, this can be adjusted among

>> +       <regulator-suspend-min-microvolt, regulator-suspend-max-microvolt>

>

> Perhaps this should stay a single property with: <target> <min> <max>


Do you mean that change the property name from "regulator-suspend-microvolt" to
"regulator-suspend-target-microvolt"?

"regulator-suspend-microvolt" is the one that some SoC is using. My
intention was just to keep that configuration still working.

> Though why would you ever not try to set to the minimum voltage within

> the range of <min> to <max>?


IIUC, you mean just removing "regulator-suspend-microvolt", and use
"regulator-suspend-min-microvolt" as the default value for suspend
voltage?
I think that can work, but would it be better to not remove that right
now, since some one is using that?

Thanks for your review!

Chunyan

>

>> +     - regulator-changeable-in-suspend: whether the default voltage and

>> +       the regulator on/off in suspend can be changed in runtime.

>>       - regulator-mode: operating mode in the given suspend state.

>>         The set of possible operating modes depends on the capabilities of

>>         every hardware so the valid modes are documented on each regulator

>> --

>> 2.7.4

>>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt
index 378f6dc..618a322 100644
--- a/Documentation/devicetree/bindings/regulator/regulator.txt
+++ b/Documentation/devicetree/bindings/regulator/regulator.txt
@@ -42,8 +42,15 @@  Optional properties:
 - regulator-state-[mem/disk] node has following common properties:
 	- regulator-on-in-suspend: regulator should be on in suspend state.
 	- regulator-off-in-suspend: regulator should be off in suspend state.
-	- regulator-suspend-microvolt: regulator should be set to this voltage
-	  in suspend.
+	- regulator-suspend-min-microvolt: minimum voltage may be set in
+	  suspend state.
+	- regulator-suspend-max-microvolt: maximum voltage may be set in
+	  suspend state.
+	- regulator-suspend-microvolt: the default voltage which regulator
+	  should be set in suspend, this can be adjusted among
+	  <regulator-suspend-min-microvolt, regulator-suspend-max-microvolt>
+	- regulator-changeable-in-suspend: whether the default voltage and
+	  the regulator on/off in suspend can be changed in runtime.
 	- regulator-mode: operating mode in the given suspend state.
 	  The set of possible operating modes depends on the capabilities of
 	  every hardware so the valid modes are documented on each regulator