perf tools: Add proper header file for symbols

Message ID 20190208223543.31836-1-mathieu.poirier@linaro.org
State New
Headers show
Series
  • perf tools: Add proper header file for symbols
Related show

Commit Message

Mathieu Poirier Feb. 8, 2019, 10:35 p.m.
After 'commit e22c1c751140 ("perf thread: Don't include symbol.h,
symbol_conf.h is enough")'

Compilation of the perf tools is broken when using the functionality
provided by the openCSD library:

[...]

...                       timerfd: [ on  ]
...                  sched_getcpu: [ on  ]
...                           sdt: [ OFF ]
...                         setns: [ on  ]
...                    libopencsd: [ on  ]

[...]

  CC       util/arm-spe.o
  CC       util/arm-spe-pkt-decoder.o
  CC       util/s390-cpumsf.o
  CC       util/cs-etm.o
  CC       util/parse-branch-options.o
util/cs-etm.c: In function ‘cs_etm__mem_access’:
util/cs-etm.c:297:24: error: storage size of ‘al’ isn’t known
  struct  addr_location al;

And rightly so since file cs-etm.c doesn't include symbol.h, something
that is rectified in this patch.

Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>

---
 tools/perf/util/cs-etm.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.17.1

Comments

Arnaldo Carvalho de Melo Feb. 11, 2019, 11:46 a.m. | #1
Em Fri, Feb 08, 2019 at 03:35:43PM -0700, Mathieu Poirier escreveu:
> After 'commit e22c1c751140 ("perf thread: Don't include symbol.h,

> symbol_conf.h is enough")'

> 

> Compilation of the perf tools is broken when using the functionality

> provided by the openCSD library:

> 

> [...]

> 

> ...                       timerfd: [ on  ]

> ...                  sched_getcpu: [ on  ]

> ...                           sdt: [ OFF ]

> ...                         setns: [ on  ]

> ...                    libopencsd: [ on  ]

> 

> [...]

> 

>   CC       util/arm-spe.o

>   CC       util/arm-spe-pkt-decoder.o

>   CC       util/s390-cpumsf.o

>   CC       util/cs-etm.o

>   CC       util/parse-branch-options.o

> util/cs-etm.c: In function ‘cs_etm__mem_access’:

> util/cs-etm.c:297:24: error: storage size of ‘al’ isn’t known

>   struct  addr_location al;

> 

> And rightly so since file cs-etm.c doesn't include symbol.h, something

> that is rectified in this patch.


Thanks, I'll make sure the openCSD library is present in one of my
containers doing arm64 cross builds so that this gets caught in the
future.

- Arnaldo
 
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>

> ---

>  tools/perf/util/cs-etm.c | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c

> index 8b3f882d6e2f..0b11d653cfbe 100644

> --- a/tools/perf/util/cs-etm.c

> +++ b/tools/perf/util/cs-etm.c

> @@ -25,6 +25,7 @@

>  #include "machine.h"

>  #include "map.h"

>  #include "perf.h"

> +#include "symbol.h"

>  #include "thread.h"

>  #include "thread_map.h"

>  #include "thread-stack.h"

> -- 

> 2.17.1


-- 

- Arnaldo

Patch

diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c
index 8b3f882d6e2f..0b11d653cfbe 100644
--- a/tools/perf/util/cs-etm.c
+++ b/tools/perf/util/cs-etm.c
@@ -25,6 +25,7 @@ 
 #include "machine.h"
 #include "map.h"
 #include "perf.h"
+#include "symbol.h"
 #include "thread.h"
 #include "thread_map.h"
 #include "thread-stack.h"