diff mbox series

[PATCH-next,02/20] gpio: gpio-omap: fix lack of irqstatus_raw0 for OMAP4

Message ID 20190610171103.30903-3-grygorii.strashko@ti.com
State New
Headers show
Series [PATCH-next,01/20] gpio: gpio-omap: ensure irq is enabled before wakeup | expand

Commit Message

Grygorii Strashko June 10, 2019, 5:10 p.m. UTC 
From: Russell King <rmk+kernel@armlinux.org.uk>


Commit 384ebe1c2849 ("gpio/omap: Add DT support to GPIO driver") added
the register definition tables to the gpio-omap driver. Subsequently to
that commit, commit 4e962e8998cc ("gpio/omap: remove cpu_is_omapxxxx()
checks from *_runtime_resume()") added definitions for irqstatus_raw*
registers to the legacy OMAP4 definitions, but missed the DT
definitions.

This causes an unintentional change of behaviour for the 1.101 errata
workaround on OMAP4 platforms. Fix this oversight.

Fixes: 4e962e8998cc ("gpio/omap: remove cpu_is_omapxxxx() checks from *_runtime_resume()")
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>

---
 drivers/gpio/gpio-omap.c | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.17.1

Comments

Linus Walleij June 12, 2019, 7:55 a.m. UTC | #1 
On Mon, Jun 10, 2019 at 7:11 PM Grygorii Strashko
<grygorii.strashko@ti.com> wrote:

> From: Russell King <rmk+kernel@armlinux.org.uk>

>

> Commit 384ebe1c2849 ("gpio/omap: Add DT support to GPIO driver") added

> the register definition tables to the gpio-omap driver. Subsequently to

> that commit, commit 4e962e8998cc ("gpio/omap: remove cpu_is_omapxxxx()

> checks from *_runtime_resume()") added definitions for irqstatus_raw*

> registers to the legacy OMAP4 definitions, but missed the DT

> definitions.

>

> This causes an unintentional change of behaviour for the 1.101 errata

> workaround on OMAP4 platforms. Fix this oversight.

>

> Fixes: 4e962e8998cc ("gpio/omap: remove cpu_is_omapxxxx() checks from *_runtime_resume()")

> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>


Patch applied.

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index 2c6d46396834..44b214e5cefb 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -1457,6 +1457,8 @@  static struct omap_gpio_reg_offs omap4_gpio_regs = {
 	.clr_dataout =		OMAP4_GPIO_CLEARDATAOUT,
 	.irqstatus =		OMAP4_GPIO_IRQSTATUS0,
 	.irqstatus2 =		OMAP4_GPIO_IRQSTATUS1,
+	.irqstatus_raw0 =	OMAP4_GPIO_IRQSTATUSRAW0,
+	.irqstatus_raw1 =	OMAP4_GPIO_IRQSTATUSRAW1,
 	.irqenable =		OMAP4_GPIO_IRQSTATUSSET0,
 	.irqenable2 =		OMAP4_GPIO_IRQSTATUSSET1,
 	.set_irqenable =	OMAP4_GPIO_IRQSTATUSSET0,