[RFC,2/2] USB: OHCI: add a name for the platform-private field

Message ID 1369907454-11003-3-git-send-email-manjunath.goudar@linaro.org
State Superseded
Headers show

Commit Message

manjunath.goudar@linaro.org May 30, 2013, 9:50 a.m.
This patch adds an ohci->priv field for private use by OHCI
platform drivers.

Until now none of the platform drivers has used this private space,
but that's about to change in the next patch of this series.

Signed-off-by: Manjunath Goudar <manjunath.goudar@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Greg KH <greg@kroah.com>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: linux-usb@vger.kernel.org
---
 drivers/usb/host/ohci.h |    3 +++
 1 file changed, 3 insertions(+)

Comments

Alan Stern May 30, 2013, 5:26 p.m. | #1
On Thu, 30 May 2013, Manjunath Goudar wrote:

> This patch adds an ohci->priv field for private use by OHCI
> platform drivers.
> 
> Until now none of the platform drivers has used this private space,
> but that's about to change in the next patch of this series.

As far as I'm concerned, this doesn't need to be in a patch of its own.  
It can be merged into the 1/3 patch of the previous series.  After all,
that patch adds the extra_priv_size field in ohci_driver_overrides,
which doesn't make much sense unless there's a way to refer to the
private part of the ohci_hcd structure.

Alan Stern
manjunath.goudar@linaro.org May 31, 2013, 9:53 a.m. | #2
On 30 May 2013 22:56, Alan Stern <stern@rowland.harvard.edu> wrote:

> On Thu, 30 May 2013, Manjunath Goudar wrote:
>
> > This patch adds an ohci->priv field for private use by OHCI
> > platform drivers.
> >
> > Until now none of the platform drivers has used this private space,
> > but that's about to change in the next patch of this series.
>
> As far as I'm concerned, this doesn't need to be in a patch of its own.
> It can be merged into the 1/3 patch of the previous series.  After all,
> that patch adds the extra_priv_size field in ohci_driver_overrides,
> which doesn't make much sense unless there's a way to refer to the
> private part of the ohci_hcd structure



 Already 1/3 patch is merged into main line kernel.

Two days back only I started making ohci-spera a separate driver ,that time
I felt extra_priv_size field is required in ohci_driver_overrides that what
I created separate patch.

extra_priv_size patch is related to Spear patch,If you are agree,I can add
this patch with Spear patch,making Spear patch series.

If any other suggestion let me know.

Manjunath Goudar


> Alan Stern
>
>
>
Alan Stern May 31, 2013, 2:05 p.m. | #3
On Fri, 31 May 2013, Manjunath Goudar wrote:

> On 30 May 2013 22:56, Alan Stern <stern@rowland.harvard.edu> wrote:
> 
> > On Thu, 30 May 2013, Manjunath Goudar wrote:
> >
> > > This patch adds an ohci->priv field for private use by OHCI
> > > platform drivers.
> > >
> > > Until now none of the platform drivers has used this private space,
> > > but that's about to change in the next patch of this series.
> >
> > As far as I'm concerned, this doesn't need to be in a patch of its own.
> > It can be merged into the 1/3 patch of the previous series.  After all,
> > that patch adds the extra_priv_size field in ohci_driver_overrides,
> > which doesn't make much sense unless there's a way to refer to the
> > private part of the ohci_hcd structure
> 
> 
> 
>  Already 1/3 patch is merged into main line kernel.

Yeah, too late now.

> Two days back only I started making ohci-spera a separate driver ,that time
> I felt extra_priv_size field is required in ohci_driver_overrides that what
> I created separate patch.
> 
> extra_priv_size patch is related to Spear patch,If you are agree,I can add
> this patch with Spear patch,making Spear patch series.

No, we may as well keep it separate like this.

Alan Stern

Patch

diff --git a/drivers/usb/host/ohci.h b/drivers/usb/host/ohci.h
index 3b58482..e2e5faa 100644
--- a/drivers/usb/host/ohci.h
+++ b/drivers/usb/host/ohci.h
@@ -421,6 +421,9 @@  struct ohci_hcd {
 	struct dentry		*debug_periodic;
 	struct dentry		*debug_registers;
 #endif
+	/* platform-specific data -- must come last */
+	unsigned long           priv[0] __aligned(sizeof(s64));
+
 };
 
 #ifdef CONFIG_PCI