[v2,3/4] ARM: dts: sun8i: a83t: Correct USB3503 GPIOs polarity

Message ID 20191211145217.25025-1-m.szyprowski@samsung.com
State Accepted
Commit 1c226017d3ec93547b58082bdf778d9db7401c95
Headers show
Series
  • [v2,1/4] ARM: dts: exynos: Correct USB3503 GPIOs polarity
Related show

Commit Message

Marek Szyprowski Dec. 11, 2019, 2:52 p.m.
Current USB3503 driver ignores GPIO polarity and always operates as if the
GPIO lines were flagged as ACTIVE_HIGH. Fix the polarity for the existing
USB3503 chip applications to match the chip specification and common
convention for naming the pins. The only pin, which has to be ACTIVE_LOW
is the reset pin. The remaining are ACTIVE_HIGH. This change allows later
to fix the USB3503 driver to properly use generic GPIO bindings and read
polarity from DT.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

---
 arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.1

Comments

Chen-Yu Tsai Dec. 13, 2019, 8:08 a.m. | #1
On Wed, Dec 11, 2019 at 10:52 PM Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
>

> Current USB3503 driver ignores GPIO polarity and always operates as if the

> GPIO lines were flagged as ACTIVE_HIGH. Fix the polarity for the existing

> USB3503 chip applications to match the chip specification and common

> convention for naming the pins. The only pin, which has to be ACTIVE_LOW

> is the reset pin. The remaining are ACTIVE_HIGH. This change allows later

> to fix the USB3503 driver to properly use generic GPIO bindings and read

> polarity from DT.

>

> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>


Acked-by: Chen-Yu Tsai <wens@csie.org>


I assume the dts patch has to go in before or at the same time as the driver
patch?

Patch

diff --git a/arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts b/arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts
index fb928503ad45..d9be511f054f 100644
--- a/arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts
+++ b/arch/arm/boot/dts/sun8i-a83t-cubietruck-plus.dts
@@ -101,7 +101,7 @@ 
 		initial-mode = <1>; /* initialize in HUB mode */
 		disabled-ports = <1>;
 		intn-gpios = <&pio 7 5 GPIO_ACTIVE_HIGH>; /* PH5 */
-		reset-gpios = <&pio 4 16 GPIO_ACTIVE_HIGH>; /* PE16 */
+		reset-gpios = <&pio 4 16 GPIO_ACTIVE_LOW>; /* PE16 */
 		connect-gpios = <&pio 4 17 GPIO_ACTIVE_HIGH>; /* PE17 */
 		refclk-frequency = <19200000>;
 	};