[26/32] usb: early: xhci-dbc: Supply missing 'xhci-dbgp.h' headerfile

Message ID 20200706133341.476881-27-lee.jones@linaro.org
State New
Headers show
Series
  • Fix the final bunch of W=1 issues in USB
Related show

Commit Message

Lee Jones July 6, 2020, 1:33 p.m.
If the header file containing a function's prototype isn't included by
the sourcefile containing the associated function, the build system
complains of missing prototypes.

Fixes the following W=1 kernel build warning(s):

 drivers/usb/early/ehci-dbgp.c: In function ‘early_dbgp_write’:
 drivers/usb/early/ehci-dbgp.c:915:13: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
 915 | int chunk, ret;
 | ^~~
 drivers/usb/early/xhci-dbc.c:600:12: warning: no previous prototype for ‘early_xdbc_parse_parameter’ [-Wmissing-prototypes]
 600 | int __init early_xdbc_parse_parameter(char *s)
 | ^~~~~~~~~~~~~~~~~~~~~~~~~~
 drivers/usb/early/xhci-dbc.c:653:12: warning: no previous prototype for ‘early_xdbc_setup_hardware’ [-Wmissing-prototypes]
 653 | int __init early_xdbc_setup_hardware(void)
 | ^~~~~~~~~~~~~~~~~~~~~~~~~
 drivers/usb/early/xhci-dbc.c:910:13: warning: no previous prototype for ‘early_xdbc_register_console’ [-Wmissing-prototypes]
 910 | void __init early_xdbc_register_console(void)
 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~

Cc: Jann Horn <jannh@google.com>
Cc: Lu Baolu <baolu.lu@linux.intel.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/usb/early/xhci-dbc.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.25.1

Comments

Jann Horn July 6, 2020, 1:50 p.m. | #1
On Mon, Jul 6, 2020 at 3:34 PM Lee Jones <lee.jones@linaro.org> wrote:
> If the header file containing a function's prototype isn't included by

> the sourcefile containing the associated function, the build system

> complains of missing prototypes.

>

> Fixes the following W=1 kernel build warning(s):

>

>  drivers/usb/early/ehci-dbgp.c: In function ‘early_dbgp_write’:

>  drivers/usb/early/ehci-dbgp.c:915:13: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]

>  915 | int chunk, ret;

>  | ^~~

>  drivers/usb/early/xhci-dbc.c:600:12: warning: no previous prototype for ‘early_xdbc_parse_parameter’ [-Wmissing-prototypes]

>  600 | int __init early_xdbc_parse_parameter(char *s)

>  | ^~~~~~~~~~~~~~~~~~~~~~~~~~

>  drivers/usb/early/xhci-dbc.c:653:12: warning: no previous prototype for ‘early_xdbc_setup_hardware’ [-Wmissing-prototypes]

>  653 | int __init early_xdbc_setup_hardware(void)

>  | ^~~~~~~~~~~~~~~~~~~~~~~~~

>  drivers/usb/early/xhci-dbc.c:910:13: warning: no previous prototype for ‘early_xdbc_register_console’ [-Wmissing-prototypes]

>  910 | void __init early_xdbc_register_console(void)

>  | ^~~~~~~~~~~~~~~~~~~~~~~~~~~

>

> Cc: Jann Horn <jannh@google.com>

> Cc: Lu Baolu <baolu.lu@linux.intel.com>

> Signed-off-by: Lee Jones <lee.jones@linaro.org>


Reviewed-by: Jann Horn <jannh@google.com>

Patch

diff --git a/drivers/usb/early/xhci-dbc.c b/drivers/usb/early/xhci-dbc.c
index 04ba11fff0edc..a9932c1ff20f7 100644
--- a/drivers/usb/early/xhci-dbc.c
+++ b/drivers/usb/early/xhci-dbc.c
@@ -21,6 +21,7 @@ 
 #include <linux/module.h>
 #include <linux/delay.h>
 #include <linux/kthread.h>
+#include <linux/usb/xhci-dbgp.h>
 
 #include "../host/xhci.h"
 #include "xhci-dbc.h"