[1/4] usb: chipidea: switch over to endpoint feature flags

Message ID 1393954366-22987-1-git-send-email-balbi@ti.com
State New
Headers show

Commit Message

Felipe Balbi March 4, 2014, 5:32 p.m.
switch over to endpoint feature flags so we can
drop naming conventions.

Signed-off-by: Felipe Balbi <balbi@ti.com>
---
 drivers/usb/chipidea/udc.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Peter Chen March 6, 2014, 8:55 a.m. | #1
> switch over to endpoint feature flags so we can drop naming conventions.
> 
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
>  drivers/usb/chipidea/udc.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
> index 80de2f8..e80dc82 100644
> --- a/drivers/usb/chipidea/udc.c
> +++ b/drivers/usb/chipidea/udc.c
> @@ -1576,6 +1576,13 @@ static int init_eps(struct ci_hdrc *ci)
> 
>  			hwep->ep.name      = hwep->name;
>  			hwep->ep.ops       = &usb_ep_ops;
> +
> +			hwep->ep.has_bulk = true;
> +			hwep->ep.has_interrupt = true;
> +			hwep->ep.has_isochronous = true;
> +			hwep->ep.has_dir_in = (j == TX);
> +			hwep->ep.has_dir_out = (j == RX);
> +
>  			/*

I find your "usb: gadget: ep: add feature flags" is at Linux-next,
but not at greg's usb-next, does it need for 3.15?

Peter

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Felipe Balbi March 6, 2014, 3:54 p.m. | #2
On Thu, Mar 06, 2014 at 08:55:55AM +0000, Peter Chen wrote:
> 
> 
>  
> > switch over to endpoint feature flags so we can drop naming conventions.
> > 
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > ---
> >  drivers/usb/chipidea/udc.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
> > index 80de2f8..e80dc82 100644
> > --- a/drivers/usb/chipidea/udc.c
> > +++ b/drivers/usb/chipidea/udc.c
> > @@ -1576,6 +1576,13 @@ static int init_eps(struct ci_hdrc *ci)
> > 
> >  			hwep->ep.name      = hwep->name;
> >  			hwep->ep.ops       = &usb_ep_ops;
> > +
> > +			hwep->ep.has_bulk = true;
> > +			hwep->ep.has_interrupt = true;
> > +			hwep->ep.has_isochronous = true;
> > +			hwep->ep.has_dir_in = (j == TX);
> > +			hwep->ep.has_dir_out = (j == RX);
> > +
> >  			/*
> 
> I find your "usb: gadget: ep: add feature flags" is at Linux-next,
> but not at greg's usb-next, does it need for 3.15?

I dropped it from v3.15, will send it for v3.16

Patch

diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
index 80de2f8..e80dc82 100644
--- a/drivers/usb/chipidea/udc.c
+++ b/drivers/usb/chipidea/udc.c
@@ -1576,6 +1576,13 @@  static int init_eps(struct ci_hdrc *ci)
 
 			hwep->ep.name      = hwep->name;
 			hwep->ep.ops       = &usb_ep_ops;
+
+			hwep->ep.has_bulk = true;
+			hwep->ep.has_interrupt = true;
+			hwep->ep.has_isochronous = true;
+			hwep->ep.has_dir_in = (j == TX);
+			hwep->ep.has_dir_out = (j == RX);
+
 			/*
 			 * for ep0: maxP defined in desc, for other
 			 * eps, maxP is set by epautoconfig() called