| Message ID | 1597923046-12535-1-git-send-email-chunfeng.yun@mediatek.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,01/11] usb: gadget: bdc: fix improper SPDX comment style for header file | expand |
On 8/20/2020 4:30 AM, Chunfeng Yun wrote: > No definition for bdc_ep_set_halt(), so remove it. > > Cc: Florian Fainelli <f.fainelli@gmail.com> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
On 8/20/2020 4:30 AM, Chunfeng Yun wrote: > Use '"%s...", __func__' to replace embedded function name > > Cc: Florian Fainelli <f.fainelli@gmail.com> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
On 8/20/2020 4:30 AM, Chunfeng Yun wrote: > This is used to avoid the warning of function arguments, e.g. > WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' > should also have an identifier name > > Cc: Florian Fainelli <f.fainelli@gmail.com> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
On 8/20/2020 4:30 AM, Chunfeng Yun wrote: > Prefer using the BIT macro to define bit fileds > > Cc: Florian Fainelli <f.fainelli@gmail.com> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
On 8/20/2020 4:30 AM, Chunfeng Yun wrote: > fix checkpatch.pl error: > ERROR:SPACING: space prohibited before that ',' > > Cc: Florian Fainelli <f.fainelli@gmail.com> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
On 9/3/2020 8:17 PM, Chunfeng Yun wrote: > Hi Florian, > > On Thu, 2020-08-20 at 19:30 +0800, Chunfeng Yun wrote: >> For C header files Documentation/process/license-rules.rst >> mandates C-like comments (opposed to C source files where >> C++ style should be used). >> >> Cc: Florian Fainelli <f.fainelli@gmail.com> >> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> >> --- [snip] > Would you please take a look at this series? > I'll drop the patches that not fine with you. It all looks good to me, thanks and sorry for not responding earlier.
diff --git a/drivers/usb/gadget/udc/bdc/bdc.h b/drivers/usb/gadget/udc/bdc/bdc.h index ac75e25..fcba77e 100644 --- a/drivers/usb/gadget/udc/bdc/bdc.h +++ b/drivers/usb/gadget/udc/bdc/bdc.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * bdc.h - header for the BRCM BDC USB3.0 device controller * diff --git a/drivers/usb/gadget/udc/bdc/bdc_cmd.h b/drivers/usb/gadget/udc/bdc/bdc_cmd.h index 29cc988..373e674 100644 --- a/drivers/usb/gadget/udc/bdc/bdc_cmd.h +++ b/drivers/usb/gadget/udc/bdc/bdc_cmd.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * bdc_cmd.h - header for the BDC debug functions * diff --git a/drivers/usb/gadget/udc/bdc/bdc_dbg.h b/drivers/usb/gadget/udc/bdc/bdc_dbg.h index 373d5ab..859d588 100644 --- a/drivers/usb/gadget/udc/bdc/bdc_dbg.h +++ b/drivers/usb/gadget/udc/bdc/bdc_dbg.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * bdc_dbg.h - header for the BDC debug functions * diff --git a/drivers/usb/gadget/udc/bdc/bdc_ep.h b/drivers/usb/gadget/udc/bdc/bdc_ep.h index a37ff803..5bbd73f 100644 --- a/drivers/usb/gadget/udc/bdc/bdc_ep.h +++ b/drivers/usb/gadget/udc/bdc/bdc_ep.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0+ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * bdc_ep.h - header for the BDC debug functions *
For C header files Documentation/process/license-rules.rst mandates C-like comments (opposed to C source files where C++ style should be used). Cc: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- v2: add Cc Florian --- drivers/usb/gadget/udc/bdc/bdc.h | 2 +- drivers/usb/gadget/udc/bdc/bdc_cmd.h | 2 +- drivers/usb/gadget/udc/bdc/bdc_dbg.h | 2 +- drivers/usb/gadget/udc/bdc/bdc_ep.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) -- 1.9.1