| Message ID | 20201023214328.1262883-1-pmalani@chromium.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3,1/2] usb: typec: Consolidate syfs ABI documentation | expand |
On Fri, Oct 23, 2020 at 02:43:26PM -0700, Prashant Malani wrote: > Both partner and cable have identity VDOs. These are listed separately > in the Documentation/ABI/testing/sysfs-class-typec. Factor these out > into a common location to avoid the duplication. > > Signed-off-by: Prashant Malani <pmalani@chromium.org> I don't have a problem with this change. FWIW: Acked-by: Heikki Krogerus <heikki.krogeurus@linux.intel.com> > --- > > Patch first introduced in v3. > > Documentation/ABI/testing/sysfs-class-typec | 59 ++++++--------------- > 1 file changed, 17 insertions(+), 42 deletions(-) > > diff --git a/Documentation/ABI/testing/sysfs-class-typec b/Documentation/ABI/testing/sysfs-class-typec > index b834671522d6..0f839fd022f1 100644 > --- a/Documentation/ABI/testing/sysfs-class-typec > +++ b/Documentation/ABI/testing/sysfs-class-typec > @@ -134,42 +134,6 @@ Description: > Shows if the partner supports USB Power Delivery communication: > Valid values: yes, no > > -What: /sys/class/typec/<port>-partner>/identity/ > -Date: April 2017 > -Contact: Heikki Krogerus <heikki.krogerus@linux.intel.com> > -Description: > - This directory appears only if the port device driver is capable > - of showing the result of Discover Identity USB power delivery > - command. That will not always be possible even when USB power > - delivery is supported, for example when USB power delivery > - communication for the port is mostly handled in firmware. If the > - directory exists, it will have an attribute file for every VDO > - in Discover Identity command result. > - > -What: /sys/class/typec/<port>-partner/identity/id_header > -Date: April 2017 > -Contact: Heikki Krogerus <heikki.krogerus@linux.intel.com> > -Description: > - ID Header VDO part of Discover Identity command result. The > - value will show 0 until Discover Identity command result becomes > - available. The value can be polled. > - > -What: /sys/class/typec/<port>-partner/identity/cert_stat > -Date: April 2017 > -Contact: Heikki Krogerus <heikki.krogerus@linux.intel.com> > -Description: > - Cert Stat VDO part of Discover Identity command result. The > - value will show 0 until Discover Identity command result becomes > - available. The value can be polled. > - > -What: /sys/class/typec/<port>-partner/identity/product > -Date: April 2017 > -Contact: Heikki Krogerus <heikki.krogerus@linux.intel.com> > -Description: > - Product VDO part of Discover Identity command result. The value > - will show 0 until Discover Identity command result becomes > - available. The value can be polled. > - > > USB Type-C cable devices (eg. /sys/class/typec/port0-cable/) > > @@ -196,17 +160,28 @@ Description: > - type-c > - captive > > -What: /sys/class/typec/<port>-cable/identity/ > + > +USB Type-C partner/cable Power Delivery Identity objects > + > +NOTE: The following attributes will be applicable to both > +partner (e.g /sys/class/typec/port0-partner/) and > +cable (e.g /sys/class/typec/port0-cable/) devices. Consequently, the example file > +paths below are prefixed with "/sys/class/typec/<port>-{partner|cable}/" to > +reflect this. > + > +What: /sys/class/typec/<port>-{partner|cable}/identity/ > Date: April 2017 > Contact: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Description: > This directory appears only if the port device driver is capable > of showing the result of Discover Identity USB power delivery > command. That will not always be possible even when USB power > - delivery is supported. If the directory exists, it will have an > - attribute for every VDO returned by Discover Identity command. > + delivery is supported, for example when USB power delivery > + communication for the port is mostly handled in firmware. If the > + directory exists, it will have an attribute file for every VDO > + in Discover Identity command result. > > -What: /sys/class/typec/<port>-cable/identity/id_header > +What: /sys/class/typec/<port>-{partner|cable}/identity/id_header > Date: April 2017 > Contact: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Description: > @@ -214,7 +189,7 @@ Description: > value will show 0 until Discover Identity command result becomes > available. The value can be polled. > > -What: /sys/class/typec/<port>-cable/identity/cert_stat > +What: /sys/class/typec/<port>-{partner|cable}/identity/cert_stat > Date: April 2017 > Contact: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Description: > @@ -222,7 +197,7 @@ Description: > value will show 0 until Discover Identity command result becomes > available. The value can be polled. > > -What: /sys/class/typec/<port>-cable/identity/product > +What: /sys/class/typec/<port>-{partner|cable}/identity/product > Date: April 2017 > Contact: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Description: > -- > 2.29.0.rc1.297.gfa9743e501-goog thanks, -- heikki
On Fri, Oct 23, 2020 at 02:43:26PM -0700, Prashant Malani wrote: > Both partner and cable have identity VDOs. These are listed separately > in the Documentation/ABI/testing/sysfs-class-typec. Factor these out > into a common location to avoid the duplication. This does not apply any more. Cany you resend these. thanks, > Signed-off-by: Prashant Malani <pmalani@chromium.org> > --- > > Patch first introduced in v3. > > Documentation/ABI/testing/sysfs-class-typec | 59 ++++++--------------- > 1 file changed, 17 insertions(+), 42 deletions(-) > > diff --git a/Documentation/ABI/testing/sysfs-class-typec b/Documentation/ABI/testing/sysfs-class-typec > index b834671522d6..0f839fd022f1 100644 > --- a/Documentation/ABI/testing/sysfs-class-typec > +++ b/Documentation/ABI/testing/sysfs-class-typec > @@ -134,42 +134,6 @@ Description: > Shows if the partner supports USB Power Delivery communication: > Valid values: yes, no > > -What: /sys/class/typec/<port>-partner>/identity/ > -Date: April 2017 > -Contact: Heikki Krogerus <heikki.krogerus@linux.intel.com> > -Description: > - This directory appears only if the port device driver is capable > - of showing the result of Discover Identity USB power delivery > - command. That will not always be possible even when USB power > - delivery is supported, for example when USB power delivery > - communication for the port is mostly handled in firmware. If the > - directory exists, it will have an attribute file for every VDO > - in Discover Identity command result. > - > -What: /sys/class/typec/<port>-partner/identity/id_header > -Date: April 2017 > -Contact: Heikki Krogerus <heikki.krogerus@linux.intel.com> > -Description: > - ID Header VDO part of Discover Identity command result. The > - value will show 0 until Discover Identity command result becomes > - available. The value can be polled. > - > -What: /sys/class/typec/<port>-partner/identity/cert_stat > -Date: April 2017 > -Contact: Heikki Krogerus <heikki.krogerus@linux.intel.com> > -Description: > - Cert Stat VDO part of Discover Identity command result. The > - value will show 0 until Discover Identity command result becomes > - available. The value can be polled. > - > -What: /sys/class/typec/<port>-partner/identity/product > -Date: April 2017 > -Contact: Heikki Krogerus <heikki.krogerus@linux.intel.com> > -Description: > - Product VDO part of Discover Identity command result. The value > - will show 0 until Discover Identity command result becomes > - available. The value can be polled. > - > > USB Type-C cable devices (eg. /sys/class/typec/port0-cable/) > > @@ -196,17 +160,28 @@ Description: > - type-c > - captive > > -What: /sys/class/typec/<port>-cable/identity/ > + > +USB Type-C partner/cable Power Delivery Identity objects > + > +NOTE: The following attributes will be applicable to both > +partner (e.g /sys/class/typec/port0-partner/) and > +cable (e.g /sys/class/typec/port0-cable/) devices. Consequently, the example file > +paths below are prefixed with "/sys/class/typec/<port>-{partner|cable}/" to > +reflect this. > + > +What: /sys/class/typec/<port>-{partner|cable}/identity/ > Date: April 2017 > Contact: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Description: > This directory appears only if the port device driver is capable > of showing the result of Discover Identity USB power delivery > command. That will not always be possible even when USB power > - delivery is supported. If the directory exists, it will have an > - attribute for every VDO returned by Discover Identity command. > + delivery is supported, for example when USB power delivery > + communication for the port is mostly handled in firmware. If the > + directory exists, it will have an attribute file for every VDO > + in Discover Identity command result. > > -What: /sys/class/typec/<port>-cable/identity/id_header > +What: /sys/class/typec/<port>-{partner|cable}/identity/id_header > Date: April 2017 > Contact: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Description: > @@ -214,7 +189,7 @@ Description: > value will show 0 until Discover Identity command result becomes > available. The value can be polled. > > -What: /sys/class/typec/<port>-cable/identity/cert_stat > +What: /sys/class/typec/<port>-{partner|cable}/identity/cert_stat > Date: April 2017 > Contact: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Description: > @@ -222,7 +197,7 @@ Description: > value will show 0 until Discover Identity command result becomes > available. The value can be polled. > > -What: /sys/class/typec/<port>-cable/identity/product > +What: /sys/class/typec/<port>-{partner|cable}/identity/product > Date: April 2017 > Contact: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Description: > -- > 2.29.0.rc1.297.gfa9743e501-goog -- heikki
Hi Heikki, On Tue, Nov 24, 2020 at 5:23 AM Heikki Krogerus <heikki.krogerus@linux.intel.com> wrote: > > On Fri, Oct 23, 2020 at 02:43:26PM -0700, Prashant Malani wrote: > > Both partner and cable have identity VDOs. These are listed separately > > in the Documentation/ABI/testing/sysfs-class-typec. Factor these out > > into a common location to avoid the duplication. > > This does not apply any more. Cany you resend these. Thanks for the heads up. Resent here [1] [1]: https://lore.kernel.org/linux-usb/20201124201033.592576-2-pmalani@chromium.org/ BR, -Prashant
diff --git a/Documentation/ABI/testing/sysfs-class-typec b/Documentation/ABI/testing/sysfs-class-typec index b834671522d6..0f839fd022f1 100644 --- a/Documentation/ABI/testing/sysfs-class-typec +++ b/Documentation/ABI/testing/sysfs-class-typec @@ -134,42 +134,6 @@ Description: Shows if the partner supports USB Power Delivery communication: Valid values: yes, no -What: /sys/class/typec/<port>-partner>/identity/ -Date: April 2017 -Contact: Heikki Krogerus <heikki.krogerus@linux.intel.com> -Description: - This directory appears only if the port device driver is capable - of showing the result of Discover Identity USB power delivery - command. That will not always be possible even when USB power - delivery is supported, for example when USB power delivery - communication for the port is mostly handled in firmware. If the - directory exists, it will have an attribute file for every VDO - in Discover Identity command result. - -What: /sys/class/typec/<port>-partner/identity/id_header -Date: April 2017 -Contact: Heikki Krogerus <heikki.krogerus@linux.intel.com> -Description: - ID Header VDO part of Discover Identity command result. The - value will show 0 until Discover Identity command result becomes - available. The value can be polled. - -What: /sys/class/typec/<port>-partner/identity/cert_stat -Date: April 2017 -Contact: Heikki Krogerus <heikki.krogerus@linux.intel.com> -Description: - Cert Stat VDO part of Discover Identity command result. The - value will show 0 until Discover Identity command result becomes - available. The value can be polled. - -What: /sys/class/typec/<port>-partner/identity/product -Date: April 2017 -Contact: Heikki Krogerus <heikki.krogerus@linux.intel.com> -Description: - Product VDO part of Discover Identity command result. The value - will show 0 until Discover Identity command result becomes - available. The value can be polled. - USB Type-C cable devices (eg. /sys/class/typec/port0-cable/) @@ -196,17 +160,28 @@ Description: - type-c - captive -What: /sys/class/typec/<port>-cable/identity/ + +USB Type-C partner/cable Power Delivery Identity objects + +NOTE: The following attributes will be applicable to both +partner (e.g /sys/class/typec/port0-partner/) and +cable (e.g /sys/class/typec/port0-cable/) devices. Consequently, the example file +paths below are prefixed with "/sys/class/typec/<port>-{partner|cable}/" to +reflect this. + +What: /sys/class/typec/<port>-{partner|cable}/identity/ Date: April 2017 Contact: Heikki Krogerus <heikki.krogerus@linux.intel.com> Description: This directory appears only if the port device driver is capable of showing the result of Discover Identity USB power delivery command. That will not always be possible even when USB power - delivery is supported. If the directory exists, it will have an - attribute for every VDO returned by Discover Identity command. + delivery is supported, for example when USB power delivery + communication for the port is mostly handled in firmware. If the + directory exists, it will have an attribute file for every VDO + in Discover Identity command result. -What: /sys/class/typec/<port>-cable/identity/id_header +What: /sys/class/typec/<port>-{partner|cable}/identity/id_header Date: April 2017 Contact: Heikki Krogerus <heikki.krogerus@linux.intel.com> Description: @@ -214,7 +189,7 @@ Description: value will show 0 until Discover Identity command result becomes available. The value can be polled. -What: /sys/class/typec/<port>-cable/identity/cert_stat +What: /sys/class/typec/<port>-{partner|cable}/identity/cert_stat Date: April 2017 Contact: Heikki Krogerus <heikki.krogerus@linux.intel.com> Description: @@ -222,7 +197,7 @@ Description: value will show 0 until Discover Identity command result becomes available. The value can be polled. -What: /sys/class/typec/<port>-cable/identity/product +What: /sys/class/typec/<port>-{partner|cable}/identity/product Date: April 2017 Contact: Heikki Krogerus <heikki.krogerus@linux.intel.com> Description:
Both partner and cable have identity VDOs. These are listed separately in the Documentation/ABI/testing/sysfs-class-typec. Factor these out into a common location to avoid the duplication. Signed-off-by: Prashant Malani <pmalani@chromium.org> --- Patch first introduced in v3. Documentation/ABI/testing/sysfs-class-typec | 59 ++++++--------------- 1 file changed, 17 insertions(+), 42 deletions(-)