diff mbox series

[1/1] usb: serial: option: add Quectel EC200T module support

Message ID 20201018105111.8727-1-kernel@septs.pw
State New
Headers show
Series [1/1] usb: serial: option: add Quectel EC200T module support | expand

Commit Message

septs Oct. 18, 2020, 10:51 a.m. UTC 
Add usb product id of the Quectel EC200T module.
---
 drivers/usb/serial/option.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Greg Kroah-Hartman Oct. 18, 2020, 12:49 p.m. UTC | #1 
On Sun, Oct 18, 2020 at 06:51:11PM +0800, septs wrote:
> Add usb product id of the Quectel EC200T module.

> ---

>  drivers/usb/serial/option.c | 2 ++

>  1 file changed, 2 insertions(+)

> 

> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c

> index 2a3bfd6f8..7e879233b 100644

> --- a/drivers/usb/serial/option.c

> +++ b/drivers/usb/serial/option.c

> @@ -250,6 +250,7 @@ static void option_instat_callback(struct urb *urb);

>  #define QUECTEL_PRODUCT_EP06			0x0306

>  #define QUECTEL_PRODUCT_EM12			0x0512

>  #define QUECTEL_PRODUCT_RM500Q			0x0800

> +#define QUECTEL_PRODUCT_EC200T			0x6026

>  

>  #define CMOTECH_VENDOR_ID			0x16d8

>  #define CMOTECH_PRODUCT_6001			0x6001

> @@ -1117,6 +1118,7 @@ static const struct usb_device_id option_ids[] = {

>  	{ USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_RM500Q, 0xff, 0, 0) },

>  	{ USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_RM500Q, 0xff, 0xff, 0x10),

>  	  .driver_info = ZLP },

> +	{ USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EC200T, 0xff, 0, 0) },

>  

>  	{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) },

>  	{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) },

> -- 

> 2.25.1

> 


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch does not have a Signed-off-by: line.  Please read the
  kernel file, Documentation/SubmittingPatches and resend it after
  adding that line.  Note, the line needs to be in the body of the
  email, before the patch, not at the bottom of the patch or in the
  email signature.


- It looks like you did not use your "real" name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file, Documentation/SubmittingPatches
  for how to do this correctly.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot
septs Oct. 18, 2020, 5:07 p.m. UTC | #2 
Add usb product id of the Quectel EC200T module.

Signed-off-by: septs <kernel@septs.pw>

---
 drivers/usb/serial/option.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 2a3bfd6f8..7e879233b 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -250,6 +250,7 @@ static void option_instat_callback(struct urb *urb);
 #define QUECTEL_PRODUCT_EP06			0x0306
 #define QUECTEL_PRODUCT_EM12			0x0512
 #define QUECTEL_PRODUCT_RM500Q			0x0800
+#define QUECTEL_PRODUCT_EC200T			0x6026
 
 #define CMOTECH_VENDOR_ID			0x16d8
 #define CMOTECH_PRODUCT_6001			0x6001
@@ -1117,6 +1118,7 @@ static const struct usb_device_id option_ids[] = {
 	{ USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_RM500Q, 0xff, 0, 0) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_RM500Q, 0xff, 0xff, 0x10),
 	  .driver_info = ZLP },
+	{ USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EC200T, 0xff, 0, 0) },
 
 	{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) },
 	{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) },
-- 
2.25.1


On Sun, Oct 18, 2020, at 20:49, Greg Kroah-Hartman wrote:
> On Sun, Oct 18, 2020 at 06:51:11PM +0800, septs wrote:

> > Add usb product id of the Quectel EC200T module.

> > ---

> >  drivers/usb/serial/option.c | 2 ++

> >  1 file changed, 2 insertions(+)

> > 

> > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c

> > index 2a3bfd6f8..7e879233b 100644

> > --- a/drivers/usb/serial/option.c

> > +++ b/drivers/usb/serial/option.c

> > @@ -250,6 +250,7 @@ static void option_instat_callback(struct urb *urb);

> >  #define QUECTEL_PRODUCT_EP06			0x0306

> >  #define QUECTEL_PRODUCT_EM12			0x0512

> >  #define QUECTEL_PRODUCT_RM500Q			0x0800

> > +#define QUECTEL_PRODUCT_EC200T			0x6026

> >  

> >  #define CMOTECH_VENDOR_ID			0x16d8

> >  #define CMOTECH_PRODUCT_6001			0x6001

> > @@ -1117,6 +1118,7 @@ static const struct usb_device_id option_ids[] = {

> >  	{ USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_RM500Q, 0xff, 0, 0) },

> >  	{ USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_RM500Q, 0xff, 0xff, 0x10),

> >  	  .driver_info = ZLP },

> > +	{ USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EC200T, 0xff, 0, 0) },

> >  

> >  	{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) },

> >  	{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) },

> > -- 

> > 2.25.1

> > 

> 

> Hi,

> 

> This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him

> a patch that has triggered this response.  He used to manually respond

> to these common problems, but in order to save his sanity (he kept

> writing the same thing over and over, yet to different people), I was

> created.  Hopefully you will not take offence and will fix the problem

> in your patch and resubmit it so that it can be accepted into the Linux

> kernel tree.

> 

> You are receiving this message because of the following common error(s)

> as indicated below:

> 

> - Your patch does not have a Signed-off-by: line.  Please read the

>   kernel file, Documentation/SubmittingPatches and resend it after

>   adding that line.  Note, the line needs to be in the body of the

>   email, before the patch, not at the bottom of the patch or in the

>   email signature.

> 

> 

> - It looks like you did not use your "real" name for the patch on either

>   the Signed-off-by: line, or the From: line (both of which have to

>   match).  Please read the kernel file, Documentation/SubmittingPatches

>   for how to do this correctly.

> 

> If you wish to discuss this problem further, or you have questions about

> how to resolve this issue, please feel free to respond to this email and

> Greg will reply once he has dug out from the pending patches received

> from other developers.

> 

> thanks,

> 

> greg k-h's patch email bot

>
Greg Kroah-Hartman Oct. 19, 2020, 5:36 a.m. UTC | #3 
On Mon, Oct 19, 2020 at 01:07:10AM +0800, septs wrote:
> Add usb product id of the Quectel EC200T module.

> 

> Signed-off-by: septs <kernel@septs.pw>


As my bot said before, you need to use your "legal name" here.  Is this
how you sign documents?  If so, that's fine, but I have to ask.

thanks,

greg k-h
Greg Kroah-Hartman Oct. 19, 2020, 5:36 a.m. UTC | #4 
On Mon, Oct 19, 2020 at 01:07:10AM +0800, septs wrote:
> Add usb product id of the Quectel EC200T module.

> 

> Signed-off-by: septs <kernel@septs.pw>


Also, this address doesn't match your "From:" line, which means we can't
take it anyway.
diff mbox series

Patch

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 2a3bfd6f8..7e879233b 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -250,6 +250,7 @@  static void option_instat_callback(struct urb *urb);
 #define QUECTEL_PRODUCT_EP06			0x0306
 #define QUECTEL_PRODUCT_EM12			0x0512
 #define QUECTEL_PRODUCT_RM500Q			0x0800
+#define QUECTEL_PRODUCT_EC200T			0x6026
 
 #define CMOTECH_VENDOR_ID			0x16d8
 #define CMOTECH_PRODUCT_6001			0x6001
@@ -1117,6 +1118,7 @@  static const struct usb_device_id option_ids[] = {
 	{ USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_RM500Q, 0xff, 0, 0) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_RM500Q, 0xff, 0xff, 0x10),
 	  .driver_info = ZLP },
+	{ USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EC200T, 0xff, 0, 0) },
 
 	{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) },
 	{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) },