diff mbox series

dt-bindings: usb: Add new compatible string for AM64 SoC

Message ID 20201209165733.8204-2-a-govindraju@ti.com
State Superseded
Headers show
Series dt-bindings: usb: Add new compatible string for AM64 SoC | expand

Commit Message

Aswath Govindraju Dec. 9, 2020, 4:57 p.m. UTC
Add compatible string in j721e-usb binding file as similar USB subsystem
is present in AM64.

Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
Acked-by: Roger Quadros <rogerq@ti.com>
---
 Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Aswath Govindraju Dec. 10, 2020, 5:27 a.m. UTC | #1
Hi Robert,

On 10/12/20 1:04 am, Rob Herring wrote:
> On Wed, Dec 09, 2020 at 10:27:32PM +0530, Aswath Govindraju wrote:
>> Add compatible string in j721e-usb binding file as similar USB subsystem
>> is present in AM64.
>>
>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
>> Acked-by: Roger Quadros <rogerq@ti.com>
>> ---
>>  Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 7 +++++--
>>  1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
>> index 388245b91a55..05d976bb06d0 100644
>> --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
>> +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
>> @@ -11,8 +11,11 @@ maintainers:
>>  
>>  properties:
>>    compatible:
>> -    items:
>> -      - const: ti,j721e-usb
>> +    anyOf:
>> +      - items:
>> +	  - const: ti,j721e-usb
>> +      - items:
>> +	  - const: ti,am64-usb
> 
> Use 'enum'.
> 
Thank you for the comments.

I used anyOf to mention that the compatible strings can be either used
separately or together in the DT files after referring [1].

Using enum brought in constraints such as if one compatible string is
used the other cannot be used.

The error that I made was use of '\t' at the start of the lines. I will
correct it and send a respin.


[1]https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/example-schema.yaml

Thanks,
Aswath

>>  
>>    reg:
>>      description: module registers
>> -- 
>> 2.17.1
>>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
index 388245b91a55..05d976bb06d0 100644
--- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
+++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
@@ -11,8 +11,11 @@  maintainers:
 
 properties:
   compatible:
-    items:
-      - const: ti,j721e-usb
+    anyOf:
+      - items:
+	  - const: ti,j721e-usb
+      - items:
+	  - const: ti,am64-usb
 
   reg:
     description: module registers