diff mbox series

usb: gadget: select CONFIG_CRC32

Message ID 20210103214224.1996535-1-arnd@kernel.org
State New
Headers show
Series usb: gadget: select CONFIG_CRC32 | expand

Commit Message

Arnd Bergmann Jan. 3, 2021, 9:42 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>


Without crc32 support, this driver fails to link:

arm-linux-gnueabi-ld: drivers/usb/gadget/function/f_eem.o: in function `eem_unwrap':
f_eem.c:(.text+0x11cc): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/usb/gadget/function/f_ncm.o:f_ncm.c:(.text+0x1e40):
more undefined references to `crc32_le' follow

Fixes: 6d3865f9d41f ("usb: gadget: NCM: Add transmit multi-frame.")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/usb/gadget/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.29.2

Comments

Felipe Balbi Jan. 5, 2021, 1 p.m. UTC | #1 
Arnd Bergmann <arnd@kernel.org> writes:

> From: Arnd Bergmann <arnd@arndb.de>

>

> Without crc32 support, this driver fails to link:

>

> arm-linux-gnueabi-ld: drivers/usb/gadget/function/f_eem.o: in function `eem_unwrap':

> f_eem.c:(.text+0x11cc): undefined reference to `crc32_le'

> arm-linux-gnueabi-ld: drivers/usb/gadget/function/f_ncm.o:f_ncm.c:(.text+0x1e40):

> more undefined references to `crc32_le' follow

>

> Fixes: 6d3865f9d41f ("usb: gadget: NCM: Add transmit multi-frame.")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Acked-by: Felipe Balbi <balbi@kernel.org>


-- 
balbi
diff mbox series

Patch

diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
index 7e47e6223089..2d152571a7de 100644
--- a/drivers/usb/gadget/Kconfig
+++ b/drivers/usb/gadget/Kconfig
@@ -265,6 +265,7 @@  config USB_CONFIGFS_NCM
 	depends on NET
 	select USB_U_ETHER
 	select USB_F_NCM
+	select CRC32
 	help
 	  NCM is an advanced protocol for Ethernet encapsulation, allows
 	  grouping of several ethernet frames into one USB transfer and
@@ -314,6 +315,7 @@  config USB_CONFIGFS_EEM
 	depends on NET
 	select USB_U_ETHER
 	select USB_F_EEM
+	select CRC32
 	help
 	  CDC EEM is a newer USB standard that is somewhat simpler than CDC ECM
 	  and therefore can be supported by more hardware.  Technically ECM and