[v2,04/10] usb: dwc2/gadget: disable phy before turning off power regulators

Message ID 1413801940-31086-5-git-send-email-m.szyprowski@samsung.com
State Accepted
Commit 3a8146aafcedd93e42045598802e1eb71cae68c0
Headers show

Commit Message

Marek Szyprowski Oct. 20, 2014, 10:45 a.m.
This patch fixes probe function to match the pattern used elsewhere in
the driver, where power regulators are turned off as the last element in
the device shutdown procedure.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
 drivers/usb/dwc2/gadget.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Felipe Balbi Oct. 23, 2014, 3:01 p.m. | #1
On Mon, Oct 20, 2014 at 12:45:34PM +0200, Marek Szyprowski wrote:
> This patch fixes probe function to match the pattern used elsewhere in
> the driver, where power regulators are turned off as the last element in
> the device shutdown procedure.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

Paul, can I have your Acked-by here so I can send this to v3.18-rc1 ?
Paul Zimmerman Oct. 23, 2014, 6:15 p.m. | #2
> From: Felipe Balbi [mailto:balbi@ti.com]
> Sent: Thursday, October 23, 2014 8:01 AM
> 
> On Mon, Oct 20, 2014 at 12:45:34PM +0200, Marek Szyprowski wrote:
> > This patch fixes probe function to match the pattern used elsewhere in
> > the driver, where power regulators are turned off as the last element in
> > the device shutdown procedure.
> >
> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> 
> Paul, can I have your Acked-by here so I can send this to v3.18-rc1 ?

Sorry, I've been working on a really hot issue at $work and didn't have
time yet to review this series.

Acked-by: Paul Zimmerman <paulz@synopsys.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Felipe Balbi Oct. 23, 2014, 6:58 p.m. | #3
On Thu, Oct 23, 2014 at 06:15:57PM +0000, Paul Zimmerman wrote:
> > From: Felipe Balbi [mailto:balbi@ti.com]
> > Sent: Thursday, October 23, 2014 8:01 AM
> > 
> > On Mon, Oct 20, 2014 at 12:45:34PM +0200, Marek Szyprowski wrote:
> > > This patch fixes probe function to match the pattern used elsewhere in
> > > the driver, where power regulators are turned off as the last element in
> > > the device shutdown procedure.
> > >
> > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > 
> > Paul, can I have your Acked-by here so I can send this to v3.18-rc1 ?
> 
> Sorry, I've been working on a really hot issue at $work and didn't have
> time yet to review this series.

don't worry, we've all been there :-)

thanks

Patch

diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index a4b4def23afd..fd52a8b23649 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -3571,6 +3571,7 @@  static int s3c_hsotg_probe(struct platform_device *pdev)
 		s3c_hsotg_initep(hsotg, &hsotg->eps[epnum], epnum);
 
 	/* disable power and clock */
+	s3c_hsotg_phy_disable(hsotg);
 
 	ret = regulator_bulk_disable(ARRAY_SIZE(hsotg->supplies),
 				    hsotg->supplies);
@@ -3579,8 +3580,6 @@  static int s3c_hsotg_probe(struct platform_device *pdev)
 		goto err_ep_mem;
 	}
 
-	s3c_hsotg_phy_disable(hsotg);
-
 	ret = usb_add_gadget_udc(&pdev->dev, &hsotg->gadget);
 	if (ret)
 		goto err_ep_mem;