diff mbox

drivers/base: cacheinfo: remove noisy error boot message

Message ID 1415803373-7429-1-git-send-email-sudeep.holla@arm.com
State Accepted
Commit 6df43c9b4d87b6767debdfa8318c5374415e8fc0
Headers show

Commit Message

Sudeep Holla Nov. 12, 2014, 2:42 p.m. UTC 
On systems that don't support cacheinfo, this error message can be
considered noisy and irrelevant. The error messages can be added to
the functions that architectures implement overiding the weak default
definition if really required.

This patch removes the concerned error message in the generic code.

Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Reported-by: Fabio Estevam <festevam@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/base/cacheinfo.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Hi Greg,

Since I always tested the series only on the architectures supporting
cacheinfo, I failed to see that this error message is thrown out at the
boot time if the architecture doesn't support it.

Can you pick up this small fix to avoid noisy error message ?

Regards,
Sudeep
diff mbox

Patch

diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c
index 8ed4ea1f3716..6e64563361f0 100644
--- a/drivers/base/cacheinfo.c
+++ b/drivers/base/cacheinfo.c
@@ -520,10 +520,8 @@  static int __init cacheinfo_sysfs_init(void)
 
 	for_each_online_cpu(cpu) {
 		rc = detect_cache_attributes(cpu);
-		if (rc) {
-			pr_err("error detecting cacheinfo..cpu%d\n", cpu);
+		if (rc)
 			goto out;
-		}
 		rc = cache_add_dev(cpu);
 		if (rc) {
 			free_cache_attributes(cpu);