| Message ID | 20220130185032.29298-1-rdunlap@infradead.org |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] usb: typec: mux: select not-visible INTEL_SCU_IPC | expand |
On Sun, Jan 30, 2022 at 10:50:32AM -0800, Randy Dunlap wrote: > Use "select INTEL_SCU_IPC" instead of depending on it since it is > not a visible Kconfig symbol and it may not otherwise be set/enabled. > > Fixes: b62851491a55 ("usb: typec: mux: Convert the Intel PMC Mux driver to use new SCU IPC API") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Cc: Mika Westerberg <mika.westerberg@linux.intel.com> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: linux-usb@vger.kernel.org > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: kernel test robot <lkp@intel.com> > --- > v2: add dependency on X86_PLATFORM_DEVICES to fix build error that was > Reported_by: kernel test robot <lkp@intel.com> > > drivers/usb/typec/mux/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- linux-next-20220128.orig/drivers/usb/typec/mux/Kconfig > +++ linux-next-20220128/drivers/usb/typec/mux/Kconfig > @@ -11,8 +11,8 @@ config TYPEC_MUX_PI3USB30532 > > config TYPEC_MUX_INTEL_PMC > tristate "Intel PMC mux control" > - depends on ACPI > - depends on INTEL_SCU_IPC > + depends on ACPI && X86_PLATFORM_DEVICES > + select INTEL_SCU_IPC > select USB_ROLE_SWITCH > help > Driver for USB muxes controlled by Intel PMC FW. Intel PMC FW can This will cause the driver to fail at probe time if there are no SCU device drivers enabled. The idea is that the SCU device drivers select the SCU IPC library, not the users of the library like this mux driver. thanks,
On 1/31/22 00:42, Heikki Krogerus wrote: > On Sun, Jan 30, 2022 at 10:50:32AM -0800, Randy Dunlap wrote: >> Use "select INTEL_SCU_IPC" instead of depending on it since it is >> not a visible Kconfig symbol and it may not otherwise be set/enabled. >> >> Fixes: b62851491a55 ("usb: typec: mux: Convert the Intel PMC Mux driver to use new SCU IPC API") >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> >> Cc: Mika Westerberg <mika.westerberg@linux.intel.com> >> Cc: Lee Jones <lee.jones@linaro.org> >> Cc: linux-usb@vger.kernel.org >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> Cc: kernel test robot <lkp@intel.com> >> --- >> v2: add dependency on X86_PLATFORM_DEVICES to fix build error that was >> Reported_by: kernel test robot <lkp@intel.com> >> >> drivers/usb/typec/mux/Kconfig | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> --- linux-next-20220128.orig/drivers/usb/typec/mux/Kconfig >> +++ linux-next-20220128/drivers/usb/typec/mux/Kconfig >> @@ -11,8 +11,8 @@ config TYPEC_MUX_PI3USB30532 >> >> config TYPEC_MUX_INTEL_PMC >> tristate "Intel PMC mux control" >> - depends on ACPI >> - depends on INTEL_SCU_IPC >> + depends on ACPI && X86_PLATFORM_DEVICES >> + select INTEL_SCU_IPC >> select USB_ROLE_SWITCH >> help >> Driver for USB muxes controlled by Intel PMC FW. Intel PMC FW can > > This will cause the driver to fail at probe time if there are no SCU > device drivers enabled. > > The idea is that the SCU device drivers select the SCU IPC library, > not the users of the library like this mux driver. OK. Thanks.
--- linux-next-20220128.orig/drivers/usb/typec/mux/Kconfig +++ linux-next-20220128/drivers/usb/typec/mux/Kconfig @@ -11,8 +11,8 @@ config TYPEC_MUX_PI3USB30532 config TYPEC_MUX_INTEL_PMC tristate "Intel PMC mux control" - depends on ACPI - depends on INTEL_SCU_IPC + depends on ACPI && X86_PLATFORM_DEVICES + select INTEL_SCU_IPC select USB_ROLE_SWITCH help Driver for USB muxes controlled by Intel PMC FW. Intel PMC FW can
Use "select INTEL_SCU_IPC" instead of depending on it since it is not a visible Kconfig symbol and it may not otherwise be set/enabled. Fixes: b62851491a55 ("usb: typec: mux: Convert the Intel PMC Mux driver to use new SCU IPC API") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> Cc: Mika Westerberg <mika.westerberg@linux.intel.com> Cc: Lee Jones <lee.jones@linaro.org> Cc: linux-usb@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: kernel test robot <lkp@intel.com> --- v2: add dependency on X86_PLATFORM_DEVICES to fix build error that was Reported_by: kernel test robot <lkp@intel.com> drivers/usb/typec/mux/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)