Message ID | 20220320160009.2665152-3-richard.henderson@linaro.org |
---|---|
State | Superseded |
Headers | show |
Series | linux-user/nios2: Fix clone and sigreturn | expand |
On Sun, 20 Mar 2022 at 16:09, Richard Henderson <richard.henderson@linaro.org> wrote: > > There's no documentation for what the problem was. > > Fixes: a0a839b65b6 ("nios2: Add usermode binaries emulation") > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > linux-user/nios2/cpu_loop.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c > index a3acaa92ca..ac71f4ee47 100644 > --- a/linux-user/nios2/cpu_loop.c > +++ b/linux-user/nios2/cpu_loop.c > @@ -48,10 +48,6 @@ void cpu_loop(CPUNios2State *env) > env->regs[7], env->regs[8], env->regs[9], > 0, 0); > > - if (env->regs[2] == 0) { /* FIXME: syscall 0 workaround */ > - ret = 0; > - } > - > env->regs[2] = abs(ret); > /* Return value is 0..4096 */ > env->regs[7] = ret > 0xfffff000u; > -- syscall 0 on this architecture is __NR_io_setup, incidentally. Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c index a3acaa92ca..ac71f4ee47 100644 --- a/linux-user/nios2/cpu_loop.c +++ b/linux-user/nios2/cpu_loop.c @@ -48,10 +48,6 @@ void cpu_loop(CPUNios2State *env) env->regs[7], env->regs[8], env->regs[9], 0, 0); - if (env->regs[2] == 0) { /* FIXME: syscall 0 workaround */ - ret = 0; - } - env->regs[2] = abs(ret); /* Return value is 0..4096 */ env->regs[7] = ret > 0xfffff000u;
There's no documentation for what the problem was. Fixes: a0a839b65b6 ("nios2: Add usermode binaries emulation") Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- linux-user/nios2/cpu_loop.c | 4 ---- 1 file changed, 4 deletions(-)