| Message ID | 20220728064937.917935-1-alexander.stein@ew.tq-group.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1] usb: misc: onboard_usb_hub: Remove duplicated power_on delay | expand |
On Thu, Jul 28, 2022 at 08:49:37AM +0200, Alexander Stein wrote: > onboard_hub_power_on() already ensures the reset pulse width delay, so > there is no need to wait right after requesting GPIO as well. > > Fixes: 40758e493f4d ("usb: misc: onboard_usb_hub: Add reset-gpio support") That shouldn't be needed, since it's not an actual bug. Anyway, I see Greg already landed it.
diff --git a/drivers/usb/misc/onboard_usb_hub.c b/drivers/usb/misc/onboard_usb_hub.c index eb8aef25a22d..d1df153e7f5a 100644 --- a/drivers/usb/misc/onboard_usb_hub.c +++ b/drivers/usb/misc/onboard_usb_hub.c @@ -256,9 +256,6 @@ static int onboard_hub_probe(struct platform_device *pdev) if (IS_ERR(hub->reset_gpio)) return dev_err_probe(dev, PTR_ERR(hub->reset_gpio), "failed to get reset GPIO\n"); - if (hub->reset_gpio) - fsleep(hub->pdata->reset_us); - hub->dev = dev; mutex_init(&hub->lock); INIT_LIST_HEAD(&hub->udev_list);
onboard_hub_power_on() already ensures the reset pulse width delay, so there is no need to wait right after requesting GPIO as well. Fixes: 40758e493f4d ("usb: misc: onboard_usb_hub: Add reset-gpio support") Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- drivers/usb/misc/onboard_usb_hub.c | 3 --- 1 file changed, 3 deletions(-)