diff mbox series

[11/22] hw/alpha: make E1000_PCI a hard dependency for clipper

Message ID 20230503091244.1450613-12-alex.bennee@linaro.org
State New
Headers show
Series testing/next: cirrus, docker, docs, ci, configs, gitlab | expand

Commit Message

Alex Bennée May 3, 2023, 9:12 a.m. UTC 
We can't just imply it as the board will fail to create otherwise.
This shows up as a "make check" failure with a
--without-default-devices build.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 hw/alpha/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Henderson May 3, 2023, 10:26 a.m. UTC | #1 
On 5/3/23 10:12, Alex Bennée wrote:
> We can't just imply it as the board will fail to create otherwise.
> This shows up as a "make check" failure with a
> --without-default-devices build.
> 
> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
> ---
>   hw/alpha/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~
Paolo Bonzini May 3, 2023, 5:14 p.m. UTC | #2 
On 5/3/23 11:12, Alex Bennée wrote:
> We can't just imply it as the board will fail to create otherwise.
> This shows up as a "make check" failure with a
> --without-default-devices build.

Not needed and a test bug.

Paolo
diff mbox series

Patch

diff --git a/hw/alpha/Kconfig b/hw/alpha/Kconfig
index 9af650c94e..4db7f84e9e 100644
--- a/hw/alpha/Kconfig
+++ b/hw/alpha/Kconfig
@@ -2,7 +2,7 @@  config DP264
     bool
     imply PCI_DEVICES
     imply TEST_DEVICES
-    imply E1000_PCI
+    select E1000_PCI
     select I82378
     select IDE_CMD646
     select MC146818RTC