diff mbox series

[15/22] hw/sh4: make RTL8139 a hard dependency for RD2

Message ID 20230503091244.1450613-16-alex.bennee@linaro.org
State New
Headers show
Series testing/next: cirrus, docker, docs, ci, configs, gitlab | expand

Commit Message

Alex Bennée May 3, 2023, 9:12 a.m. UTC 
We can't just imply it as the board will fail to create otherwise.
This shows up as a "make check" failure with a
--without-default-devices build.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 hw/sh4/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Henderson May 3, 2023, 10:27 a.m. UTC | #1 
On 5/3/23 10:12, Alex Bennée wrote:
> We can't just imply it as the board will fail to create otherwise.
> This shows up as a "make check" failure with a
> --without-default-devices build.
> 
> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
> ---
>   hw/sh4/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~
Paolo Bonzini May 3, 2023, 5:19 p.m. UTC | #2 
On 5/3/23 11:12, Alex Bennée wrote:
> We can't just imply it as the board will fail to create otherwise.
> This shows up as a "make check" failure with a
> --without-default-devices build.

Not needed, also typo in subject (should be R2D rather than RD2).

Paolo
diff mbox series

Patch

diff --git a/hw/sh4/Kconfig b/hw/sh4/Kconfig
index ab733a3f76..03f3469ae1 100644
--- a/hw/sh4/Kconfig
+++ b/hw/sh4/Kconfig
@@ -2,7 +2,7 @@  config R2D
     bool
     imply PCI_DEVICES
     imply TEST_DEVICES
-    imply RTL8139_PCI
+    select RTL8139_PCI
     select I82378 if TEST_DEVICES
     select IDE_MMIO
     select PFLASH_CFI02