| Message ID | 21c2b8ee-7753-413e-98f9-d1401edf5c73@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | usb: storage: set 1.50 as the lower bcdDevice for older "Super Top" compatibility | expand |
On Fri, Oct 27, 2023 at 08:28:04PM +0300, LihaSika wrote: > Change lower bcdDevice value for "Super Top USB 2.0 SATA BRIDGE" to match > 1.50. I have such an older device with bcdDevice=1.50 and it will not work > otherwise. What about below description? ``` Some old USB hard drives using Super Top USB 2.0 SATA bridge have lower minimum bcdDevice value than currently allowed (1.60). Such devices cannot be used by ums-cypress driver since their bcdDevice is out of range. Lower minimum bcdDevice to fix that. ``` > > Cc: stable@vger.kernel.org > Signed-off-by: Liha Sikanen <lihasika@gmail.com> Is your intended author name in your From: header or Signed-off-by: trailer? Also, don't forget to add Fixes: tag; that is: Fixes: a9c143c82608 ("usb-storage: restrict bcdDevice range for Super Top in Cypress ATACB") When above reviews are addressed, resend as v2. Make sure that the patch subject begins with `[PATCH v2]`. > --- > > diff --git a/drivers/usb/storage/unusual_cypress.h b/drivers/usb/storage/unusual_cypress.h > index 0547daf..5df4075 100644 > --- a/drivers/usb/storage/unusual_cypress.h > +++ b/drivers/usb/storage/unusual_cypress.h > @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999, > "Cypress ISD-300LP", > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > > -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, > +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160, > "Super Top", > "USB 2.0 SATA BRIDGE", > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > The diff itself is LGTM. Thanks.
On Sat, Oct 28, 2023 at 02:02:37PM +0700, Bagas Sanjaya wrote: > On Fri, Oct 27, 2023 at 08:28:04PM +0300, LihaSika wrote: > > Change lower bcdDevice value for "Super Top USB 2.0 SATA BRIDGE" to match > > 1.50. I have such an older device with bcdDevice=1.50 and it will not work > > otherwise. > > What about below description? > > ``` > Some old USB hard drives using Super Top USB 2.0 SATA bridge have lower > minimum bcdDevice value than currently allowed (1.60). Such devices > cannot be used by ums-cypress driver since their bcdDevice is out of range. > > Lower minimum bcdDevice to fix that. > ``` > > > > > Cc: stable@vger.kernel.org > > Signed-off-by: Liha Sikanen <lihasika@gmail.com> > > Is your intended author name in your From: header or Signed-off-by: trailer? > > Also, don't forget to add Fixes: tag; that is: > > Fixes: a9c143c82608 ("usb-storage: restrict bcdDevice range for Super Top in Cypress ATACB") > > When above reviews are addressed, resend as v2. Make sure that the patch > subject begins with `[PATCH v2]`. There's no need, I can take this as-is, thanks. greg k-h
On 28/10/2023 17:23, Greg Kroah-Hartman wrote: > On Sat, Oct 28, 2023 at 02:02:37PM +0700, Bagas Sanjaya wrote: >> On Fri, Oct 27, 2023 at 08:28:04PM +0300, LihaSika wrote: >>> Change lower bcdDevice value for "Super Top USB 2.0 SATA BRIDGE" to match >>> 1.50. I have such an older device with bcdDevice=1.50 and it will not work >>> otherwise. >> >> What about below description? >> >> ``` >> Some old USB hard drives using Super Top USB 2.0 SATA bridge have lower >> minimum bcdDevice value than currently allowed (1.60). Such devices >> cannot be used by ums-cypress driver since their bcdDevice is out of range. >> >> Lower minimum bcdDevice to fix that. >> ``` >> >>> >>> Cc: stable@vger.kernel.org >>> Signed-off-by: Liha Sikanen <lihasika@gmail.com> >> >> Is your intended author name in your From: header or Signed-off-by: trailer? >> >> Also, don't forget to add Fixes: tag; that is: >> >> Fixes: a9c143c82608 ("usb-storage: restrict bcdDevice range for Super Top in Cypress ATACB") >> >> When above reviews are addressed, resend as v2. Make sure that the patch >> subject begins with `[PATCH v2]`. > > There's no need, I can take this as-is, thanks. > OK, thanks!
On 28.10.2023 14.05, Bagas Sanjaya wrote: > On 28/10/2023 17:23, Greg Kroah-Hartman wrote: >> >> There's no need, I can take this as-is, thanks. >> > > OK, thanks! > Thank you all 🙏 I will use git mail if I ever have any more to contribute in the future, thanks for all the advice 👍 Have a nice weekend! BR, Liha
diff --git a/drivers/usb/storage/unusual_cypress.h b/drivers/usb/storage/unusual_cypress.h index 0547daf..7b3d5f0 100644 --- a/drivers/usb/storage/unusual_cypress.h +++ b/drivers/usb/storage/unusual_cypress.h @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999, "Cypress ISD-300LP", USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160, "Super Top", "USB 2.0 SATA BRIDGE", USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0),
Change lower bcdDevice value for "Super Top USB 2.0 SATA BRIDGE" to match 1.50. I have such an older device with bcdDevice=1.50 and it will not work otherwise. Cc: stable@vger.kernel.org Signed-off-by: Liha Sikanen <lihasika@gmail.com> ---