| Message ID | 20240322-typec-fix-example-v1-1-6b01c347419e@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: usb: qcom,pmic-typec: OF graph corrections | expand |
On 22/03/2024 11:52, Dmitry Baryshkov wrote: > The PMIC Type-C controller doesn't have separate role-switching signal. > Instead it has an HS signal connection between embedded USB-C connector > node and the HS port of the USB controller. I take your point on port as a signal but the way type-c determines data-role is via the DR_Swap message. https://www.embedded.com/usb-type-c-and-power-delivery-101-power-delivery-protocol/ We receive an IRQ which is a packet containing DR_Swap - TCPM consumes that data and does a data-role switch. The port then establishes the link between typec-port and redriver or PHY. So, I think HS should be dropped from the commit logs and names in both series. BTW for the GLINK devices I think the adsp firmware just notifies the APSS of the data-role switch so, these types of devices probably should have an epdoint with "usb_role_switch" in the name. --- bod
diff --git a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml index d9694570c419..63020a88a355 100644 --- a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml +++ b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml @@ -84,11 +84,6 @@ properties: vdd-pdphy-supply: description: VDD regulator supply to the PDPHY. - port: - $ref: /schemas/graph.yaml#/properties/port - description: - Contains a port which produces data-role switching messages. - required: - compatible - reg
The PMIC Type-C controller doesn't have separate role-switching signal. Instead it has an HS signal connection between embedded USB-C connector node and the HS port of the USB controller. Fixes: 00bb478b829e ("dt-bindings: usb: Add Qualcomm PMIC Type-C") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml | 5 ----- 1 file changed, 5 deletions(-)