| Message ID | 20240408151700.1761009-1-festevam@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | usb: misc: onboard_usb_hub: Disable the USB hub clock on failure | expand |
On Mon, Apr 08, 2024 at 12:17:00PM -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > In case regulator_bulk_enable() fails, the previously enabled USB hub > clock should be disabled. > > Fix it accordingly. > > Fixes: 65e62b8a955a ("usb: misc: onboard_usb_hub: Add support for clock input") > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- > drivers/usb/misc/onboard_usb_dev.c | 6 +++++- This file is not in the tree for 6.9-rc2, can you please fix this up and resend? thanks, greg k-h
diff --git a/drivers/usb/misc/onboard_usb_dev.c b/drivers/usb/misc/onboard_usb_dev.c index 648ea933bdad..f2bcc1a8b95f 100644 --- a/drivers/usb/misc/onboard_usb_dev.c +++ b/drivers/usb/misc/onboard_usb_dev.c @@ -93,7 +93,7 @@ static int onboard_dev_power_on(struct onboard_dev *onboard_dev) if (err) { dev_err(onboard_dev->dev, "failed to enable supplies: %pe\n", ERR_PTR(err)); - return err; + goto disable_clk; } fsleep(onboard_dev->pdata->reset_us); @@ -102,6 +102,10 @@ static int onboard_dev_power_on(struct onboard_dev *onboard_dev) onboard_dev->is_powered_on = true; return 0; + +disable_clk: + clk_disable_unprepare(onboard_dev->clk); + return err; } static int onboard_dev_power_off(struct onboard_dev *onboard_dev)