| Message ID | 20250318150908.1583652-1-xu.yang_2@nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v6,1/4] dt-bindings: usb: chipidea: Add i.MX95 compatible string 'fsl,imx95-usb' | expand |
Hi Greg, On Tue, Mar 18, 2025 at 11:09:05PM +0800, Xu Yang wrote: > The i.MX95 USB2.0 controller is mostly compatible with i.MX7D, except it > requires a second interrupt for wakeup handling. Add the compatible string > for the i.MX95 platform, add the iommus property, and enforce the > interrupt property restriction. Keep the same restriction for existing > compatible strings. > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> > Reviewed-by: Frank Li <Frank.Li@nxp.com> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > > --- > Changes in v6: > - no changes > Changes in v5: > - no changes > Changes in v4: > - no changes > Changes in v3: > - add Rb tag > Changes in v2: > - improve interrupts description > - improve subject and commit message > --- > .../bindings/usb/chipidea,usb2-common.yaml | 3 +++ > .../bindings/usb/chipidea,usb2-imx.yaml | 24 ++++++++++++++++++- > 2 files changed, 26 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/chipidea,usb2-common.yaml b/Documentation/devicetree/bindings/usb/chipidea,usb2-common.yaml > index d2a7d2ecf48a..10020af15afc 100644 > --- a/Documentation/devicetree/bindings/usb/chipidea,usb2-common.yaml > +++ b/Documentation/devicetree/bindings/usb/chipidea,usb2-common.yaml > @@ -42,6 +42,9 @@ properties: > > phy_type: true > > + iommus: > + maxItems: 1 > + > itc-setting: > description: > interrupt threshold control register control, the setting should be > diff --git a/Documentation/devicetree/bindings/usb/chipidea,usb2-imx.yaml b/Documentation/devicetree/bindings/usb/chipidea,usb2-imx.yaml > index 8f6136f5d72e..51014955ab3c 100644 > --- a/Documentation/devicetree/bindings/usb/chipidea,usb2-imx.yaml > +++ b/Documentation/devicetree/bindings/usb/chipidea,usb2-imx.yaml > @@ -41,6 +41,7 @@ properties: > - fsl,imx8mm-usb > - fsl,imx8mn-usb > - fsl,imx93-usb > + - fsl,imx95-usb > - const: fsl,imx7d-usb > - const: fsl,imx27-usb > - items: > @@ -54,7 +55,11 @@ properties: > maxItems: 1 > > interrupts: > - maxItems: 1 > + minItems: 1 > + items: > + - description: USB controller interrupt or combine USB controller > + and wakeup interrupts. > + - description: Wakeup interrupt > > clocks: > minItems: 1 > @@ -191,6 +196,7 @@ allOf: > contains: > enum: > - fsl,imx93-usb > + - fsl,imx95-usb > then: > properties: > clocks: > @@ -238,6 +244,22 @@ allOf: > maxItems: 1 > clock-names: false > > + # imx95 soc use two interrupts > + - if: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx95-usb > + then: > + properties: > + interrupts: > + minItems: 2 > + else: > + properties: > + interrupts: > + maxItems: 1 > + > unevaluatedProperties: false Will you pick up these patches? Thanks, Xu Yang > > examples: > -- > 2.34.1 >
diff --git a/Documentation/devicetree/bindings/usb/chipidea,usb2-common.yaml b/Documentation/devicetree/bindings/usb/chipidea,usb2-common.yaml index d2a7d2ecf48a..10020af15afc 100644 --- a/Documentation/devicetree/bindings/usb/chipidea,usb2-common.yaml +++ b/Documentation/devicetree/bindings/usb/chipidea,usb2-common.yaml @@ -42,6 +42,9 @@ properties: phy_type: true + iommus: + maxItems: 1 + itc-setting: description: interrupt threshold control register control, the setting should be diff --git a/Documentation/devicetree/bindings/usb/chipidea,usb2-imx.yaml b/Documentation/devicetree/bindings/usb/chipidea,usb2-imx.yaml index 8f6136f5d72e..51014955ab3c 100644 --- a/Documentation/devicetree/bindings/usb/chipidea,usb2-imx.yaml +++ b/Documentation/devicetree/bindings/usb/chipidea,usb2-imx.yaml @@ -41,6 +41,7 @@ properties: - fsl,imx8mm-usb - fsl,imx8mn-usb - fsl,imx93-usb + - fsl,imx95-usb - const: fsl,imx7d-usb - const: fsl,imx27-usb - items: @@ -54,7 +55,11 @@ properties: maxItems: 1 interrupts: - maxItems: 1 + minItems: 1 + items: + - description: USB controller interrupt or combine USB controller + and wakeup interrupts. + - description: Wakeup interrupt clocks: minItems: 1 @@ -191,6 +196,7 @@ allOf: contains: enum: - fsl,imx93-usb + - fsl,imx95-usb then: properties: clocks: @@ -238,6 +244,22 @@ allOf: maxItems: 1 clock-names: false + # imx95 soc use two interrupts + - if: + properties: + compatible: + contains: + enum: + - fsl,imx95-usb + then: + properties: + interrupts: + minItems: 2 + else: + properties: + interrupts: + maxItems: 1 + unevaluatedProperties: false examples: