diff mbox series

Wake on connect / wake on disconnect

Message ID ce2048af-1044-4424-bca2-3799baefb9c2@amd.com
State New
Headers show
Series Wake on connect / wake on disconnect | expand

Commit Message

Mario Limonciello April 3, 2025, 6:12 p.m. UTC 
Mika,

Recently there are some conversations about wake-up from 
connect/disconnect happening and I wanted to get some background from 
you about the current policy set in tb_switch_suspend().

Wake on connect and disconnect are only used for runtime, not for system 
suspend.  Would you be open to adding wake on connect as well for system 
suspend?  This should help enable use cases like plugging in a closed 
laptop to a dock (which works on Windows).

Something like this:



Thanks!
diff mbox series

Patch

diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c
index 6a2116cbb06f..f2f6a085a742 100644
--- a/drivers/thunderbolt/switch.c
+++ b/drivers/thunderbolt/switch.c
@@ -3599,6 +3599,7 @@  void tb_switch_suspend(struct tb_switch *sw, bool 
runtime)
  		flags |= TB_WAKE_ON_USB4;
  		flags |= TB_WAKE_ON_USB3 | TB_WAKE_ON_PCIE | TB_WAKE_ON_DP;
  	} else if (device_may_wakeup(&sw->dev)) {
+		flags |= TB_WAKE_ON_CONNECT;
  		flags |= TB_WAKE_ON_USB4 | TB_WAKE_ON_USB3 | TB_WAKE_ON_PCIE;
  	}