| Message ID | 20180829075724.9095-1-niklas.cassel@linaro.org |
|---|---|
| Headers | show |
| Series | soc: qcom: Allow COMPILE_TEST of qcom SoC Kconfigs | expand |
On Wed 29 Aug 00:57 PDT 2018, Niklas Cassel wrote: > QCOM_RPHM already selects ARM64, which always selects OF. Nit. "already depends on ARM64" > > Additionally, the rpmh driver only uses linux/of.h, which has dummy > definitions for all functions, in order for code to to be able to > build without CONFIG_OF set. > > Remove the superfluous depends on OF. > > Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > drivers/soc/qcom/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig > index ac657164a136..cf4ece232897 100644 > --- a/drivers/soc/qcom/Kconfig > +++ b/drivers/soc/qcom/Kconfig > @@ -94,7 +94,7 @@ config QCOM_RMTFS_MEM > > config QCOM_RPMH > bool "Qualcomm RPM-Hardened (RPMH) Communication" > - depends on ARCH_QCOM && ARM64 && OF || COMPILE_TEST > + depends on ARCH_QCOM && ARM64 || COMPILE_TEST > help > Support for communication with the hardened-RPM blocks in > Qualcomm Technologies Inc (QTI) SoCs. RPMH communication uses an > -- > 2.17.1 >
On Wed 29 Aug 00:57 PDT 2018, Niklas Cassel wrote: > Since commit cab673583d96 ("soc: Unconditionally include qcom Makefile"), > we unconditionally include the soc/qcom/Makefile. > > This opens up the possibility to compile test the code even when building > for other architectures. > > Allow COMPILE_TEST for all qcom SoC Kconfigs, except for two Kconfigs > that depend on QCOM_SCM, since that triggers lots of build errors in > qcom_scm. > > Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org> > Reviewed-by: Vivek Gautam <vivek.gautam@codeaurora.org> > Reviewed-by: Vinod Koul <vkoul@kernel.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > drivers/soc/qcom/Kconfig | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig > index cf4ece232897..684cb51694d1 100644 > --- a/drivers/soc/qcom/Kconfig > +++ b/drivers/soc/qcom/Kconfig > @@ -33,7 +33,7 @@ config QCOM_GLINK_SSR > > config QCOM_GSBI > tristate "QCOM General Serial Bus Interface" > - depends on ARCH_QCOM > + depends on ARCH_QCOM || COMPILE_TEST > select MFD_SYSCON > help > Say y here to enable GSBI support. The GSBI provides control > @@ -42,7 +42,7 @@ config QCOM_GSBI > > config QCOM_LLCC > tristate "Qualcomm Technologies, Inc. LLCC driver" > - depends on ARCH_QCOM > + depends on ARCH_QCOM || COMPILE_TEST > help > Qualcomm Technologies, Inc. platform specific > Last Level Cache Controller(LLCC) driver. This provides interfaces > @@ -73,7 +73,8 @@ config QCOM_PM > > config QCOM_QMI_HELPERS > tristate > - depends on ARCH_QCOM && NET > + depends on ARCH_QCOM || COMPILE_TEST > + depends on NET > help > Helper library for handling QMI encoded messages. QMI encoded > messages are used in communication between the majority of QRTR > @@ -104,7 +105,7 @@ config QCOM_RPMH > > config QCOM_SMEM > tristate "Qualcomm Shared Memory Manager (SMEM)" > - depends on ARCH_QCOM > + depends on ARCH_QCOM || COMPILE_TEST > depends on HWSPINLOCK > help > Say y here to enable support for the Qualcomm Shared Memory Manager. > @@ -113,7 +114,7 @@ config QCOM_SMEM > > config QCOM_SMD_RPM > tristate "Qualcomm Resource Power Manager (RPM) over SMD" > - depends on ARCH_QCOM > + depends on ARCH_QCOM || COMPILE_TEST > depends on RPMSG > help > If you say yes to this option, support will be included for the > @@ -150,7 +151,7 @@ config QCOM_SMSM > > config QCOM_WCNSS_CTRL > tristate "Qualcomm WCNSS control driver" > - depends on ARCH_QCOM > + depends on ARCH_QCOM || COMPILE_TEST > depends on RPMSG > help > Client driver for the WCNSS_CTRL SMD channel, used to download nv > @@ -158,7 +159,7 @@ config QCOM_WCNSS_CTRL > > config QCOM_APR > tristate "Qualcomm APR Bus (Asynchronous Packet Router)" > - depends on ARCH_QCOM > + depends on ARCH_QCOM || COMPILE_TEST > depends on RPMSG > help > Enable APR IPC protocol support between > -- > 2.17.1 >
Since commit cab673583d96 ("soc: Unconditionally include qcom Makefile"), we unconditionally include the soc/qcom/Makefile. This opens up the possibility to compile test the code even when building for other architectures. This patch series prepares and enables all but two Kconfigs to be compile tested even when building for other architectures. Changes since v5: -kbuild test robot now uses gcc 8, so it found some new warnings with -Wstringop-truncation, created 2 new patches for this. -Removed depends on OF from QCOM_RPMH, new patch. Niklas Cassel (9): soc: qcom: smem: Add missing include of sizes.h soc: qcom: llcc-slice: Add missing include of sizes.h soc: qcom: smp2p: Add select IRQ_DOMAIN soc: qcom: smsm: Add select IRQ_DOMAIN soc: qcom: Remove bogus depends on OF from QCOM_SMD_RPM soc: qcom: Remove depends on OF from QCOM_RPMH soc: qcom: wcnss_ctrl: Avoid string overflow soc: qcom: apr: Avoid string overflow soc: qcom: Allow COMPILE_TEST of qcom SoC Kconfigs drivers/soc/qcom/Kconfig | 21 ++++++++++++--------- drivers/soc/qcom/apr.c | 4 ++-- drivers/soc/qcom/llcc-slice.c | 1 + drivers/soc/qcom/smem.c | 1 + drivers/soc/qcom/wcnss_ctrl.c | 2 +- 5 files changed, 17 insertions(+), 12 deletions(-) -- 2.17.1