diff mbox series

[09/14] mips: dts: ralink: mt7621: use the new compatible string for MT7621 pinctrl

Message ID 20220413060729.27639-10-arinc.unal@arinc9.com
State Superseded
Headers show
Series Refactor Ralink Pinctrl and Add Documentation | expand

Commit Message

Arınç ÜNAL April 13, 2022, 6:07 a.m. UTC
Use the new compatible string "ralink,mt7621-pinctrl" for the Ralink MT7621
pinctrl subdriver on mt7621.dtsi.

Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
---
 arch/mips/boot/dts/ralink/mt7621.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Krzysztof Kozlowski April 13, 2022, 3:27 p.m. UTC | #1
On 13/04/2022 08:07, Arınç ÜNAL wrote:
> Use the new compatible string "ralink,mt7621-pinctrl" for the Ralink MT7621
> pinctrl subdriver on mt7621.dtsi.
> 
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
>  arch/mips/boot/dts/ralink/mt7621.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
> index 3222684915ac..ee2ec78c8952 100644
> --- a/arch/mips/boot/dts/ralink/mt7621.dtsi
> +++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
> @@ -151,7 +151,7 @@ spi0: spi@b00 {
>  	};
>  
>  	pinctrl: pinctrl {
> -		compatible = "ralink,rt2880-pinmux";
> +		compatible = "ralink,mt7621-pinctrl";

The change is non-bisectable and causes issues all other users of DT
(other projects, systems etc). This is discouraged in general, so you
should describe it. The commit msg lacks answer to the main question:
Why? You focused only on what you are doing, but why you are doing is
actually more important for such change.

Best regards,
Krzysztof
Arınç ÜNAL April 14, 2022, 8:38 a.m. UTC | #2
On 13/04/2022 18:27, Krzysztof Kozlowski wrote:
> On 13/04/2022 08:07, Arınç ÜNAL wrote:
>> Use the new compatible string "ralink,mt7621-pinctrl" for the Ralink MT7621
>> pinctrl subdriver on mt7621.dtsi.
>>
>> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
>> ---
>>   arch/mips/boot/dts/ralink/mt7621.dtsi | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
>> index 3222684915ac..ee2ec78c8952 100644
>> --- a/arch/mips/boot/dts/ralink/mt7621.dtsi
>> +++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
>> @@ -151,7 +151,7 @@ spi0: spi@b00 {
>>   	};
>>   
>>   	pinctrl: pinctrl {
>> -		compatible = "ralink,rt2880-pinmux";
>> +		compatible = "ralink,mt7621-pinctrl";
> 
> The change is non-bisectable and causes issues all other users of DT
> (other projects, systems etc). This is discouraged in general, so you
> should describe it. The commit msg lacks answer to the main question:
> Why? You focused only on what you are doing, but why you are doing is
> actually more important for such change.

As it's seen on any other pinctrl subdriver that calls code from a main 
driver, each subdriver needs to have a different compatible string. We 
don't want the same compatible string to match a different subdriver's 
pinmux data as it's not for our SoC.

I'll add what I typed above to the commit log.

Arınç
diff mbox series

Patch

diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
index 3222684915ac..ee2ec78c8952 100644
--- a/arch/mips/boot/dts/ralink/mt7621.dtsi
+++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
@@ -151,7 +151,7 @@  spi0: spi@b00 {
 	};
 
 	pinctrl: pinctrl {
-		compatible = "ralink,rt2880-pinmux";
+		compatible = "ralink,mt7621-pinctrl";
 
 		i2c_pins: i2c0-pins {
 			pinmux {