| Message ID | 20211206182616.2089677-1-f.fainelli@gmail.com |
|---|---|
| Headers | show |
| Series | Broadcom DT bindings updates to YAML | expand |
On Mon, Dec 6, 2021 at 10:26 AM Florian Fainelli <f.fainelli@gmail.com> wrote: > > Convert the Broadcom STB GPIO Device Tree binding to YAML to help with > validation. > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Acked-by: Gregory Fong <gregory.0xf0@gmail.com>
On Mon, 06 Dec 2021 10:26:14 -0800, Florian Fainelli wrote: > Convert the Broadcom SATA3 AHCI controller Device Tree binding to YAML > to help with validation. > > Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- > .../bindings/ata/brcm,sata-brcm.txt | 45 --------- > .../bindings/ata/brcm,sata-brcm.yaml | 91 +++++++++++++++++++ > 2 files changed, 91 insertions(+), 45 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/ata/brcm,sata-brcm.txt > create mode 100644 Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1564108 ahci@41000: $nodename:0: 'ahci@41000' does not match '^sata(@.*)?$' arch/arm/boot/dts/bcm958522er.dt.yaml arch/arm/boot/dts/bcm958525er.dt.yaml arch/arm/boot/dts/bcm958525xmc.dt.yaml arch/arm/boot/dts/bcm958622hr.dt.yaml arch/arm/boot/dts/bcm958623hr.dt.yaml arch/arm/boot/dts/bcm958625hr.dt.yaml arch/arm/boot/dts/bcm958625k.dt.yaml arch/arm/boot/dts/bcm958625-meraki-mx64-a0.dt.yaml arch/arm/boot/dts/bcm958625-meraki-mx64.dt.yaml arch/arm/boot/dts/bcm958625-meraki-mx64w-a0.dt.yaml arch/arm/boot/dts/bcm958625-meraki-mx64w.dt.yaml arch/arm/boot/dts/bcm958625-meraki-mx65.dt.yaml arch/arm/boot/dts/bcm958625-meraki-mx65w.dt.yaml arch/arm/boot/dts/bcm988312hr.dt.yaml ahci@41000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'dma-coherent', 'sata-port@0', 'sata-port@1' were unexpected) arch/arm/boot/dts/bcm958522er.dt.yaml arch/arm/boot/dts/bcm958525er.dt.yaml arch/arm/boot/dts/bcm958525xmc.dt.yaml arch/arm/boot/dts/bcm958622hr.dt.yaml arch/arm/boot/dts/bcm958623hr.dt.yaml arch/arm/boot/dts/bcm958625hr.dt.yaml arch/arm/boot/dts/bcm958625k.dt.yaml arch/arm/boot/dts/bcm958625-meraki-mx64.dt.yaml arch/arm/boot/dts/bcm958625-meraki-mx64w.dt.yaml arch/arm/boot/dts/bcm958625-meraki-mx65.dt.yaml arch/arm/boot/dts/bcm958625-meraki-mx65w.dt.yaml arch/arm/boot/dts/bcm988312hr.dt.yaml ahci@41000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'sata-port@0', 'sata-port@1' were unexpected) arch/arm/boot/dts/bcm958625-meraki-mx64-a0.dt.yaml arch/arm/boot/dts/bcm958625-meraki-mx64w-a0.dt.yaml sata@a000: compatible: 'oneOf' conditional failed, one must be fixed: arch/arm/boot/dts/bcm963138dvt.dt.yaml
On Mon, 06 Dec 2021 10:26:07 -0800, Florian Fainelli wrote: > Convert the Broadcom STB GPIO Device Tree binding to YAML to help with > validation. > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- > .../bindings/gpio/brcm,brcmstb-gpio.txt | 83 -------------- > .../bindings/gpio/brcm,brcmstb-gpio.yaml | 105 ++++++++++++++++++ > MAINTAINERS | 2 +- > 3 files changed, 106 insertions(+), 84 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.txt > create mode 100644 Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.yaml > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1564132 gpio@4172c0: interrupts-extended: [[6, 6], [7, 5]] is too long arch/arm/boot/dts/bcm7445-bcm97445svmb.dt.yaml
On 12/7/21 6:58 AM, Rob Herring wrote: > On Mon, 06 Dec 2021 10:26:07 -0800, Florian Fainelli wrote: >> Convert the Broadcom STB GPIO Device Tree binding to YAML to help with >> validation. >> >> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> >> --- >> .../bindings/gpio/brcm,brcmstb-gpio.txt | 83 -------------- >> .../bindings/gpio/brcm,brcmstb-gpio.yaml | 105 ++++++++++++++++++ >> MAINTAINERS | 2 +- >> 3 files changed, 106 insertions(+), 84 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.txt >> create mode 100644 Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.yaml >> > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/1564132 > > > gpio@4172c0: interrupts-extended: [[6, 6], [7, 5]] is too long > arch/arm/boot/dts/bcm7445-bcm97445svmb.dt.yaml The property is correct AFAICT, we have: interrupts-extended = <&irq0_aon_intc 0x6>, <&aon_pm_l2_intc 0x5>; with both interrupt controllers having #interrupt-cells = <1>. I tried documenting the interrupts-extended for brcm,brcmstb-gpio.yaml to have maxItems: 2 but that does not eliminate the warning. Do you have any suggestions?
On 12/7/21 6:58 AM, Rob Herring wrote: > On Mon, 06 Dec 2021 10:26:14 -0800, Florian Fainelli wrote: >> Convert the Broadcom SATA3 AHCI controller Device Tree binding to YAML >> to help with validation. >> >> Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com> >> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> >> --- >> .../bindings/ata/brcm,sata-brcm.txt | 45 --------- >> .../bindings/ata/brcm,sata-brcm.yaml | 91 +++++++++++++++++++ >> 2 files changed, 91 insertions(+), 45 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/ata/brcm,sata-brcm.txt >> create mode 100644 Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml >> > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/1564108 > > > ahci@41000: $nodename:0: 'ahci@41000' does not match '^sata(@.*)?$' > arch/arm/boot/dts/bcm958522er.dt.yaml > arch/arm/boot/dts/bcm958525er.dt.yaml > arch/arm/boot/dts/bcm958525xmc.dt.yaml > arch/arm/boot/dts/bcm958622hr.dt.yaml > arch/arm/boot/dts/bcm958623hr.dt.yaml > arch/arm/boot/dts/bcm958625hr.dt.yaml > arch/arm/boot/dts/bcm958625k.dt.yaml > arch/arm/boot/dts/bcm958625-meraki-mx64-a0.dt.yaml > arch/arm/boot/dts/bcm958625-meraki-mx64.dt.yaml > arch/arm/boot/dts/bcm958625-meraki-mx64w-a0.dt.yaml > arch/arm/boot/dts/bcm958625-meraki-mx64w.dt.yaml > arch/arm/boot/dts/bcm958625-meraki-mx65.dt.yaml > arch/arm/boot/dts/bcm958625-meraki-mx65w.dt.yaml > arch/arm/boot/dts/bcm988312hr.dt.yaml > > ahci@41000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'dma-coherent', 'sata-port@0', 'sata-port@1' were unexpected) > arch/arm/boot/dts/bcm958522er.dt.yaml > arch/arm/boot/dts/bcm958525er.dt.yaml > arch/arm/boot/dts/bcm958525xmc.dt.yaml > arch/arm/boot/dts/bcm958622hr.dt.yaml > arch/arm/boot/dts/bcm958623hr.dt.yaml > arch/arm/boot/dts/bcm958625hr.dt.yaml > arch/arm/boot/dts/bcm958625k.dt.yaml > arch/arm/boot/dts/bcm958625-meraki-mx64.dt.yaml > arch/arm/boot/dts/bcm958625-meraki-mx64w.dt.yaml > arch/arm/boot/dts/bcm958625-meraki-mx65.dt.yaml > arch/arm/boot/dts/bcm958625-meraki-mx65w.dt.yaml > arch/arm/boot/dts/bcm988312hr.dt.yaml > > ahci@41000: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'sata-port@0', 'sata-port@1' were unexpected) > arch/arm/boot/dts/bcm958625-meraki-mx64-a0.dt.yaml > arch/arm/boot/dts/bcm958625-meraki-mx64w-a0.dt.yaml > > sata@a000: compatible: 'oneOf' conditional failed, one must be fixed: > arch/arm/boot/dts/bcm963138dvt.dt.yaml All of those fixed in v3.