| Message ID | 20240328-tps6598x_fix_event_handling-v1-0-502721ff705b@wolfvision.net |
|---|---|
| Headers | show |
| Series | usb: typec: tipd: fix event checking in interrupt service routines | expand |
On Thu, Mar 28, 2024 at 05:55:50PM +0100, Javier Carrasco wrote: > The ISRs of the tps25750 and tps6598x do not handle generated events > properly under all circumstances. > > The tps6598x ISR does not read all bits of the INT_EVENTX registers, > leaving events signaled with bits above 64 unattended. Moreover, these > events are not cleared, leaving the interrupt enabled. > > The tps25750 reads all bits of the INT_EVENT1 register, but the event > checking is not right because the same event is checked in two different > regions of the same register by means of an OR operation. > > This series aims to fix both issues by reading all bits of the > INT_EVENTX registers, and limiting the event checking to the region > where the supported events are defined (currently they are limited to > the first 64 bits of the registers, as the are defined as BIT_ULL()). > > If the need for events above the first 64 bits of the INT_EVENTX > registers arises, a different mechanism might be required. But for the > current needs, all definitions can be left as they are. > > Note: resend to add the Cc tag for 'stable' (fixes in the series). So this should be v3 (or v2?). Next time please follow the guide when submitting patches: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format thanks,
On 4/2/24 12:21, Heikki Krogerus wrote: > On Thu, Mar 28, 2024 at 05:55:50PM +0100, Javier Carrasco wrote: >> The ISRs of the tps25750 and tps6598x do not handle generated events >> properly under all circumstances. >> >> The tps6598x ISR does not read all bits of the INT_EVENTX registers, >> leaving events signaled with bits above 64 unattended. Moreover, these >> events are not cleared, leaving the interrupt enabled. >> >> The tps25750 reads all bits of the INT_EVENT1 register, but the event >> checking is not right because the same event is checked in two different >> regions of the same register by means of an OR operation. >> >> This series aims to fix both issues by reading all bits of the >> INT_EVENTX registers, and limiting the event checking to the region >> where the supported events are defined (currently they are limited to >> the first 64 bits of the registers, as the are defined as BIT_ULL()). >> >> If the need for events above the first 64 bits of the INT_EVENTX >> registers arises, a different mechanism might be required. But for the >> current needs, all definitions can be left as they are. >> >> Note: resend to add the Cc tag for 'stable' (fixes in the series). > > So this should be v3 (or v2?). Next time please follow the guide > when submitting patches: > https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format > > thanks, > The first resend only added 'stable' to Cc (which was wrong) with no modifications at all, and the second resend (this one) actually modified the commit description to include 'stable', which should have turned it into a v2. I will tag the next version as v3 to account for this, thanks for the feedback. Best regards, Javier Carrasco
The ISRs of the tps25750 and tps6598x do not handle generated events properly under all circumstances. The tps6598x ISR does not read all bits of the INT_EVENTX registers, leaving events signaled with bits above 64 unattended. Moreover, these events are not cleared, leaving the interrupt enabled. The tps25750 reads all bits of the INT_EVENT1 register, but the event checking is not right because the same event is checked in two different regions of the same register by means of an OR operation. This series aims to fix both issues by reading all bits of the INT_EVENTX registers, and limiting the event checking to the region where the supported events are defined (currently they are limited to the first 64 bits of the registers, as the are defined as BIT_ULL()). If the need for events above the first 64 bits of the INT_EVENTX registers arises, a different mechanism might be required. But for the current needs, all definitions can be left as they are. Note: resend to add the Cc tag for 'stable' (fixes in the series). Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net> --- Javier Carrasco (2): usb: typec: tipd: fix event checking for tps25750 usb: typec: tipd: fix event checking for tps6598x drivers/usb/typec/tipd/core.c | 37 +++++++++++++++++++++---------------- 1 file changed, 21 insertions(+), 16 deletions(-) --- base-commit: 4cece764965020c22cff7665b18a012006359095 change-id: 20240328-tps6598x_fix_event_handling-3398d3d82f85 Best regards,