mbox series

[0/5] usb: typec: ucsi: Minor improvements

Message ID 20240815085726.2865482-1-heikki.krogerus@linux.intel.com
Headers show
Series usb: typec: ucsi: Minor improvements | expand

Message

Heikki Krogerus Aug. 15, 2024, 8:57 a.m. UTC
Hi,

The two first patches prevent potential issues. The rest are just
cleanups - removing duplicated or otherwise useless code.

James, can you test these? I'm changing the handling of the identity
discovery in patch 3/5. It would be great if you (or somebody else)
could confirm that it continues to work as expected.

thanks,

Heikki Krogerus (5):
  usb: typec: ucsi: Don't truncate the reads
  usb: typec: ucsi: Only assign the identity structure if the PPM
    supports it
  usb: typec: ucsi: Common function for the GET_PD_MESSAGE command
  usb: typec: ucsi: Call CANCEL from single location
  usb: typec: ucsi: Remove useless error check from ucsi_read_error()

 drivers/usb/typec/ucsi/ucsi.c | 126 ++++++++++------------------------
 drivers/usb/typec/ucsi/ucsi.h |  14 +---
 2 files changed, 39 insertions(+), 101 deletions(-)

Comments

Heikki Krogerus Aug. 15, 2024, 2:51 p.m. UTC | #1
On Thu, Aug 15, 2024 at 11:57:21AM +0300, Heikki Krogerus wrote:
> Hi,
> 
> The two first patches prevent potential issues. The rest are just
> cleanups - removing duplicated or otherwise useless code.
> 
> James, can you test these? I'm changing the handling of the identity
> discovery in patch 3/5. It would be great if you (or somebody else)
> could confirm that it continues to work as expected.
> 
> thanks,
> 
> Heikki Krogerus (5):
>   usb: typec: ucsi: Don't truncate the reads
>   usb: typec: ucsi: Only assign the identity structure if the PPM
>     supports it
>   usb: typec: ucsi: Common function for the GET_PD_MESSAGE command
>   usb: typec: ucsi: Call CANCEL from single location
>   usb: typec: ucsi: Remove useless error check from ucsi_read_error()
> 
>  drivers/usb/typec/ucsi/ucsi.c | 126 ++++++++++------------------------
>  drivers/usb/typec/ucsi/ucsi.h |  14 +---
>  2 files changed, 39 insertions(+), 101 deletions(-)

These are in wrong order. They break bisectability. I'll prepare v2.

thanks,
Heikki Krogerus Aug. 15, 2024, 3:08 p.m. UTC | #2
On Thu, Aug 15, 2024 at 07:59:31AM -0700, Benson Leung wrote:
> Hi Heikki,
> 
> 
> On Thu, Aug 15, 2024 at 7:51 AM Heikki Krogerus
> <heikki.krogerus@linux.intel.com> wrote:
> >
> > On Thu, Aug 15, 2024 at 11:57:21AM +0300, Heikki Krogerus wrote:
> > > Hi,
> > >
> > > The two first patches prevent potential issues. The rest are just
> > > cleanups - removing duplicated or otherwise useless code.
> > >
> > > James, can you test these? I'm changing the handling of the identity
> > > discovery in patch 3/5. It would be great if you (or somebody else)
> > > could confirm that it continues to work as expected.
> > >
> > > thanks,
> > >
> > > Heikki Krogerus (5):
> > >   usb: typec: ucsi: Don't truncate the reads
> > >   usb: typec: ucsi: Only assign the identity structure if the PPM
> > >     supports it
> > >   usb: typec: ucsi: Common function for the GET_PD_MESSAGE command
> > >   usb: typec: ucsi: Call CANCEL from single location
> > >   usb: typec: ucsi: Remove useless error check from ucsi_read_error()
> > >
> > >  drivers/usb/typec/ucsi/ucsi.c | 126 ++++++++++------------------------
> > >  drivers/usb/typec/ucsi/ucsi.h |  14 +---
> > >  2 files changed, 39 insertions(+), 101 deletions(-)
> >
> > These are in wrong order. They break bisectability. I'll prepare v2.
> 
> Can you please cc +Abhishek Pandit-Subedi <abhishekpandit@google.com>
> and +Bartosz Szpila  <bszpila@google.com> on v2?
> 
> They're also working on UCSI and can help too.

Sure thing. I'll prepare new version tomorrow and CC you guys.

Br,