| Message ID | 717ddd7c-22cd-d82c-e43d-80254718c801@omp.ru |
|---|---|
| Headers | show |
| Series | Stop calling devm_request_irq() with invalid IRQs in the USB drivers | expand |
Hi Sergey, On Sun, Aug 8, 2021 at 10:37 PM Sergey Shtylyov <s.shtylyov@omp.ru> wrote: > > The driver neglects to check the result of platform_get_irq()'s call and > blithely passes the negative error codes to devm_request_threaded_irq() > (which takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding > an original error code. Stop calling devm_request_threaded_irq() with the > invalid IRQ #s. > > Fixes: f90db10779ad ("usb: dwc3: meson-g12a: Add support for IRQ based OTG switching") > Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> Thanks for spotting and fixing this issue! Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Oops, duplicate patch. Scratch the series, I'm going to restart posting tomorrow... :-)
Sergey Shtylyov <s.shtylyov@omp.ru> writes: > The driver neglects to check the result of platform_get_irq()'s call and > blithely passes the negative error codes to devm_request_irq() (which takes > *unsigned* IRQ #), causing it to fail with -EINVAL, overriding an original > error code. Stop calling devm_request_irq() with the invalid IRQ #s. > > Fixes: 8b2e76687b39 ("USB: AT91 UDC updates, mostly power management") > Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> > > --- > drivers/usb/gadget/udc/at91_udc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > Index: usb/drivers/usb/gadget/udc/at91_udc.c > =================================================================== > --- usb.orig/drivers/usb/gadget/udc/at91_udc.c > +++ usb/drivers/usb/gadget/udc/at91_udc.c > @@ -1876,7 +1876,9 @@ static int at91udc_probe(struct platform > clk_disable(udc->iclk); > > /* request UDC and maybe VBUS irqs */ > - udc->udp_irq = platform_get_irq(pdev, 0); > + udc->udp_irq = retval = platform_get_irq(pdev, 0); > + if (retval < 0) > + goto err_unprepare_iclk; let's avoid multiple assignments in one line. How about: if (udc->udp_irq < 0) { retval = udc->udp_irq; goto err_unprepare_iclk; } -- balbi
Sergey Shtylyov <s.shtylyov@omp.ru> writes: > The driver neglects to check the result of platform_get_irq()'s call and > blithely passes the negative error codes to devm_request_threaded_irq() > (which takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding > an original error code. Stop calling devm_request_threaded_irq() with the > invalid IRQ #s. > > Fixes: f90db10779ad ("usb: dwc3: meson-g12a: Add support for IRQ based OTG switching") > Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> Acked-by: Felipe Balbi <balbi@kernel.org> -- balbi
Sergey Shtylyov <s.shtylyov@omp.ru> writes: > The driver neglects to check the result of platform_get_irq()'s call and > blithely passes the negative error codes to devm_request_irq() (which takes > *unsigned* IRQ #), causing it to fail with -EINVAL, overriding an original > error code. Stop calling devm_request_irq() with the invalid IRQ #s. > > Fixes: 8b2e76687b39 ("USB: AT91 UDC updates, mostly power management") > Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> Acked-by: Felipe Balbi <balbi@kernel.org>
On Sun, Aug 08, 2021 at 11:30:57PM +0300, Sergey Shtylyov wrote: > Here are 9 patches against the 'usb-linus' branch of GregKH's 'usb.git' repo. > The affected drivers call platform_get_irq() but largely ignore its result -- > they blithely pass the negative error codes to request_irq() (and its ilk) > which expects *unsinged* IRQ #s. Stop doing that by checking what exactly > platform_get_irq() returns. > > [1/9] usb: dwc3: meson-g12a: add IRQ check > [2/9] usb: dwc3: qcom: add IRQ check > [3/61] usb: gadget: udc: at91: add IRQ check 61? > [4/9] usb: gadget: udc: s3c2410: add IRQ check > [5/9] usb: host: ohci-tmio: add IRQ check > [6/9] usb: misc: brcmstb-usb-pinmap: add IRQ check > [7/9] usb: phy: fsl-usb: add IRQ check > [8/9] usb: phy: tahvo: add IRQ check > [9/9] usb: phy: twl6030: add IRQ checks I only see 4 patches in this series, and the 4th, did not apply to my tree :( Can you please fix this up and resend it correctly? thanks, greg k-h
On Fri, Aug 13, 2021 at 08:58:58AM +0200, Greg Kroah-Hartman wrote: > On Sun, Aug 08, 2021 at 11:30:57PM +0300, Sergey Shtylyov wrote: > > Here are 9 patches against the 'usb-linus' branch of GregKH's 'usb.git' repo. > > The affected drivers call platform_get_irq() but largely ignore its result -- > > they blithely pass the negative error codes to request_irq() (and its ilk) > > which expects *unsinged* IRQ #s. Stop doing that by checking what exactly > > platform_get_irq() returns. > > > > [1/9] usb: dwc3: meson-g12a: add IRQ check > > [2/9] usb: dwc3: qcom: add IRQ check > > [3/61] usb: gadget: udc: at91: add IRQ check > > 61? > > > [4/9] usb: gadget: udc: s3c2410: add IRQ check > > [5/9] usb: host: ohci-tmio: add IRQ check > > [6/9] usb: misc: brcmstb-usb-pinmap: add IRQ check > > [7/9] usb: phy: fsl-usb: add IRQ check > > [8/9] usb: phy: tahvo: add IRQ check > > [9/9] usb: phy: twl6030: add IRQ checks > > > I only see 4 patches in this series, and the 4th, did not apply to my > tree :( > > Can you please fix this up and resend it correctly? Ah, see your v2 now...