diff mbox series

[04/30] usb: ohci-at91: Remove redundant msg at probe time

Message ID 20230726113816.888-4-frank.li@vivo.com
State New
Headers show
Series [01/30] usb: ehci-npcm7xx: fix typo in npcm7xx_ehci_hcd_drv_probe() | expand

Commit Message

Yangtao Li July 26, 2023, 11:37 a.m. UTC 
platform_get_irq() directly prints error information.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 drivers/usb/host/ohci-at91.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Claudiu July 27, 2023, 5:35 a.m. UTC | #1 
On 26.07.2023 14:37, Yangtao Li wrote:
> platform_get_irq() directly prints error information.
> 
> Signed-off-by: Yangtao Li <frank.li@vivo.com>

Reviewed-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>

> ---
>   drivers/usb/host/ohci-at91.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
> index f957d008f360..439d8a16d7c5 100644
> --- a/drivers/usb/host/ohci-at91.c
> +++ b/drivers/usb/host/ohci-at91.c
> @@ -190,10 +190,8 @@ static int usb_hcd_at91_probe(const struct hc_driver *driver,
>   	int irq;
>   
>   	irq = platform_get_irq(pdev, 0);
> -	if (irq < 0) {
> -		dev_dbg(dev, "hcd probe: missing irq resource\n");
> +	if (irq < 0)
>   		return irq;
> -	}
>   
>   	hcd = usb_create_hcd(driver, dev, "at91");
>   	if (!hcd)
diff mbox series

Patch

diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
index f957d008f360..439d8a16d7c5 100644
--- a/drivers/usb/host/ohci-at91.c
+++ b/drivers/usb/host/ohci-at91.c
@@ -190,10 +190,8 @@  static int usb_hcd_at91_probe(const struct hc_driver *driver,
 	int irq;
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0) {
-		dev_dbg(dev, "hcd probe: missing irq resource\n");
+	if (irq < 0)
 		return irq;
-	}
 
 	hcd = usb_create_hcd(driver, dev, "at91");
 	if (!hcd)