| Message ID | 2a4317353557e4fac2a7bfa4261a75886eebe41b.1748453565.git.dan.carpenter@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | usb: chipidea: Add support for s32g2 and s32g3 | expand |
On Wed, May 28, 2025 at 10:57:10PM +0300, Dan Carpenter wrote: > From: Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com> > > Add the compatible strings for the NXP s32g2 and s32g3. > > Signed-off-by: Larisa Grigore <larisa.grigore@nxp.com> > Signed-off-by: Ionut Vicovan <Ionut.Vicovan@nxp.com> > Signed-off-by: Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com> > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml | 2 ++ > Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > index cc5787a8cfa3..400d885fea96 100644 > --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > @@ -24,6 +24,8 @@ properties: > - nvidia,tegra114-udc > - nvidia,tegra124-udc > - qcom,ci-hdrc > + - nxp,s32g2-usb > + - nxp,s32g3-usb keep alphabet order! Can you use b4 to send patch, look like cc list missed imx@lists.linux.dev Frank > - items: > - enum: > - nvidia,tegra114-ehci > diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml > index 019435540df0..ca677d1a8274 100644 > --- a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml > +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml > @@ -21,6 +21,8 @@ properties: > - fsl,imx53-usbmisc > - fsl,imx6q-usbmisc > - fsl,vf610-usbmisc > + - nxp,s32g2-usbmisc > + - nxp,s32g3-usbmisc > - items: > - enum: > - fsl,imx6ul-usbmisc > -- > 2.47.2 >
On 28/05/2025 21:57, Dan Carpenter wrote: > From: Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com> > > Add the compatible strings for the NXP s32g2 and s32g3. Why these are not compatible? Explain the hardware in the commit msg. Your driver, although you did not Cc me on it, suggests they are compatible. Anyway you have entire commit msg to explain unusual things. Best regards, Krzysztof
On Wed, May 28, 2025 at 05:22:36PM -0400, Frank Li wrote: > On Wed, May 28, 2025 at 10:57:10PM +0300, Dan Carpenter wrote: > > From: Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com> > > > > Add the compatible strings for the NXP s32g2 and s32g3. > > > > Signed-off-by: Larisa Grigore <larisa.grigore@nxp.com> > > Signed-off-by: Ionut Vicovan <Ionut.Vicovan@nxp.com> > > Signed-off-by: Ghennadi Procopciuc <ghennadi.procopciuc@nxp.com> > > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > > --- > > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml | 2 ++ > > Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml | 2 ++ > > 2 files changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > > index cc5787a8cfa3..400d885fea96 100644 > > --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml > > @@ -24,6 +24,8 @@ properties: > > - nvidia,tegra114-udc > > - nvidia,tegra124-udc > > - qcom,ci-hdrc > > + - nxp,s32g2-usb > > + - nxp,s32g3-usb > > keep alphabet order! Ah, sure. > Can you use b4 to send patch, look like cc list missed > imx@lists.linux.dev It's MAINTAINERS file which is wrong here. $ ./scripts/get_maintainer.pl -f Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml Greg Kroah-Hartman <gregkh@linuxfoundation.org> (maintainer:USB SUBSYSTEM) Rob Herring <robh@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Krzysztof Kozlowski <krzk+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Conor Dooley <conor+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Xu Yang <xu.yang_2@nxp.com> (in file) Peng Fan <peng.fan@nxp.com> (in file) linux-usb@vger.kernel.org (open list:USB SUBSYSTEM) devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) linux-kernel@vger.kernel.org (open list) USB SUBSYSTEM status: Supported regards, dan carpenter
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml index cc5787a8cfa3..400d885fea96 100644 --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml @@ -24,6 +24,8 @@ properties: - nvidia,tegra114-udc - nvidia,tegra124-udc - qcom,ci-hdrc + - nxp,s32g2-usb + - nxp,s32g3-usb - items: - enum: - nvidia,tegra114-ehci diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml index 019435540df0..ca677d1a8274 100644 --- a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml @@ -21,6 +21,8 @@ properties: - fsl,imx53-usbmisc - fsl,imx6q-usbmisc - fsl,vf610-usbmisc + - nxp,s32g2-usbmisc + - nxp,s32g3-usbmisc - items: - enum: - fsl,imx6ul-usbmisc