diff mbox series

[v3,11/18] dt-bindings: power: supply: add AXP20X/AXP22X battery DT binding

Message ID 20170214094112.27426-12-quentin.schulz@free-electrons.com
State Superseded
Headers show
Series add support for AXP20X and AXP22X power supply drivers | expand

Commit Message

Quentin Schulz Feb. 14, 2017, 9:41 a.m. UTC
The X-Powers AXP20X and AXP22X PMICs can have a battery as power supply.

This patch adds the DT binding documentation for the battery power
supply which gets various data from the PMIC, such as the battery status
(charging, discharging, full, dead), current max limit, current current,
battery capacity (in percentage), voltage max and min limits, current
voltage and battery capacity (in Ah).

Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

---

v3:
 - removed constant charge current property, now should use the WIP
 battery framework,

v2:
 - changed DT node name from ac_power_supply to ac-power-supply,
 - removed io-channels and io-channel-names from DT (the IIO mapping is
 done in the IIO ADC driver now),
 - added x-powers,constant-charge-current property to set the maximal
 default constant current charge of the battery,

 .../bindings/power/supply/axp20x_battery.txt         | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/axp20x_battery.txt

-- 
2.9.3

Comments

Chen-Yu Tsai Feb. 21, 2017, 4:45 a.m. UTC | #1
On Tue, Feb 14, 2017 at 5:41 PM, Quentin Schulz
<quentin.schulz@free-electrons.com> wrote:
> The X-Powers AXP20X and AXP22X PMICs can have a battery as power supply.

>

> This patch adds the DT binding documentation for the battery power

> supply which gets various data from the PMIC, such as the battery status

> (charging, discharging, full, dead), current max limit, current current,

> battery capacity (in percentage), voltage max and min limits, current

> voltage and battery capacity (in Ah).

>

> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>

> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

> ---

>

> v3:

>  - removed constant charge current property, now should use the WIP

>  battery framework,


IIRC this should also include a property for referencing the battery?

Otherwise,

Acked-by: Chen-Yu Tsai <wens@csie.org>


>

> v2:

>  - changed DT node name from ac_power_supply to ac-power-supply,

>  - removed io-channels and io-channel-names from DT (the IIO mapping is

>  done in the IIO ADC driver now),

>  - added x-powers,constant-charge-current property to set the maximal

>  default constant current charge of the battery,

>

>  .../bindings/power/supply/axp20x_battery.txt         | 20 ++++++++++++++++++++

>  1 file changed, 20 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/power/supply/axp20x_battery.txt

>

> diff --git a/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt b/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt

> new file mode 100644

> index 0000000..c248866

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt

> @@ -0,0 +1,20 @@

> +AXP20x and AXP22x battery power supply

> +

> +Required Properties:

> + - compatible, one of:

> +                       "x-powers,axp209-battery-power-supply"

> +                       "x-powers,axp221-battery-power-supply"

> +

> +This node is a subnode of the axp20x/axp22x PMIC.

> +

> +The AXP20X and AXP22X can read the battery voltage, charge and discharge

> +currents of the battery by reading ADC channels from the AXP20X/AXP22X

> +ADC.

> +

> +Example:

> +

> +&axp209 {

> +       battery_power_supply: battery-power-supply {

> +               compatible = "x-powers,axp209-battery-power-supply";

> +       }

> +};

> --

> 2.9.3

>
Quentin Schulz Feb. 21, 2017, 6:05 p.m. UTC | #2
Hi Chen-Yu,

On 21/02/2017 05:45, Chen-Yu Tsai wrote:
> On Tue, Feb 14, 2017 at 5:41 PM, Quentin Schulz

> <quentin.schulz@free-electrons.com> wrote:

>> The X-Powers AXP20X and AXP22X PMICs can have a battery as power supply.

>>

>> This patch adds the DT binding documentation for the battery power

>> supply which gets various data from the PMIC, such as the battery status

>> (charging, discharging, full, dead), current max limit, current current,

>> battery capacity (in percentage), voltage max and min limits, current

>> voltage and battery capacity (in Ah).

>>

>> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>

>> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

>> ---

>>

>> v3:

>>  - removed constant charge current property, now should use the WIP

>>  battery framework,

> 

> IIRC this should also include a property for referencing the battery?

> 


Indeed.

Quentin

> Otherwise,

> 

> Acked-by: Chen-Yu Tsai <wens@csie.org>

> 

>>

>> v2:

>>  - changed DT node name from ac_power_supply to ac-power-supply,

>>  - removed io-channels and io-channel-names from DT (the IIO mapping is

>>  done in the IIO ADC driver now),

>>  - added x-powers,constant-charge-current property to set the maximal

>>  default constant current charge of the battery,

>>

>>  .../bindings/power/supply/axp20x_battery.txt         | 20 ++++++++++++++++++++

>>  1 file changed, 20 insertions(+)

>>  create mode 100644 Documentation/devicetree/bindings/power/supply/axp20x_battery.txt

>>

>> diff --git a/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt b/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt

>> new file mode 100644

>> index 0000000..c248866

>> --- /dev/null

>> +++ b/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt

>> @@ -0,0 +1,20 @@

>> +AXP20x and AXP22x battery power supply

>> +

>> +Required Properties:

>> + - compatible, one of:

>> +                       "x-powers,axp209-battery-power-supply"

>> +                       "x-powers,axp221-battery-power-supply"

>> +

>> +This node is a subnode of the axp20x/axp22x PMIC.

>> +

>> +The AXP20X and AXP22X can read the battery voltage, charge and discharge

>> +currents of the battery by reading ADC channels from the AXP20X/AXP22X

>> +ADC.

>> +

>> +Example:

>> +

>> +&axp209 {

>> +       battery_power_supply: battery-power-supply {

>> +               compatible = "x-powers,axp209-battery-power-supply";

>> +       }

>> +};

>> --

>> 2.9.3

>>


-- 
Quentin Schulz, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt b/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt
new file mode 100644
index 0000000..c248866
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/supply/axp20x_battery.txt
@@ -0,0 +1,20 @@ 
+AXP20x and AXP22x battery power supply
+
+Required Properties:
+ - compatible, one of:
+			"x-powers,axp209-battery-power-supply"
+			"x-powers,axp221-battery-power-supply"
+
+This node is a subnode of the axp20x/axp22x PMIC.
+
+The AXP20X and AXP22X can read the battery voltage, charge and discharge
+currents of the battery by reading ADC channels from the AXP20X/AXP22X
+ADC.
+
+Example:
+
+&axp209 {
+	battery_power_supply: battery-power-supply {
+		compatible = "x-powers,axp209-battery-power-supply";
+	}
+};